From patchwork Fri Aug 30 16:47:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak Gupta X-Patchwork-Id: 13785379 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 194C6CA0EFD for ; Fri, 30 Aug 2024 16:53:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sk4nH-0000Uw-Cc; Fri, 30 Aug 2024 12:48:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sk4nD-0000Pq-Kf for qemu-devel@nongnu.org; Fri, 30 Aug 2024 12:48:11 -0400 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sk4nA-0006uF-Vp for qemu-devel@nongnu.org; Fri, 30 Aug 2024 12:48:11 -0400 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2d877e9054eso515215a91.3 for ; Fri, 30 Aug 2024 09:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1725036487; x=1725641287; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TYumrgjf2snc/wxlVluCIEC+jKO6uski66iPlIXeCxk=; b=HspgTbP23nHHqQX//gsR+3jSJIUO3SdRxRTb5dORbNTveaBLLm08ajVkpUjwgn7Hds UAUtGguq1V9Z2n/TO6BSQWzYnNm+2F5CcJekARID9f2ZjAjNLJLswZwCSUE0jQvwFhqt 7P3vMxQENR/qRNStWlY+StqxWSJHYLu67f9GmFhgkU6yAsaNPaZLP2pOfCXz81T1PMHY sfzJwd5uSwtXvK9lUZq7os5j51L3dTJWoBO/2Unb3sMew6CDqZ22jxsDoSzq++x9MAsb 3TWam4yUlL3R8SoBLt7Pz0OGKFP7yzFOS4e5woBAS1WIYk4AnkluBQghClK7XVn1Rrqd s+lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725036487; x=1725641287; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TYumrgjf2snc/wxlVluCIEC+jKO6uski66iPlIXeCxk=; b=BCkPHKkManGYU5/k4m9tPRhWQ7/zmB1FvRS2PJxcvnJhAc+WnBte/s8h6PsReSuOal JLDOeeeLGLyuVPxjVv/triwktVI8ds1SxT0TGjYnvXycYpwhSr0zOV4xdBh748Zq3sA9 BkdoLXJUzRyr/sPW1mlizcw3H/I16BXdW6aXi+ygvCcscNwH+8Kab3rBh1Ediud8rRpD TUKg2VX43aY6NBEiKLKHHritxllFbpOfkQAiFHzSzS5KJsZwDiA+6lPezNbTXDPKCoQx yh39qX2ytRB28lnFPQEqc+tgL3HoKUs5lRtrteC1StnbpKx6MJsqunHzfu9oxrjI1+dp R8ww== X-Forwarded-Encrypted: i=1; AJvYcCUnOuu283aNJpGekJ7EbSwCtzPMFDrjm0L0+jMSbpm7IhgUrgyWqwzVFij7uoC09+dn3m1IJqKvs7Io@nongnu.org X-Gm-Message-State: AOJu0YxAw2ISnJ6nKSSTuVZNm43oLWGGdTw0/Nm3EH6e5cUWMWQ9D+ic it6BddzLvECrbB7BAtOkQKt9lmziFz5hFwgzgD6Em9hCstb+mmSXWkXoVzPSCdSPeaDfIgrgNsg t X-Google-Smtp-Source: AGHT+IHL8t7oi1/HWDLv9/KlocxS3Im3Nep6DbTmdp7HRZY0SybY8yFEk2AGtsj4FSuURes/K/ddGQ== X-Received: by 2002:a17:90b:4c0b:b0:2c7:8a94:215d with SMTP id 98e67ed59e1d1-2d8561a13e6mr7145190a91.12.1725036486752; Fri, 30 Aug 2024 09:48:06 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d8445e813dsm6591257a91.17.2024.08.30.09.48.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 09:48:06 -0700 (PDT) From: Deepak Gupta To: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Cc: palmer@dabbelt.com, Alistair.Francis@wdc.com, bmeng.cn@gmail.com, liwei1518@gmail.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, jim.shu@sifive.com, andy.chiu@sifive.com, kito.cheng@sifive.com, Deepak Gupta Subject: [PATCH v13 00/20] riscv support for control flow integrity extensions Date: Fri, 30 Aug 2024 09:47:36 -0700 Message-ID: <20240830164756.1154517-1-debug@rivosinc.com> X-Mailer: git-send-email 2.45.0 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=debug@rivosinc.com; helo=mail-pj1-x1032.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org v13 for riscv zicfilp and zicfiss extensions support in qemu. zicfilp and zicfiss spec pdf https://github.com/riscv/riscv-cfi/releases/download/v1.0/riscv-cfi.pdf github sources to spec https://github.com/riscv/riscv-cfi I have kept names of `cpu_get_bcfien` or `cpu_get_fcfien` same and didn't change them because in most cases when they're used, they are conveying intent of whether in current execution environment backward cfi / forward cfi is enabled or not. Links for previous versions [1] - v1 https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg06017.html [2] - v2 https://lore.kernel.org/all/ed23bcbc-fdc4-4492-803c-daa95880375a@linaro.org/T/ [3] - v3 https://lists.nongnu.org/archive/html/qemu-devel/2024-08/msg01005.html [4] - v4 https://lore.kernel.org/all/20240816010711.3055425-6-debug@rivosinc.com/T/ [5] - v5 +https://lore.kernel.org/all/20240820000129.3522346-1-debug@rivosinc.com/T/#m7b9cc847e739ec86f9569a3ca9f3d9377b01e21 [6] - v6 https://mail.gnu.org/archive/html/qemu-riscv/2024-08/msg00418.html [7] - v7 https://lore.kernel.org/all/20240822082504.3979610-1-debug@rivosinc.com/ [8] - v8 https://lore.kernel.org/all/20240823190140.4156920-1-debug@rivosinc.com/T/ [9] - v9 https://lore.kernel.org/all/20240826152949.294506-1-debug@rivosinc.com/ [10]- v10 https://lore.kernel.org/all/20240827231906.553327-1-debug@rivosinc.com/ [11]- v11 https://lore.kernel.org/all/20240828174739.714313-1-debug@rivosinc.com/ [12]- v12 https://lore.kernel.org/all/20240829233425.1005029-1-debug@rivosinc.com/ --- v13: - Fixed bug(s) reported by richard that - shadow stack doesn't exist in M-mode - shadow stack is not available in M + U only config - updated commit messages with removal of `ufcfien` and `ubcfien` mentions v12 - Moved ssamoswap to trans_rvzicfiss. - Fixed bcfi_enabled in disascontext to rely only on tb flag - added comment on why PMP_TRANSLATE_FAIL for stores on shadow stack page v11: - default *envcfg and priv for qemu-user are handled in `riscv_cpu_reset_hold` v10: - Exposed *envcfg CSR and priv to qemu-user as well and removed special state management for *envcfg related feature enabling for qemu-user - Exposing zicfilp and zicfiss as different patch v9: - fix switch case fallthrough for sw_check excp in patch 4 v8: - fixed up `gen_cmpxchg` to store extra word2 during compile to raise storeAMO always v7: - Updated decode_save_opc to take extra argument of excp_uw2 and updated callsites - added a helper for promoting load faults to store faults - Removed stale comments and edited existed comments v6: - Added support extra store word 2 for tcg compile and extraction during unwind - Using extra word, AMO instructions and shadow stack instructions can raise store fault - some alignment and cosmetic changes - added vmstate migration support for elp and ssp cpu state v5: - Simplified elp tracking and lpad implementation as per suggestion by richard - Simplified shadow stack mmu checks as per suggestion by richard - Converged zicfiss compressed and non-comressed instructions to same translation - Removed trace hooks. Don't need for upstream. v4: - elp state in cpu is true/false instead of enum and elp cleared unconditionally on trap entry. elp in *status cleared unconditionally on trap return. - Moved logic for branch tracking in instruction translation from tb_start. - fixed zicfiss dependency on 'A' - `cpu_get_fcfien/bcfien` helpers checks fixed to check for extension first. - removed trace hook enums. Instead added dedicated trace helpers wherever needed. - fixed/simplified instruction format in decoder for lpad, sspush, sspopchk - simplified tlb index logic for shadow stack instructions. Removed SUM TB_FLAG - access to ssp CSR is gated on `cpu_get_bcfien` instead of duplicated logic - removed vDSO related changes for now. v3: - Removed prctl specific patches because they need to be upstream in kernel first. - As suggested by Richard, added TB flag if fcfi enabled - Re-worked translation for landing pad and shadow stack instructions to not require helper. - tcg helpers only for cfi violation cases so that trace hooks can be placed. - Style changes. - fixes assert condition in accel/tcg v2: - added missed file (in v1) for shadow stack instructions implementation. Deepak Gupta (20): target/riscv: expose *envcfg csr and priv to qemu-user as well target/riscv: Add zicfilp extension target/riscv: Introduce elp state and enabling controls for zicfilp target/riscv: save and restore elp state on priv transitions target/riscv: additional code information for sw check target/riscv: tracking indirect branches (fcfi) for zicfilp target/riscv: zicfilp `lpad` impl and branch tracking disas/riscv: enable `lpad` disassembly target/riscv: Expose zicfilp extension as a cpu property target/riscv: Add zicfiss extension target/riscv: introduce ssp and enabling controls for zicfiss target/riscv: tb flag for shadow stack instructions target/riscv: mmu changes for zicfiss shadow stack protection target/riscv: AMO operations always raise store/AMO fault target/riscv: update `decode_save_opc` to store extra word2 target/riscv: implement zicfiss instructions target/riscv: compressed encodings for sspush and sspopchk disas/riscv: enable disassembly for zicfiss instructions disas/riscv: enable disassembly for compressed sspush/sspopchk target/riscv: Expose zicfiss extension as a cpu property disas/riscv.c | 77 +++++++- disas/riscv.h | 4 + target/riscv/cpu.c | 14 ++ target/riscv/cpu.h | 31 +++- target/riscv/cpu_bits.h | 17 ++ target/riscv/cpu_cfg.h | 2 + target/riscv/cpu_helper.c | 166 +++++++++++++++++- target/riscv/cpu_user.h | 1 + target/riscv/csr.c | 84 +++++++++ target/riscv/insn16.decode | 4 + target/riscv/insn32.decode | 26 ++- .../riscv/insn_trans/trans_privileged.c.inc | 8 +- target/riscv/insn_trans/trans_rva.c.inc | 4 +- target/riscv/insn_trans/trans_rvd.c.inc | 4 +- target/riscv/insn_trans/trans_rvf.c.inc | 4 +- target/riscv/insn_trans/trans_rvh.c.inc | 8 +- target/riscv/insn_trans/trans_rvi.c.inc | 61 ++++++- target/riscv/insn_trans/trans_rvvk.c.inc | 10 +- target/riscv/insn_trans/trans_rvzacas.c.inc | 4 +- target/riscv/insn_trans/trans_rvzfh.c.inc | 4 +- target/riscv/insn_trans/trans_rvzicfiss.c.inc | 114 ++++++++++++ target/riscv/insn_trans/trans_svinval.c.inc | 6 +- target/riscv/internals.h | 3 + target/riscv/machine.c | 38 ++++ target/riscv/op_helper.c | 18 ++ target/riscv/pmp.c | 5 + target/riscv/pmp.h | 3 +- target/riscv/tcg/tcg-cpu.c | 29 +++ target/riscv/translate.c | 44 ++++- 29 files changed, 739 insertions(+), 54 deletions(-) create mode 100644 target/riscv/insn_trans/trans_rvzicfiss.c.inc