| Message ID | 20240926113323.55991-1-yangyicong@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Building PPTT with root node and identical implementation flag | expand |
On Thu, 26 Sep 2024 19:33:18 +0800 Yicong Yang <yangyicong@huawei.com> wrote: > From: Yicong Yang <yangyicong@hisilicon.com> > > OS like Linux is using PPTT processor node's identical implementation > flag [1] to infer whether the whole system or a certain CPU cluster is > homogeneous or not [2]. QEMU currently only support building homogeneous > system, set the flag to indicate the fact. Build a root node in PPTT > for indicates the identical implementation which is needed for a > multi-socket system. Update the related PPTT tables as well. > > Since we'll update the test PPTT table data, upgrade the revision of PPTT > we build to revision 3 by handy. > > [1] ACPI 6.5 Table 5.158: Processor Structure Flags > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/acpi/pptt.c?h=v6.11-rc1#n810 > > Yicong Yang (5): > tests: virt: Allow changes to PPTT test table > hw/acpi/aml-build: Set identical implementation flag for PPTT > processor nodes > hw/acpi/aml-build: Build a root node in the PPTT table > hw/acpi/aml-build: Update the revision of PPTT table > tests: virt: Update expected ACPI tables for virt test > > hw/acpi/aml-build.c | 26 ++++++++++++++---- > tests/data/acpi/aarch64/virt/PPTT | Bin 76 -> 96 bytes > .../data/acpi/aarch64/virt/PPTT.acpihmatvirt | Bin 156 -> 176 bytes > tests/data/acpi/aarch64/virt/PPTT.topology | Bin 336 -> 356 bytes > 4 files changed, 21 insertions(+), 5 deletions(-) > Maybe some ASCII art makes sense? Mine you it's pretty simple conceptually so perhaps not worth bothering. Patches look good to me. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Ali, probably sensible to rebase your series on top of this if you haven't already. Jonathan
On Fri, 4 Oct 2024 10:59:20 +0100 Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote: > On Thu, 26 Sep 2024 19:33:18 +0800 > Yicong Yang <yangyicong@huawei.com> wrote: > > > From: Yicong Yang <yangyicong@hisilicon.com> > > > > OS like Linux is using PPTT processor node's identical > > implementation flag [1] to infer whether the whole system or a > > certain CPU cluster is homogeneous or not [2]. QEMU currently only > > support building homogeneous system, set the flag to indicate the > > fact. Build a root node in PPTT for indicates the identical > > implementation which is needed for a multi-socket system. Update > > the related PPTT tables as well. > > > > Since we'll update the test PPTT table data, upgrade the revision > > of PPTT we build to revision 3 by handy. > > > > [1] ACPI 6.5 Table 5.158: Processor Structure Flags > > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/acpi/pptt.c?h=v6.11-rc1#n810 > > > > Yicong Yang (5): > > tests: virt: Allow changes to PPTT test table > > hw/acpi/aml-build: Set identical implementation flag for PPTT > > processor nodes > > hw/acpi/aml-build: Build a root node in the PPTT table > > hw/acpi/aml-build: Update the revision of PPTT table > > tests: virt: Update expected ACPI tables for virt test > > > > hw/acpi/aml-build.c | 26 > > ++++++++++++++---- tests/data/acpi/aarch64/virt/PPTT | > > Bin 76 -> 96 bytes .../data/acpi/aarch64/virt/PPTT.acpihmatvirt | > > Bin 156 -> 176 bytes tests/data/acpi/aarch64/virt/PPTT.topology > > | Bin 336 -> 356 bytes 4 files changed, 21 insertions(+), 5 > > deletions(-) > > Maybe some ASCII art makes sense? Mine you it's pretty simple > conceptually so perhaps not worth bothering. > > Patches look good to me. > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Ali, probably sensible to rebase your series on top of this if you > haven't already. Sure, makes sense, imma rebase. > > Jonathan
From: Yicong Yang <yangyicong@hisilicon.com> OS like Linux is using PPTT processor node's identical implementation flag [1] to infer whether the whole system or a certain CPU cluster is homogeneous or not [2]. QEMU currently only support building homogeneous system, set the flag to indicate the fact. Build a root node in PPTT for indicates the identical implementation which is needed for a multi-socket system. Update the related PPTT tables as well. Since we'll update the test PPTT table data, upgrade the revision of PPTT we build to revision 3 by handy. [1] ACPI 6.5 Table 5.158: Processor Structure Flags [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/acpi/pptt.c?h=v6.11-rc1#n810 Yicong Yang (5): tests: virt: Allow changes to PPTT test table hw/acpi/aml-build: Set identical implementation flag for PPTT processor nodes hw/acpi/aml-build: Build a root node in the PPTT table hw/acpi/aml-build: Update the revision of PPTT table tests: virt: Update expected ACPI tables for virt test hw/acpi/aml-build.c | 26 ++++++++++++++---- tests/data/acpi/aarch64/virt/PPTT | Bin 76 -> 96 bytes .../data/acpi/aarch64/virt/PPTT.acpihmatvirt | Bin 156 -> 176 bytes tests/data/acpi/aarch64/virt/PPTT.topology | Bin 336 -> 356 bytes 4 files changed, 21 insertions(+), 5 deletions(-)