From patchwork Tue Oct 22 08:36:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Akihiko Odaki X-Patchwork-Id: 13845303 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89E6BD1CDB7 for ; Tue, 22 Oct 2024 08:38:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3AOA-0001Ll-5O; Tue, 22 Oct 2024 04:37:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3ANz-0001L3-Tn for qemu-devel@nongnu.org; Tue, 22 Oct 2024 04:37:04 -0400 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3ANw-0001Qu-Lf for qemu-devel@nongnu.org; Tue, 22 Oct 2024 04:37:03 -0400 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-20c77459558so45834075ad.0 for ; Tue, 22 Oct 2024 01:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1729586218; x=1730191018; darn=nongnu.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=hjrc0Ei5LGGmoOhB4+yPqWrMnDhah6PSOeyqDK/ZVOI=; b=uI43NWZk8XQNFy5MNnbbviWugqdAgoeoswVRDVmrFJhIRMD80kXNamQtuF1zaVb+Ny 2jdBy2LNOz1Wzze542kMkDuvOsBVk1x6o69d+hw3ynVMWomNFJLxsxX3d/1pgKnYd2E4 EaTruU7D3Ey47IdBhnRgaCgt3mj6sCMmJ4pdbDMFDYW+Px4LlfLV1grZGkMhB+4x7i78 Nv5oLN7NKRKTbTMQ4vNmIGXYvQ7B+yo+NhBn6wbTHsDleLgauxmngeJUDTtb+rVhjFl/ gnIfzU0PGuBNRGL0fFgYmMcvjqbmLr7HXzT6whmnrqSCUdWzcxF6HHKzbjqE7tKEuF2j 3APQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729586218; x=1730191018; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hjrc0Ei5LGGmoOhB4+yPqWrMnDhah6PSOeyqDK/ZVOI=; b=Q7gwWB1qGLKZXZ5JWHY/zRVbyRCFxk5I88ZzFMz+UrLBL3lUEOeIVmsVv/1gl3tfTn Ixp/P89K+XDAC6szQLQfzmo1CHM3QwNtJ2AmDC721y0yGxlG44hrpndpmObqoGwKOGJT v5AeZzyOSh9G+T+VFT0n+iTAg5Jcgt/9y9v3hyWuvsvOWPXQjgljU60E8HqtsoQKVRmz H0BYEm/fSsKgS6yHt0kK5iZ/VTcYuviIFZBCyT38QJKbcL3Llw4gG7qqDp8Sw5lpOjJX psQuVCUgkeTJdUIM+VU3gR1GLXg00UU04GEBlQxUMmf3Dr1EczEACDMdR5BXizgpPy0C eOuA== X-Gm-Message-State: AOJu0YxQ5aCZzwCU6wEwV4x0aw+9QtIETpoaNPKnpPr8syjG6pyVh3qE TFo7gpzBZ54oRY9aE49lLFBtVKnIjUNRhoJrJUCZLejemrg2r21aexmqeEbCRp8= X-Google-Smtp-Source: AGHT+IHoJJBifayaRw1kZekeW5/KuIzA8CKJNflnOKGFdKpFl1X+WAGrCECtQp6TOkt7Kj7NagBQow== X-Received: by 2002:a17:90b:3c1:b0:2e2:acd7:1df0 with SMTP id 98e67ed59e1d1-2e5da975f8emr2490856a91.41.1729586218541; Tue, 22 Oct 2024 01:36:58 -0700 (PDT) Received: from localhost ([157.82.202.230]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-2e5ad366d28sm5554446a91.18.2024.10.22.01.36.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Oct 2024 01:36:58 -0700 (PDT) From: Akihiko Odaki Subject: [PATCH v17 00/14] hw/pci: SR-IOV related fixes and improvements Date: Tue, 22 Oct 2024 17:36:37 +0900 Message-Id: <20241022-reuse-v17-0-bd7c133237e4@daynix.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIABVkF2cC/23SS27cMAwG4KsEXtcBSb2ornKPoAs9qMaLzhR2M kgQzN0rTWuPAnUpQR8liv/ntMm6yDZ9f/icVrks23I+1QW6bw9TegmnnzIvuW5MBKQByc+rvG0 ylxCEKCJ6pad69vcqZXm/FXr+Udcvy/Z6Xj9udS/Ydv9WIFD/KlxwhtlE4WSSWKX4KYeP0/L+m M6/plbiQh1D2BlVRjoGCgbIehqY6hntTFXGgC5a9klcGZjumd6ZbsyHDF4FcEUPzPSMd2YqE10 SJvTRBD8w2zE6erOtN9EUiCOkMvbmenY80jXmE+qYojckA+OeHY/kxpisBWIUCwPzd6bQ7MxXZ l0I1oeis1EDQ7g7S+6YN1ToUoDIklX24wiwCwrDMTpsSSmRVYxc/7PEEVIPj3/BlpWsvIKkETG O/4mqh0eL2NJSEx6Czi6X/B/YxYXxnumWF53QxGRFQOwIu8Aw3eEtMTnXAVoQ4jEx2EXGdze2z GRAG3XUxeLXG6/X6x9B4jLA4wMAAA== To: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Michael S. Tsirkin" , Marcel Apfelbaum , Alex Williamson , =?utf-8?q?C=C3=A9dric_Le_Goa?= =?utf-8?q?ter?= , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Eduardo Habkost , Sriram Yagnaraman , Jason Wang , Keith Busch , Klaus Jensen , Markus Armbruster , Matthew Rosato , Eric Farman , Harsh Prateek Bora , Shivaprasad G Bhat Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Akihiko Odaki X-Mailer: b4 0.14-dev-fd6e3 Received-SPF: none client-ip=2607:f8b0:4864:20::62d; envelope-from=akihiko.odaki@daynix.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Supersedes: <20240714-rombar-v2-0-af1504ef55de@daynix.com> ("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto") I submitted a RFC series[1] to add support for SR-IOV emulation to virtio-net-pci. During the development of the series, I fixed some trivial bugs and made improvements that I think are independently useful. This series extracts those fixes and improvements from the RFC series. [1]: https://patchew.org/QEMU/20231210-sriov-v2-0-b959e8a6dfaf@daynix.com/ Signed-off-by: Akihiko Odaki --- Changes in v17: - Added patch "pcie_sriov: Ensure VF addr does not overflow". - Changed not to link VF with sPAPR DRC. - Asserted pci_is_vf() when zpci is not found. (Cédric Le Goater) - Link to v16: https://lore.kernel.org/r/20240913-reuse-v16-0-d016b4b4f616@daynix.com Changes in v16: - Added patch "s390x/pci: Avoid creating zpci for VFs". - Added patch "s390x/pci: Allow plugging SR-IOV devices". - Link to v15: https://lore.kernel.org/r/20240823-reuse-v15-0-eddcb960e289@daynix.com Changes in v15: - Fixed variable shadowing in patch "pcie_sriov: Remove num_vfs from PCIESriovPF" - Link to v14: https://lore.kernel.org/r/20240813-reuse-v14-0-4c15bc6ee0e6@daynix.com Changes in v14: - Dropped patch "pcie_sriov: Ensure VF function number does not overflow" as I found the restriction it imposes is unnecessary. - Link to v13: https://lore.kernel.org/r/20240805-reuse-v13-0-aaeaa4d7dfd2@daynix.com Changes in v13: - Added patch "s390x/pci: Check for multifunction after device realization". I found SR-IOV devices, which are multifunction devices, are not supposed to work at all with s390x on QEMU. - Link to v12: https://lore.kernel.org/r/20240804-reuse-v12-0-d3930c4111b2@daynix.com Changes in v12: - Changed to ignore invalid PCI_SRIOV_NUM_VF writes as done for PCI_SRIOV_CTRL_VFE. - Updated the message for patch "hw/pci: Use -1 as the default value for rombar". (Markus Armbruster) - Link to v11: https://lore.kernel.org/r/20240802-reuse-v11-0-fb83bb8c19fb@daynix.com Changes in v11: - Rebased. - Dropped patch "hw/pci: Convert rom_bar into OnOffAuto". - Added patch "hw/pci: Use -1 as the default value for rombar". - Added for-9.2 to give a testing period for possible breakage with libvirt/s390x. - Link to v10: https://lore.kernel.org/r/20240627-reuse-v10-0-7ca0b8ed3d9f@daynix.com Changes in v10: - Added patch "hw/ppc/spapr_pci: Do not reject VFs created after a PF". - Added patch "hw/ppc/spapr_pci: Do not create DT for disabled PCI device". - Added patch "hw/pci: Convert rom_bar into OnOffAuto". - Dropped patch "hw/pci: Determine if rombar is explicitly enabled". - Dropped patch "hw/qdev: Remove opts member". - Link to v9: https://lore.kernel.org/r/20240315-reuse-v9-0-67aa69af4d53@daynix.com Changes in v9: - Rebased. - Restored '#include "qapi/error.h"' (Michael S. Tsirkin) - Added patch "pcie_sriov: Ensure VF function number does not overflow" to fix abortion with wrong PF addr. - Link to v8: https://lore.kernel.org/r/20240228-reuse-v8-0-282660281e60@daynix.com Changes in v8: - Clarified that "hw/pci: Replace -1 with UINT32_MAX for romsize" is not a bug fix. (Markus Armbruster) - Squashed patch "vfio: Avoid inspecting option QDict for rombar" into "hw/pci: Determine if rombar is explicitly enabled". (Markus Armbruster) - Noted the minor semantics change for patch "hw/pci: Determine if rombar is explicitly enabled". (Markus Armbruster) - Link to v7: https://lore.kernel.org/r/20240224-reuse-v7-0-29c14bcb952e@daynix.com Changes in v7: - Replaced -1 with UINT32_MAX when expressing uint32_t. (Markus Armbruster) - Added patch "hw/pci: Replace -1 with UINT32_MAX for romsize". - Link to v6: https://lore.kernel.org/r/20240220-reuse-v6-0-2e42a28b0cf2@daynix.com Changes in v6: - Fixed migration. - Added patch "pcie_sriov: Do not manually unrealize". - Restored patch "pcie_sriov: Release VFs failed to realize" that was missed in v5. - Link to v5: https://lore.kernel.org/r/20240218-reuse-v5-0-e4fc1c19b5a9@daynix.com Changes in v5: - Added patch "hw/pci: Always call pcie_sriov_pf_reset()". - Added patch "pcie_sriov: Reset SR-IOV extended capability". - Removed a reference to PCI_SRIOV_CTRL_VFE in hw/nvme. (Michael S. Tsirkin) - Noted the impact on the guest of patch "pcie_sriov: Do not reset NumVFs after unregistering VFs". (Michael S. Tsirkin) - Changed to use pcie_sriov_num_vfs(). - Restored pci_set_power() and changed it to call pci_set_enabled() only for PFs with an expalanation. (Michael S. Tsirkin) - Reordered patches. - Link to v4: https://lore.kernel.org/r/20240214-reuse-v4-0-89ad093a07f4@daynix.com Changes in v4: - Reverted the change to pci_rom_bar_explicitly_enabled(). (Michael S. Tsirkin) - Added patch "pcie_sriov: Do not reset NumVFs after unregistering VFs". - Added patch "hw/nvme: Refer to dev->exp.sriov_pf.num_vfs". - Link to v3: https://lore.kernel.org/r/20240212-reuse-v3-0-8017b689ce7f@daynix.com Changes in v3: - Extracted patch "hw/pci: Use -1 as a default value for rombar" from patch "hw/pci: Determine if rombar is explicitly enabled" (Philippe Mathieu-Daudé) - Added an audit result of PCIDevice::rom_bar to the message of patch "hw/pci: Use -1 as a default value for rombar" (Philippe Mathieu-Daudé) - Link to v2: https://lore.kernel.org/r/20240210-reuse-v2-0-24ba2a502692@daynix.com Changes in v2: - Reset after enabling a function so that NVMe VF state gets updated. - Link to v1: https://lore.kernel.org/r/20240203-reuse-v1-0-5be8c5ce6338@daynix.com --- Akihiko Odaki (14): hw/pci: Rename has_power to enabled hw/ppc/spapr_pci: Do not create DT for disabled PCI device hw/ppc/spapr_pci: Do not reject VFs created after a PF s390x/pci: Avoid creating zpci for VFs s390x/pci: Allow plugging SR-IOV devices s390x/pci: Check for multifunction after device realization pcie_sriov: Do not manually unrealize pcie_sriov: Ensure VF addr does not overflow pcie_sriov: Reuse SR-IOV VF device instances pcie_sriov: Release VFs failed to realize pcie_sriov: Remove num_vfs from PCIESriovPF pcie_sriov: Register VFs after migration hw/pci: Use -1 as the default value for rombar hw/qdev: Remove opts member docs/pcie_sriov.txt | 8 ++- include/hw/pci/pci.h | 2 +- include/hw/pci/pci_device.h | 19 +++++- include/hw/pci/pcie_sriov.h | 9 +-- include/hw/qdev-core.h | 4 -- hw/core/qdev.c | 1 - hw/net/igb.c | 10 ++- hw/nvme/ctrl.c | 22 +++--- hw/pci/pci.c | 23 ++++--- hw/pci/pci_host.c | 4 +- hw/pci/pcie_sriov.c | 159 ++++++++++++++++++++++++-------------------- hw/ppc/spapr_pci.c | 18 +++-- hw/s390x/s390-pci-bus.c | 42 +++++++++--- hw/vfio/pci.c | 5 +- system/qdev-monitor.c | 12 ++-- hw/pci/trace-events | 2 +- 16 files changed, 207 insertions(+), 133 deletions(-) --- base-commit: 7e3b6d8063f245d27eecce5aabe624b5785f2a77 change-id: 20240129-reuse-faae22b11934 Best regards,