mbox series

[0/3] trace: Minor cleanups to trace header includes

Message ID 20241108162909.4080314-1-peter.maydell@linaro.org (mailing list archive)
Headers show
Series trace: Minor cleanups to trace header includes | expand

Message

Peter Maydell Nov. 8, 2024, 4:29 p.m. UTC 
This series does some minor cleanups which deal with cases where some
C file is including a "trace/trace-<subdir>.h" file directly. Our
documentation in docs/devel/tracing.rst says that that should
generally not be done; instead there is a trace.h file which indirects
to the generated trace-<subdir>.h header.  The only exception is that
source files in the root directory include trace/trace-root.h.

The three exceptions fixed here are:
 * system/dma-helpers.c defined its trace events in the
   root trace-events file, not the system/trace-events file
 * we forgot to create the indirection trace.h for target/arm/hvf
 * a couple of source files in trace/ include trace-root.h when
   they don't use anything defined in it

thanks
-- PMM

Peter Maydell (3):
  system/dma-helpers.c: Move trace events to system/trace-events
  target/arm/hvf: Add trace.h header
  trace: Don't include trace-root.h in control.c or control-target.c

 target/arm/hvf/trace.h | 1 +
 system/dma-helpers.c   | 2 +-
 target/arm/hvf/hvf.c   | 2 +-
 trace/control-target.c | 1 -
 trace/control.c        | 1 -
 system/trace-events    | 7 +++++++
 trace-events           | 7 -------
 7 files changed, 10 insertions(+), 11 deletions(-)
 create mode 100644 target/arm/hvf/trace.h

Comments

Richard Henderson Nov. 9, 2024, 9:11 p.m. UTC | #1 
On 11/8/24 08:29, Peter Maydell wrote:
> Peter Maydell (3):
>    system/dma-helpers.c: Move trace events to system/trace-events
>    target/arm/hvf: Add trace.h header
>    trace: Don't include trace-root.h in control.c or control-target.c

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~