mbox series

[v3,0/2] chardev/char-mux: tweak mux bitset operations

Message ID 20241129103239.464061-1-r.peniaev@gmail.com (mailing list archive)
Headers show
Series chardev/char-mux: tweak mux bitset operations | expand

Message

Roman Penyaev Nov. 29, 2024, 10:32 a.m. UTC 
Patchset tweaks bitset operations by changing a constant to unsigned
long, introduces a static compile check and simplifies bitset operations.
Also resolves Coverity CID 1563776.

v2..v3:
* Multiply (sizeof(d->mux_bitset) * BITS_PER_BYTE) to get number
  of bits (thanks Paolo Bonzini for noticing that)
* Rebase on latest master

v1..v2:
  * Rebase on latest master, incorporate review tags.

Roman Penyaev (2):
  chardev/char-mux: shift unsigned long to avoid 32-bit overflow
  chardev/char-mux: make boolean bit check instead of find_next_bit()

 chardev/char-mux.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)


Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
Reviewed-by: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com>
Cc: qemu-devel@nongnu.org