From patchwork Tue Jan 7 15:33:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerd Hoffmann X-Patchwork-Id: 13929202 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2817E77197 for ; Tue, 7 Jan 2025 15:38:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVBar-00036X-4s; Tue, 07 Jan 2025 10:34:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVBap-00034y-Hs for qemu-devel@nongnu.org; Tue, 07 Jan 2025 10:34:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVBan-00052Y-EV for qemu-devel@nongnu.org; Tue, 07 Jan 2025 10:34:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736264044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2uymKW/bHlE2fe9kQDzSR6o/hjIGfoQ9uKUEyR74XiY=; b=Jpo4KtH9+gxoT4moV3BBIW58sjRQ9g41j63KksG49gnTIecnVnTEdpWt4eTe1ijDSIjlfD X/x16DrozXkgZgw8xocS9cKCqxPkNB70hQ+wds//Aauf20ISkkT/x0eqPQPBAU1bLgXviE zmJe+QhG1JX7JLlRXOh2Tv0inRYF1hA= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-36-QoCzqRFTOGStFW1nVtIbOg-1; Tue, 07 Jan 2025 10:34:00 -0500 X-MC-Unique: QoCzqRFTOGStFW1nVtIbOg-1 X-Mimecast-MFC-AGG-ID: QoCzqRFTOGStFW1nVtIbOg Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 785A41955DDB; Tue, 7 Jan 2025 15:33:57 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.66]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8D69D1956088; Tue, 7 Jan 2025 15:33:55 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 6918D18000B4; Tue, 07 Jan 2025 16:33:53 +0100 (CET) From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , graf@amazon.com, Paolo Bonzini , Michael Roth , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?= =?utf-8?q?ippe_Mathieu-Daud=C3=A9?= , Thomas Huth , qemu-arm@nongnu.org, Eric Blake , Peter Maydell , Markus Armbruster , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Subject: [PATCH v2 00/21] hw/uefi: add uefi variable service Date: Tue, 7 Jan 2025 16:33:27 +0100 Message-ID: <20250107153353.1144978-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.437, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This patch adds a virtual device to qemu which the uefi firmware can use to store variables. This moves the UEFI variable management from privileged guest code (managing vars in pflash) to the host. Main advantage is that the need to have privilege separation in the guest goes away. On x86 privileged guest code runs in SMM. It's supported by kvm, but not liked much by various stakeholders in cloud space due to the complexity SMM emulation brings. On arm privileged guest code runs in el3 (aka secure world). This is not supported by kvm, which is unlikely to change anytime soon given that even el2 support (nested virt) is being worked on for years and is not yet in mainline. The design idea is to reuse the request serialization protocol edk2 uses for communication between SMM and non-SMM code, so large chunks of the edk2 variable driver stack can be used unmodified. Only the driver which traps into SMM mode must be replaced by a driver which talks to qemu instead. A edk2 test branch can be found here (build with "-D QEMU_VARS=TRUE"). https://github.com/kraxel/edk2/commits/devel/secure-boot-external-vars The uefi-vars device re-implements the privileged edk2 protocols (i.e. the code running in SMM mode). v2 changes: - fully implement authenticated variables. - various cleanups and fixes. enjoy & take care, Gerd Gerd Hoffmann (21): hw/uefi: add include/hw/uefi/var-service-api.h hw/uefi: add include/hw/uefi/var-service-edk2.h hw/uefi: add include/hw/uefi/var-service.h hw/uefi: add var-service-guid.c hw/uefi: add var-service-utils.c hw/uefi: add var-service-vars.c hw/uefi: add var-service-auth.c hw/uefi: add var-service-policy.c hw/uefi: add var-service-core.c hw/uefi: add var-service-pkcs7.c hw/uefi: add var-service-pkcs7-stub.c hw/uefi: add var-service-siglist.c hw/uefi: add var-service-json.c + qapi for NV vars. hw/uefi: add trace-events hw/uefi: add UEFI_VARS to Kconfig hw/uefi: add to meson hw/uefi: add uefi-vars-sysbus device hw/uefi: add uefi-vars-isa device hw/arm: add uefi variable support to virt machine type docs: add uefi variable service documentation hw/uefi: add MAINTAINERS entry include/hw/arm/virt.h | 2 + include/hw/uefi/var-service-api.h | 40 ++ include/hw/uefi/var-service-edk2.h | 227 +++++++++ include/hw/uefi/var-service.h | 186 ++++++++ hw/arm/virt.c | 41 ++ hw/uefi/var-service-auth.c | 361 ++++++++++++++ hw/uefi/var-service-core.c | 237 ++++++++++ hw/uefi/var-service-guid.c | 99 ++++ hw/uefi/var-service-isa.c | 91 ++++ hw/uefi/var-service-json.c | 242 ++++++++++ hw/uefi/var-service-pkcs7-stub.c | 16 + hw/uefi/var-service-pkcs7.c | 436 +++++++++++++++++ hw/uefi/var-service-policy.c | 370 +++++++++++++++ hw/uefi/var-service-siglist.c | 212 +++++++++ hw/uefi/var-service-sysbus.c | 90 ++++ hw/uefi/var-service-utils.c | 241 ++++++++++ hw/uefi/var-service-vars.c | 725 +++++++++++++++++++++++++++++ MAINTAINERS | 6 + docs/devel/index-internals.rst | 1 + docs/devel/uefi-vars.rst | 66 +++ hw/Kconfig | 1 + hw/meson.build | 1 + hw/uefi/Kconfig | 9 + hw/uefi/LIMITATIONS.md | 7 + hw/uefi/meson.build | 24 + hw/uefi/trace-events | 17 + meson.build | 1 + qapi/meson.build | 1 + qapi/qapi-schema.json | 1 + qapi/uefi.json | 45 ++ 30 files changed, 3796 insertions(+) create mode 100644 include/hw/uefi/var-service-api.h create mode 100644 include/hw/uefi/var-service-edk2.h create mode 100644 include/hw/uefi/var-service.h create mode 100644 hw/uefi/var-service-auth.c create mode 100644 hw/uefi/var-service-core.c create mode 100644 hw/uefi/var-service-guid.c create mode 100644 hw/uefi/var-service-isa.c create mode 100644 hw/uefi/var-service-json.c create mode 100644 hw/uefi/var-service-pkcs7-stub.c create mode 100644 hw/uefi/var-service-pkcs7.c create mode 100644 hw/uefi/var-service-policy.c create mode 100644 hw/uefi/var-service-siglist.c create mode 100644 hw/uefi/var-service-sysbus.c create mode 100644 hw/uefi/var-service-utils.c create mode 100644 hw/uefi/var-service-vars.c create mode 100644 docs/devel/uefi-vars.rst create mode 100644 hw/uefi/Kconfig create mode 100644 hw/uefi/LIMITATIONS.md create mode 100644 hw/uefi/meson.build create mode 100644 hw/uefi/trace-events create mode 100644 qapi/uefi.json