[0/2] migration: Reduce migration-test time for non-KVM archs

Message

Fabiano Rosas Jan. 30, 2025, 6:40 p.m. UTC

Hi, continuing the work from the previous[1] series to reduce the time
migration-test takes during make check, here's a couple of patches to
create a smaller set of tests.

The change is that from now on, ./migration-test will only run a
limited set of tests (~12), while the full set (64) requires that the
--full flag is passed on. Only those calling the test manually need to
care about this new flag.

For everyone else, qtest/meson.build will automatically add --full in
case KVM is available for the target architecture. All other
architectures run the small set.

The choice of tests for the small set has been arbitrarily made in
patch 2. I expect that once we close in on a list of tests, new tests
will only be added under the --full flag and the small set will be
kept stable.

An unwritten but maybe obvious rule is that slow or flaky tests should
not be added to the small set and once detected should be moved to the
full set.

More details in patch 1.

Thanks!

CI run: https://gitlab.com/farosas/qemu/-/pipelines/1647478788
1- https://lore.kernel.org/r/[e-mail]

Fabiano Rosas (2):
  tests/qtest/migration: Add --full option
  tests/qtest/migration: Pick smoke tests

 tests/qtest/meson.build                   | 11 +++++++++-
 tests/qtest/migration-test.c              | 25 +++++++++++++++++++++++
 tests/qtest/migration/compression-tests.c | 15 +++++++++++---
 tests/qtest/migration/cpr-tests.c         |  6 ++++++
 tests/qtest/migration/file-tests.c        | 21 +++++++++++++------
 tests/qtest/migration/framework.h         |  1 +
 tests/qtest/migration/misc-tests.c        | 16 ++++++++++++---
 tests/qtest/migration/postcopy-tests.c    | 14 ++++++++++++-
 tests/qtest/migration/precopy-tests.c     | 23 ++++++++++++++-------
 tests/qtest/migration/tls-tests.c         | 14 +++++++++++--
 10 files changed, 123 insertions(+), 23 deletions(-)

Comments

Peter Xu Jan. 30, 2025, 9:16 p.m. UTC | #1

On Thu, Jan 30, 2025 at 03:40:10PM -0300, Fabiano Rosas wrote:
> Hi, continuing the work from the previous[1] series to reduce the time
> migration-test takes during make check, here's a couple of patches to
> create a smaller set of tests.
> 
> The change is that from now on, ./migration-test will only run a
> limited set of tests (~12), while the full set (64) requires that the
> --full flag is passed on. Only those calling the test manually need to
> care about this new flag.
> 
> For everyone else, qtest/meson.build will automatically add --full in
> case KVM is available for the target architecture. All other
> architectures run the small set.
> 
> The choice of tests for the small set has been arbitrarily made in
> patch 2. I expect that once we close in on a list of tests, new tests
> will only be added under the --full flag and the small set will be
> kept stable.
> 
> An unwritten but maybe obvious rule is that slow or flaky tests should
> not be added to the small set and once detected should be moved to the
> full set.
> 
> More details in patch 1.

Looks all good here, thanks!

Reviewed-by: Peter Xu <[e-mail]>