From patchwork Mon Feb 24 23:05:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 13989041 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0537C021BE for ; Mon, 24 Feb 2025 23:07:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tmhXS-0005rQ-CF; Mon, 24 Feb 2025 18:07:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tmhXR-0005rF-Oh for qemu-devel@nongnu.org; Mon, 24 Feb 2025 18:07:01 -0500 Received: from mail-io1-xd33.google.com ([2607:f8b0:4864:20::d33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tmhXN-0007RN-OL for qemu-devel@nongnu.org; Mon, 24 Feb 2025 18:07:01 -0500 Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-854a68f5aeeso100642739f.0 for ; Mon, 24 Feb 2025 15:06:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740438414; x=1741043214; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GMB3uau5/+kFWkDlCkMEF5ozqQcxUKZP6WJbrcIzrkY=; b=QrECNEvjQJAdPSWju/zVBimgk9gkLD55oRwr+oYutCqFLxSQYmVlC7UbdmpjrA9Buu +UgBYpi9Tid62Csir76FF8Rv8CtAi3YwDmZU23eIxOPapfQosofjrVERlIGCZdHE9WEL a+8PoJ1DRhE9H665zzXiqQ1uaCqBGlcegEkiw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740438414; x=1741043214; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GMB3uau5/+kFWkDlCkMEF5ozqQcxUKZP6WJbrcIzrkY=; b=oHTpwKabEXyblEyHl9joC1BLLjVjJKJ//uVovErOVdJ16sSkp/NUVlD3DvttJBX00F geJMg1XNRnPc48Kl7K74cRWBxZCU5373e9EpcF4JqXIcTbl/QM0kxiUAXq1LpCNFxtnh BMQbsGXPJRCWBX0Zm+qnf7jGb0IBLHlG67Qjjv7wFZwBBsnZvTSw7VQljXKc+cq7XwJR /LCJ/8pHkghdltxZ+HvlM5yXEVO2wD5JfZSP6X34hAOSnI3AXNIctJ8ImTN10oCACA4w 98uON9Zx25CEyrnKvz/XnTDmikwHozIfhDjJW29iNGbIDhb/OmlMK53yAQeNMVzXIf3/ uikQ== X-Forwarded-Encrypted: i=1; AJvYcCUuxDHtnwF61YE0jL3cwSECOM3UfS2LNAb9Q8IFPLDuzbXwVSBya5/hmuhE5iHVHmcALZWldiMzTtFr@nongnu.org X-Gm-Message-State: AOJu0YyFeP/5CPBQabQpf+znXyOMH/ocgU9jtCnQUMx2axjzPk74aOHX Y71sdz15FisxGcLxdLXrkY9cCDH/XWgi/uO1oGSK9cDOWe24EqUOXU1rnb10yA== X-Gm-Gg: ASbGnctROr7sCDSNrYJfxg8P8SQ+mcxnW/ei+xxMmxHV9kisdCrIrme7E/3i4ZSqXME SOqrDlSmA+2pnKEOELg0Cp1A4j5EwQRvYwkL+sltS/YMfOTbusUJ+wAcA0AFwx+OBqQyq9HCxRA 8VTQsRP2RNlso9eqzwsjapzwlp/xvgLK377lh+sfc+hh4EICaJy/rLt9+ITfdBoXqtAdiFM3M44 vjTbmBo80u9sdhG3P5tXvKT5dxIafajLLGRN1jzWsSzeScYv8/kDbNQn/vW+uAmhz/aY10Nrxjx o4qGelDggPokabx6YMebyX1Yhc+2K9YuUJw47X66uZkxdMFVI9Zyz9o4RsApgAM= X-Google-Smtp-Source: AGHT+IHpIGWrcnsJO9BFl2zjEsvRK33x7uK8RWiQfnWWiLJVQ1svDrMeNCNCgwnMrUaZmCHSOehEXQ== X-Received: by 2002:a05:6e02:1689:b0:3cf:f8de:7662 with SMTP id e9e14a558f8ab-3d3048a66dcmr15021965ab.18.1740438414107; Mon, 24 Feb 2025 15:06:54 -0800 (PST) Received: from chromium.org (c-73-203-119-151.hsd1.co.comcast.net. [73.203.119.151]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f04752e026sm113941173.107.2025.02.24.15.06.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 15:06:52 -0800 (PST) From: Simon Glass To: U-Boot Mailing List Cc: Bin Meng , Simon Glass , Andrew Goodbody , Andy Shevchenko , Angelo Dureghello , Guillaume La Roque , Heinrich Schuchardt , Jerome Forissier , Julien Masson , Julius Lehmann , Love Kumar , Marek Vasut , Martyn Welch , Mattijs Korpershoek , Maximilian Brune , Moritz Fischer , Nam Cao , Patrick Rudolph , Philip Oberfichtner , Quentin Schulz , Richard Weinberger , Stephen Warren , Stephen Warren , Sughosh Ganu , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Tom Rini , qemu-devel@nongnu.org Subject: [PATCH v3 00/44] x86: Improve operation under QEMU Date: Mon, 24 Feb 2025 16:05:49 -0700 Message-ID: <20250224230640.2665206-1-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::d33; envelope-from=sjg@chromium.org; helo=mail-io1-xd33.google.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org U-Boot can start and boot an OS in both qemu-x86 and qemu-x86_64 but it is not perfect. With both builds, executing the VESA ROM causes an intermittent hang, at least on some AMD CPUs. With qemu-x86_64 kvm cannot be used since the move to long mode (64-bit) is done in a way that works on real hardware but not with QEMU. This means that performance is 4-5x slower than it could be, at least on my CPU. We can work around the first problem by using Bochs, which is anyway a better choice than VESA for QEMU. The second can be addressed by using the same descriptor across the jump to long mode. With an MTRR fix this allows booting into Ubuntu on qemu-x86_64 In v3 some e820 patches are included to make booting reliable and avoid ACPI tables being dropped. Also, several MTTR problems are addressed, to support memory sizes above 4GB reliably. Changes in v3: - Always return true from flag_is_changeable_p() on amd64 - Add new patch with functions to convert between mtrr size and mask - Add new patch to update mtrr command to support 64-bit values - Add new patch to update cpuid_eax et al to work on amd64 - Add new patch to correct msr operation on amd64 - Add new patch to allow adding non-aligned size for MTRR - Support memory sizes above 3GB properly - Add new patch to correct sizing of created disks - Add new patch with a function to dump the e820 table - Add new patch with an API for e820 - Add new patch to use the new e820 API - Add new patch to support BLOBLIST_TABLES properly in QEMU - Add new patch to support a 64-bit ramdisk address - Add new patch to mark struct acpi_rsdp as packed - Add new patch to consider non-bootable partitions - Add new patch to handle running out of labels - Add new patch to support IO UARTs for earlycon and console - Add new patch to correct mapping in FADT - Add new patch to add a checksum to the DMAR table - Add new patch to correct memory leaks in the ACPI test - Add new patch to support checking checksums with ACPI command - Significantly expanded to correct e820 and other issues Changes in v2: - Redo commit message - Add new patch to rename the _D dirty flag - Add new patch to support CPU functions in long mode - Add new patch to set an MTRR for the RAM in QEMU - Add new patch with a helper to send characters - Add new patch to allow tests to be filtered by role - Add more patches to support booting with kvm - Add new patch with a test for booting Ubuntu 24.04 Simon Glass (44): x86: Expand x86_64 early memory x86: qemu: Switch to bochs display x86: qemu: Enable dhrystone x86: qemu: Avoid accessing BSS too early x86: Drop mpspec from the SPL build x86: Add some log categories x86: Drop use of CONFIG_REALMODE_DEBUG x86: Avoid clearing the VESA display x86: Add 64-bit entries to the GDT x86: Use defines for the cache flags x86: spl: Drop duplicate CPU init x86: Drop the message about features missing in 64-bit x86: Include stdbool.h in interrupt header x86: Tidy up the GDT size in start/16.S x86: Disable paging before changing to long mode x86: Use the same GDT when jumping to long mode x86: Use a simple jump into long mode x86: Rename the _D dirty flag x86: Support CPU functions in long mode x86: Add functions to convert between mtrr size and mask x86: Update mtrr command to support 64-bit values x86: Update cpuid_eax et al to work on amd64 x86: Correct msr operation on amd64 x86: Allow adding non-aligned size for MTRR x86: emulation: Set an MTRR for the RAM x86: qemu: Support environment and cat command test/py: Correct sizing of created disks test/py: Add a helper to send characters test/py: Allow tests to be filtered by role x86: e820: Add a function to dump the e820 table x86: Add a new API for e820 x86: qemu: Use the new e820 API x86: emulation: Support BLOBLIST_TABLES properly x86: Support a 64-bit ramdisk address acpi: Mark struct acpi_rsdp as packed boot: Consider non-bootable partitions boot: Handle running out of labels boot: Support IO UARTs for earlycon and console sandbox: acpi: Correct mapping in FADT acpi: Add a checksum to the DMAR table test: acpi: Correct memory leaks acpi: Support checking checksums RFC: test/py: Deal with timeouts test: Add a test for booting Ubuntu 24.04 .gitlab-ci.yml | 5 ++ arch/x86/cpu/cpu.c | 24 +++++++ arch/x86/cpu/i386/call64.S | 35 ++++------ arch/x86/cpu/i386/cpu.c | 41 ++++------- arch/x86/cpu/mtrr.c | 115 ++++++++++++++++++++++++------- arch/x86/cpu/qemu/dram.c | 18 +++++ arch/x86/cpu/qemu/e820.c | 62 +++++++---------- arch/x86/cpu/qemu/qemu.c | 20 ++++-- arch/x86/cpu/start.S | 4 +- arch/x86/cpu/start16.S | 3 +- arch/x86/cpu/x86_64/cpu.c | 5 -- arch/x86/include/asm/bootparam.h | 15 +++- arch/x86/include/asm/cpu.h | 91 ++++++++++-------------- arch/x86/include/asm/e820.h | 95 ++++++++++++++++++++++++- arch/x86/include/asm/interrupt.h | 1 + arch/x86/include/asm/msr.h | 9 ++- arch/x86/include/asm/mtrr.h | 16 +++++ arch/x86/include/asm/processor.h | 5 +- arch/x86/lib/Makefile | 2 + arch/x86/lib/bios.c | 27 +++++--- arch/x86/lib/bios_interrupts.c | 8 +-- arch/x86/lib/e820.c | 70 +++++++++++++++++++ arch/x86/lib/i8259.c | 2 + arch/x86/lib/spl.c | 4 +- arch/x86/lib/tables.c | 9 ++- arch/x86/lib/zimage.c | 34 +++------ boot/bootdev-uclass.c | 7 +- boot/bootflow.c | 7 +- cmd/acpi.c | 59 ++++++++++------ cmd/x86/mtrr.c | 11 ++- configs/qemu-x86_64_defconfig | 18 ++--- configs/qemu-x86_defconfig | 12 ++-- doc/develop/bootstd/overview.rst | 5 +- doc/usage/cmd/acpi.rst | 20 +++++- drivers/misc/qfw_acpi.c | 32 +++++++-- include/acpi/acpi_table.h | 2 +- include/bootflow.h | 2 + include/bootstd.h | 3 + lib/acpi/acpi_table.c | 5 +- test/boot/bootdev.c | 1 + test/boot/bootflow.c | 5 +- test/dm/acpi.c | 59 ++++++++++++++++ test/py/conftest.py | 22 ++++++ test/py/console_base.py | 33 +++++---- test/py/pytest.ini | 1 + test/py/tests/test_distro.py | 53 ++++++++++++++ test/py/tests/test_sleep.py | 1 + test/py/tests/test_ut.py | 17 ++++- 48 files changed, 796 insertions(+), 299 deletions(-) create mode 100644 test/py/tests/test_distro.py