[0/2] hw/audio/hda-codec bug fixes

Message

Volker Rümelin Nov. 5, 2023, 5:23 p.m. UTC

Patch 1/2 fixes a bug that was reported and correctly diagnosed on the
QEMU devel mailing list.
https://lists.nongnu.org/archive/html/qemu-devel/2023-08/msg02539.html
There was another patch to fix this bug, but I had an objection.
https://lists.nongnu.org/archive/html/qemu-devel/2023-08/msg02925.html

Patch 2/2 corrects the sense of hda codec property mixer during
initialization. It was inverted not too long ago.

I guess Gerd is still busy with other projects. Another maintainer
probably will have to take these patches.

Volker Rümelin (2):
  hw/audio/hda-codec: fix multiplication overflow
  hw/audio/hda-codec: reenable the audio mixer

 hw/audio/hda-codec.c | 41 +++++++++++++++++++++++++++--------------
 1 file changed, 27 insertions(+), 14 deletions(-)

Comments

Michael Tokarev Nov. 6, 2023, 7:54 p.m. UTC | #1

05.11.2023 20:23, Volker Rümelin :
> Patch 1/2 fixes a bug that was reported and correctly diagnosed on the
> QEMU devel mailing list.
> https://lists.nongnu.org/archive/html/qemu-devel/2023-08/msg02539.html
> There was another patch to fix this bug, but I had an objection.
> https://lists.nongnu.org/archive/html/qemu-devel/2023-08/msg02925.html
> 
> Patch 2/2 corrects the sense of hda codec property mixer during
> initialization. It was inverted not too long ago.

It looks like -stable material, is it not?

/mjt

Volker Rümelin Nov. 6, 2023, 10:19 p.m. UTC | #2

Am 06.11.23 um 20:54 schrieb Michael Tokarev:
> 05.11.2023 20:23, Volker Rümelin :
>> Patch 1/2 fixes a bug that was reported and correctly diagnosed on the
>> QEMU devel mailing list.
>> https://lists.nongnu.org/archive/html/qemu-devel/2023-08/msg02539.html
>> There was another patch to fix this bug, but I had an objection.
>> https://lists.nongnu.org/archive/html/qemu-devel/2023-08/msg02925.html
>>
>> Patch 2/2 corrects the sense of hda codec property mixer during
>> initialization. It was inverted not too long ago.
>
> It looks like -stable material, is it not?
>

Patch 1/2 ("hw/audio/hda-codec: fix multiplication overflow") is stable
material. Sorry, I forgot to cc qemu-stable.

With best regards,
Volker