[v2,0/3] i.MX: Add the i.MX6UL SOC and a reference board.

Message

Jean-Christophe Dubois July 30, 2018, 3:23 p.m. UTC

This series adds the i.MX6UL SOC from NXP/Freescale and the reference
evaluation board.

This series was tested by booting linux 4.18 (built using imx_v6_v7_defconfig)
on the emulated board (with the appropriate device tree).

Jean-Christophe Dubois (3):
  i.MX6UL: Add i.MX6UL specific CCM device
  i.MX6UL: Add i.MX6UL SOC
  i.MX6UL: Add Freescale i.MX6 UltraLite 14x14 EVK Board

 default-configs/arm-softmmu.mak |   1 +
 hw/arm/Makefile.objs            |   1 +
 hw/arm/fsl-imx6ul.c             | 618 ++++++++++++++++++++++
 hw/arm/mcimx6ul-evk.c           |  85 +++
 hw/misc/Makefile.objs           |   1 +
 hw/misc/imx6ul_ccm.c            | 890 ++++++++++++++++++++++++++++++++
 hw/misc/trace-events            |   7 +
 include/hw/arm/fsl-imx6ul.h     | 339 ++++++++++++
 include/hw/misc/imx6ul_ccm.h    | 226 ++++++++
 9 files changed, 2168 insertions(+)
 create mode 100644 hw/arm/fsl-imx6ul.c
 create mode 100644 hw/arm/mcimx6ul-evk.c
 create mode 100644 hw/misc/imx6ul_ccm.c
 create mode 100644 include/hw/arm/fsl-imx6ul.h
 create mode 100644 include/hw/misc/imx6ul_ccm.h

Comments

[e-mail] July 30, 2018, 6:56 p.m. UTC | #1

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [Qemu-devel] [PATCH v2 0/3] i.MX: Add the i.MX6UL SOC and a reference board.

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   6d9dd5fb9d..7aefc14565  master     -> master
 t [tag update]            patchew/[e-mail] -> patchew/[e-mail]
 * [new tag]               patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
d305c7d6d0 i.MX6UL: Add Freescale i.MX6 UltraLite 14x14 EVK Board
d45a2a8602 i.MX6UL: Add i.MX6UL SOC
07fff3d865 i.MX6UL: Add i.MX6UL specific CCM device

=== OUTPUT BEGIN ===
Checking PATCH 1/3: i.MX6UL: Add i.MX6UL specific CCM device...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 1133 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/3: i.MX6UL: Add i.MX6UL SOC...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

ERROR: suspect code indent for conditional statements (4, 7)
#113: FILE: hw/arm/fsl-imx6ul.c:78:
+    for (i = 0; i < FSL_IMX6UL_NUM_GPIOS; i++) {
+       snprintf(name, NAME_SIZE, "gpio%d", i);

ERROR: suspect code indent for conditional statements (4, 7)
#122: FILE: hw/arm/fsl-imx6ul.c:87:
+    for (i = 0; i < FSL_IMX6UL_NUM_GPTS; i++) {
+       snprintf(name, NAME_SIZE, "gpt%d", i);

ERROR: suspect code indent for conditional statements (4, 7)
#131: FILE: hw/arm/fsl-imx6ul.c:96:
+    for (i = 0; i < FSL_IMX6UL_NUM_EPITS; i++) {
+       snprintf(name, NAME_SIZE, "epit%d", i + 1);

ERROR: suspect code indent for conditional statements (4, 7)
#140: FILE: hw/arm/fsl-imx6ul.c:105:
+    for (i = 0; i < FSL_IMX6UL_NUM_ECSPIS; i++) {
+       snprintf(name, NAME_SIZE, "spi%d", i + 1);

ERROR: suspect code indent for conditional statements (4, 7)
#149: FILE: hw/arm/fsl-imx6ul.c:114:
+    for (i = 0; i < FSL_IMX6UL_NUM_I2CS; i++) {
+       snprintf(name, NAME_SIZE, "i2c%d", i + 1);

ERROR: suspect code indent for conditional statements (4, 7)
#158: FILE: hw/arm/fsl-imx6ul.c:123:
+    for (i = 0; i < FSL_IMX6UL_NUM_UARTS; i++) {
+       snprintf(name, NAME_SIZE, "uart%d", i);

ERROR: suspect code indent for conditional statements (4, 7)
#167: FILE: hw/arm/fsl-imx6ul.c:132:
+    for (i = 0; i < FSL_IMX6UL_NUM_ETHS; i++) {
+       snprintf(name, NAME_SIZE, "eth%d", i);

ERROR: suspect code indent for conditional statements (4, 7)
#176: FILE: hw/arm/fsl-imx6ul.c:141:
+    for (i = 0; i < FSL_IMX6UL_NUM_USDHCS; i++) {
+       snprintf(name, NAME_SIZE, "usdhc%d", i);

ERROR: suspect code indent for conditional statements (4, 7)
#185: FILE: hw/arm/fsl-imx6ul.c:150:
+    for (i = 0; i < FSL_IMX6UL_NUM_WDTS; i++) {
+       snprintf(name, NAME_SIZE, "wdt%d", i);

total: 9 errors, 1 warnings, 968 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/3: i.MX6UL: Add Freescale i.MX6 UltraLite 14x14 EVK Board...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

total: 0 errors, 1 warnings, 90 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [e-mail]