[0/2] block/qcow2: Fix bitmap reopen with 'auto-read-only' file child

Message

Peter Krempa Feb. 28, 2020, 12:44 p.m. UTC

See patch 2/2 for explanation. Also please excuse the lack of tests
caused by my ignorance of not figuring out where to put them.

Peter Krempa (2):
  block: Introduce 'bdrv_reopen_commit_post' step
  block/qcow2: Move bitmap reopen into bdrv_reopen_commit_post

 block.c                   | 9 +++++++++
 block/qcow2.c             | 7 ++++++-
 include/block/block_int.h | 1 +
 3 files changed, 16 insertions(+), 1 deletion(-)

Comments

Kevin Wolf March 3, 2020, 4:13 p.m. UTC | #1

Am 28.02.2020 um 13:44 hat Peter Krempa geschrieben:
> See patch 2/2 for explanation. Also please excuse the lack of tests
> caused by my ignorance of not figuring out where to put them.

Thanks, applied to the block branch.

A test would probably live in test/qemu-iotests/. Test case 245 is
specifically about x-blockdev-reopen, so we could consider putting it
there, or you could just create a new test case.

Kevin