[v5,0/6] colo-compare bugfixes

Message

Lukas Straub May 15, 2020, 11:11 a.m. UTC

Hello Everyone,
Here are fixes for bugs that I found in my tests.

Regards,
Lukas Straub

Version changes:
v5:
 -initialize and use notify_sendco only if notify_dev is set

v4:
 -fix potential deadlock with notify_remote_frame
 -avoid malloc and memcpy in many cases

v3:
 -fix checkpatch.pl error

v2:
 -better wording
 -fix performance-regression in patch 3 "net/colo-compare.c: Fix deadlock in compare_chr_send"
 -add more bugfixes


Lukas Straub (6):
  net/colo-compare.c: Create event_bh with the right AioContext
  chardev/char.c: Use qemu_co_sleep_ns if in coroutine
  net/colo-compare.c: Fix deadlock in compare_chr_send
  net/colo-compare.c: Only hexdump packets if tracing is enabled
  net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active
  net/colo-compare.c: Correct ordering in complete and finalize

 chardev/char.c     |   7 +-
 net/colo-compare.c | 254 ++++++++++++++++++++++++++++++++++-----------
 net/colo-compare.h |   1 +
 net/colo.c         |   7 ++
 net/colo.h         |   1 +
 softmmu/vl.c       |   2 +
 6 files changed, 209 insertions(+), 63 deletions(-)

Comments

Zhang Chen May 18, 2020, 9:29 a.m. UTC | #1

> -----Original Message-----
> From: Lukas Straub <[e-mail]>
> Sent: Friday, May 15, 2020 7:11 PM
> To: qemu-devel <[e-mail]>
> Cc: Zhang, Chen <[e-mail]>; Li Zhijian
> <[e-mail]>; Jason Wang <[e-mail]>; Marc-
> André Lureau <[e-mail]>; Paolo Bonzini
> <[e-mail]>
> Subject: [PATCH v5 0/6] colo-compare bugfixes
> 
> Hello Everyone,
> Here are fixes for bugs that I found in my tests.
> 

I will queue this series after test in my side.

Thanks
Zhang Chen

> Regards,
> Lukas Straub
> 
> Version changes:
> v5:
>  -initialize and use notify_sendco only if notify_dev is set
> 
> v4:
>  -fix potential deadlock with notify_remote_frame  -avoid malloc and
> memcpy in many cases
> 
> v3:
>  -fix checkpatch.pl error
> 
> v2:
>  -better wording
>  -fix performance-regression in patch 3 "net/colo-compare.c: Fix deadlock in
> compare_chr_send"
>  -add more bugfixes
> 
> 
> Lukas Straub (6):
>   net/colo-compare.c: Create event_bh with the right AioContext
>   chardev/char.c: Use qemu_co_sleep_ns if in coroutine
>   net/colo-compare.c: Fix deadlock in compare_chr_send
>   net/colo-compare.c: Only hexdump packets if tracing is enabled
>   net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active
>   net/colo-compare.c: Correct ordering in complete and finalize
> 
>  chardev/char.c     |   7 +-
>  net/colo-compare.c | 254 ++++++++++++++++++++++++++++++++++-------
> ----
>  net/colo-compare.h |   1 +
>  net/colo.c         |   7 ++
>  net/colo.h         |   1 +
>  softmmu/vl.c       |   2 +
>  6 files changed, 209 insertions(+), 63 deletions(-)
> 
> --
> 2.20.1