mbox series

[v3,0/2] qga: Ditch g_get_host_name()

Message ID cover.1592849834.git.mprivozn@redhat.com (mailing list archive)
Headers show
Series qga: Ditch g_get_host_name() | expand

Message

Michal Privoznik June 22, 2020, 6:19 p.m. UTC 
v3 of:

https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg06913.html

diff to v2:
- don't leak @hostname in util/oslib-posix.c:qemu_get_host_name()
- document why we are allocating one byte more than needed
- switch to g_new0() from g_malloc0().

Michal Privoznik (2):
  util: Introduce qemu_get_host_name()
  qga: Use qemu_get_host_name() instead of g_get_host_name()

 include/qemu/osdep.h | 10 ++++++++++
 qga/commands.c       | 17 +++++++++++++----
 util/oslib-posix.c   | 35 +++++++++++++++++++++++++++++++++++
 util/oslib-win32.c   | 13 +++++++++++++
 4 files changed, 71 insertions(+), 4 deletions(-)

Comments

Michal Privoznik July 10, 2020, 9:43 a.m. UTC | #1 
On 6/22/20 8:19 PM, Michal Privoznik wrote:
> v3 of:
> 
> https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg06913.html
> 
> diff to v2:
> - don't leak @hostname in util/oslib-posix.c:qemu_get_host_name()
> - document why we are allocating one byte more than needed
> - switch to g_new0() from g_malloc0().
> 
> Michal Privoznik (2):
>    util: Introduce qemu_get_host_name()
>    qga: Use qemu_get_host_name() instead of g_get_host_name()
> 
>   include/qemu/osdep.h | 10 ++++++++++
>   qga/commands.c       | 17 +++++++++++++----
>   util/oslib-posix.c   | 35 +++++++++++++++++++++++++++++++++++
>   util/oslib-win32.c   | 13 +++++++++++++
>   4 files changed, 71 insertions(+), 4 deletions(-)
> 

Ping? How can I get these merged please?

Michal
Philippe Mathieu-Daudé July 13, 2020, 10:57 a.m. UTC | #2 
Ping^2?

On 7/10/20 11:43 AM, Michal Privoznik wrote:
> On 6/22/20 8:19 PM, Michal Privoznik wrote:
>> v3 of:
>>
>> https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg06913.html
>>
>> diff to v2:
>> - don't leak @hostname in util/oslib-posix.c:qemu_get_host_name()
>> - document why we are allocating one byte more than needed
>> - switch to g_new0() from g_malloc0().
>>
>> Michal Privoznik (2):
>>    util: Introduce qemu_get_host_name()
>>    qga: Use qemu_get_host_name() instead of g_get_host_name()
>>
>>   include/qemu/osdep.h | 10 ++++++++++
>>   qga/commands.c       | 17 +++++++++++++----
>>   util/oslib-posix.c   | 35 +++++++++++++++++++++++++++++++++++
>>   util/oslib-win32.c   | 13 +++++++++++++
>>   4 files changed, 71 insertions(+), 4 deletions(-)
>>
> 
> Ping? How can I get these merged please?
> 
> Michal
> 
>