[v3,0/3] migration: dirty-bitmap: Allow control of bitmap persistence

Message

Peter Krempa Feb. 12, 2021, 5:34 p.m. UTC

See 2/2 for explanation.

Peter Krempa (3):
  migration: dirty-bitmap: Convert alias map inner members to
    BitmapMigrationBitmapAlias
  migration: dirty-bitmap: Allow control of bitmap persistence
  qemu-iotests: 300: Add test case for modifying persistence of bitmap

 migration/block-dirty-bitmap.c | 60 ++++++++++++++++------
 qapi/migration.json            | 19 ++++++-
 tests/qemu-iotests/300         | 91 ++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/300.out     |  4 +-
 4 files changed, 157 insertions(+), 17 deletions(-)

Comments

[e-mail] Feb. 12, 2021, 5:42 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [PATCH v3 0/3] migration: dirty-bitmap: Allow control of bitmap persistence

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
 * [new tag]         patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
497cda7 qemu-iotests: 300: Add test case for modifying persistence of bitmap
a575a6e migration: dirty-bitmap: Allow control of bitmap persistence
51195fa migration: dirty-bitmap: Convert alias map inner members to BitmapMigrationBitmapAlias

=== OUTPUT BEGIN ===
1/3 Checking commit 51195faba445 (migration: dirty-bitmap: Convert alias map inner members to BitmapMigrationBitmapAlias)
ERROR: line over 90 characters
#38: FILE: migration/block-dirty-bitmap.c:269:
+                                            (GDestroyNotify) qapi_free_BitmapMigrationBitmapAlias);

total: 1 errors, 0 warnings, 85 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/3 Checking commit a575a6e16810 (migration: dirty-bitmap: Allow control of bitmap persistence)
3/3 Checking commit 497cda72b44c (qemu-iotests: 300: Add test case for modifying persistence of bitmap)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

Eric Blake Feb. 12, 2021, 7:25 p.m. UTC | #2

On 2/12/21 11:34 AM, Peter Krempa wrote:
> See 2/2 for explanation.
> 
> Peter Krempa (3):
>   migration: dirty-bitmap: Convert alias map inner members to
>     BitmapMigrationBitmapAlias
>   migration: dirty-bitmap: Allow control of bitmap persistence
>   qemu-iotests: 300: Add test case for modifying persistence of bitmap
> 

Queuing this through my dirty-bitmap tree

>  migration/block-dirty-bitmap.c | 60 ++++++++++++++++------
>  qapi/migration.json            | 19 ++++++-
>  tests/qemu-iotests/300         | 91 ++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/300.out     |  4 +-
>  4 files changed, 157 insertions(+), 17 deletions(-)
>