[v4,00/10] ACPI related fixes to comform the spec better

Message

Isaku Yamahata Feb. 16, 2021, 1:04 a.m. UTC

From: Isaku Yamahata <[e-mail]>

Miscellaneous bug fixes related to ACPI to play nice with guest BIOSes/OSes
by conforming to ACPI spec better.

Changes from v3:
- rename compat property name to smm-compat and add it to ICH9-LPC and PIIX4_PM
- MMCFG memory region to use dword memory region when possible
- fix max base address of MMCFG memory region
- add more test cases with smm-compat=on and/or piix4

Changes from v2:
- improved commit message
- introduced compat property x-smm-compat-5
- _CRS for MMCONFIG resource, read MMCONFIG info from qemu, generate resource
  instead of dynamically reading chipset configuration.

Changes from v1:
- fixed style issue with fixes to checkpatch.pl
- fixed make check breakage
- added ACPI table tests
- update comment message to include acpi table diff

Isaku Yamahata (9):
  checkpatch: don't emit warning on newly created acpi data files
  qtest: update tests/qtest/bios-tables-test-allowed-diff.h
  ich9, piix4: add properoty, smm-compat, to keep compatibility of SMM
  acpi/core: always set SCI_EN when SMM isn't supported
  acpi: set fadt.smi_cmd to zero when SMM is not supported
  acpi: add test case for smm unsupported -machine smm=off
  hw/i386: declare ACPI mother board resource for MMCONFIG region
  acpi: add test case for -no-hpet
  qtest/acpi/bios-tables-test: update acpi tables

Sean Christopherson (1):
  i386: acpi: Don't build HPET ACPI entry if HPET is disabled

 hw/acpi/core.c                    |  11 +++-
 hw/acpi/ich9.c                    |   2 +-
 hw/acpi/piix4.c                   |   5 +-
 hw/core/machine.c                 |   5 +-
 hw/i386/acpi-build.c              |  81 ++++++++++++++++++++++--
 hw/isa/lpc_ich9.c                 |   1 +
 hw/isa/vt82c686.c                 |   2 +-
 include/hw/acpi/acpi.h            |   4 +-
 include/hw/acpi/ich9.h            |   1 +
 scripts/checkpatch.pl             |   4 +-
 tests/data/acpi/pc/DSDT.nohpet    | Bin 0 -> 4923 bytes
 tests/data/acpi/pc/FACP.nosmm     | Bin 0 -> 116 bytes
 tests/data/acpi/q35/DSDT          | Bin 7801 -> 7872 bytes
 tests/data/acpi/q35/DSDT.acpihmat | Bin 9126 -> 9197 bytes
 tests/data/acpi/q35/DSDT.bridge   | Bin 7819 -> 7890 bytes
 tests/data/acpi/q35/DSDT.cphp     | Bin 8265 -> 8336 bytes
 tests/data/acpi/q35/DSDT.dimmpxm  | Bin 9455 -> 9526 bytes
 tests/data/acpi/q35/DSDT.ipmibt   | Bin 7876 -> 7947 bytes
 tests/data/acpi/q35/DSDT.memhp    | Bin 9160 -> 9231 bytes
 tests/data/acpi/q35/DSDT.mmio64   | Bin 8932 -> 9003 bytes
 tests/data/acpi/q35/DSDT.nohpet   | Bin 0 -> 7730 bytes
 tests/data/acpi/q35/DSDT.numamem  | Bin 7807 -> 7878 bytes
 tests/data/acpi/q35/DSDT.tis      | Bin 8407 -> 8478 bytes
 tests/data/acpi/q35/FACP.nosmm    | Bin 0 -> 244 bytes
 tests/qtest/bios-tables-test.c    | 100 ++++++++++++++++++++++++++++++
 25 files changed, 203 insertions(+), 13 deletions(-)
 create mode 100644 tests/data/acpi/pc/DSDT.nohpet
 create mode 100644 tests/data/acpi/pc/FACP.nosmm
 create mode 100644 tests/data/acpi/q35/DSDT.nohpet
 create mode 100644 tests/data/acpi/q35/FACP.nosmm