mbox series

[v3,0/3] gdbstub: avoid untimely stop-reply msgs

Message ID cover.1663677789.git.quic_mathbern@quicinc.com (mailing list archive)
Headers show
Series gdbstub: avoid untimely stop-reply msgs | expand

Message

Matheus Tavares Bernardino Sept. 20, 2022, 12:47 p.m. UTC 
This series limits gdbstub to send stop-reply packets only as a reply to
commands that accept them, following the RSP specification.

Changes since v2[1]:

- Replaced char buffer with boolean at struct GDBState.
- Covered other functions that might send stop-reply packets.
- Added test.

Note: I was able to run the added test previously I make sure it passes
after the change, but after rebasing onto master, `make check-tcg` is
giving me the following error (this also happens at the tip of master in
my machine):

	qemu: could not load PC BIOS 'bios-256k.bin'

Perhaps I'm doing something wrong at compilation/testing?

[1]: https://lore.kernel.org/qemu-devel/ba99db564c3aeb1812bdfbc9116849092334482f.1661362557.git.quic_mathbern@quicinc.com/

Matheus Tavares Bernardino (3):
  configure: make sure tcg tests can see HAVE_GDB_BIN
  gdbstub: only send stop-reply packets when allowed to
  gdbstub: add test for untimely stop-reply packets

 configure                                     | 13 ++--
 gdbstub.c                                     | 64 ++++++++++++++-----
 meson.build                                   |  6 +-
 tests/guest-debug/run-test.py                 | 16 +++--
 .../multiarch/system/Makefile.softmmu-target  | 16 ++++-
 5 files changed, 83 insertions(+), 32 deletions(-)