| Message ID | cover.1719690591.git.balaton@eik.bme.hu (mailing list archive) |
|---|---|
| Headers | show |
| Series | Solve vt82c686 qemu_irq leak. | expand |
On Sat, Jun 29, 2024 at 10:01:52PM +0200, BALATON Zoltan wrote: > This is an alternative appriach to solve the qemu_irq leak in > vt82c686. Allowing embedding an irq and init it in place like done > with other objects may allow cleaner fix for similar issues and I also > plan to use this for adding qemu_itq to pegasos2 machine state for > which gpio would not work. > > BALATON Zoltan (2): > hw: Move declaration of IRQState to header and add init function > hw/isa/vt82c686.c: Embed i8259 irq in device state instead of > allocating This looked like a simpler approach to shut up analyzer warnings, so I picked this one. > hw/core/irq.c | 25 +++++++++++-------------- > hw/isa/vt82c686.c | 7 ++++--- > include/hw/irq.h | 18 ++++++++++++++++++ > 3 files changed, 33 insertions(+), 17 deletions(-) > > -- > 2.30.9 > >
On Tue, 10 Sep 2024, Michael S. Tsirkin wrote: > On Sat, Jun 29, 2024 at 10:01:52PM +0200, BALATON Zoltan wrote: >> This is an alternative appriach to solve the qemu_irq leak in >> vt82c686. Allowing embedding an irq and init it in place like done >> with other objects may allow cleaner fix for similar issues and I also >> plan to use this for adding qemu_itq to pegasos2 machine state for >> which gpio would not work. >> >> BALATON Zoltan (2): >> hw: Move declaration of IRQState to header and add init function >> hw/isa/vt82c686.c: Embed i8259 irq in device state instead of >> allocating > > This looked like a simpler approach to shut up analyzer warnings, so I > picked this one. Thanks. Looks like you had some mixup with adding your Signed-off-by though but I did not notice that in the pull request only now that it landed in master. (Just in case this can be corrected somehow in git but otherwise it probably does not matter much.) Regards, BALATON Zoltan
This is an alternative appriach to solve the qemu_irq leak in vt82c686. Allowing embedding an irq and init it in place like done with other objects may allow cleaner fix for similar issues and I also plan to use this for adding qemu_itq to pegasos2 machine state for which gpio would not work. BALATON Zoltan (2): hw: Move declaration of IRQState to header and add init function hw/isa/vt82c686.c: Embed i8259 irq in device state instead of allocating hw/core/irq.c | 25 +++++++++++-------------- hw/isa/vt82c686.c | 7 ++++--- include/hw/irq.h | 18 ++++++++++++++++++ 3 files changed, 33 insertions(+), 17 deletions(-)