From patchwork Sun Jul 25 16:46:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Volker_R=C3=BCmelin?= X-Patchwork-Id: 12398201 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8C15C4338F for ; Sun, 25 Jul 2021 16:48:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 435B760C41 for ; Sun, 25 Jul 2021 16:48:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 435B760C41 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=t-online.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:51166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7hJ4-0001eZ-6Z for qemu-devel@archiver.kernel.org; Sun, 25 Jul 2021 12:48:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7hIJ-0000zl-KC for qemu-devel@nongnu.org; Sun, 25 Jul 2021 12:48:03 -0400 Received: from mailout03.t-online.de ([194.25.134.81]:58856) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7hIH-0002kO-Se for qemu-devel@nongnu.org; Sun, 25 Jul 2021 12:48:03 -0400 Received: from fwd27.aul.t-online.de (fwd27.aul.t-online.de [172.20.26.132]) by mailout03.t-online.de (Postfix) with SMTP id 456FD69FB6; Sun, 25 Jul 2021 18:46:57 +0200 (CEST) Received: from [192.168.211.200] (Gu6OGsZSQhO0a1DzZN-GF6k9xHMzGqITwLymXu-znrQiE49YlZ3E0kO2xD7+ZsGwh8@[79.208.26.7]) by fwd27.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1m7hHE-0UXFj60; Sun, 25 Jul 2021 18:46:56 +0200 From: =?utf-8?q?Volker_R=C3=BCmelin?= To: Gerd Hoffmann Subject: [PATCH v2 0/1] ui/gtk: prevent QEMU lock up Message-ID: Date: Sun, 25 Jul 2021 18:46:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 Content-Language: en-US X-ID: Gu6OGsZSQhO0a1DzZN-GF6k9xHMzGqITwLymXu-znrQiE49YlZ3E0kO2xD7+ZsGwh8 X-TOI-EXPURGATEID: 150726::1627231616-000107BB-5E2E4F49/0/0 CLEAN NORMAL X-TOI-MSGID: d42cf927-4af7-4529-aad1-0574b6ec10b5 Received-SPF: none client-ip=194.25.134.81; envelope-from=vr_qemu@t-online.de; helo=mailout03.t-online.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zack Marvel , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Since commit 8eb13bbbac ("ui/gtk: vte: fix sending multiple characeters") it's very easy to lock up QEMU with the GTK ui. If you configure a guest with a serial device and the guest doesn't listen on this device, QEMU will lock up after entering two characters in the serial console. v2: Gerd suggested to use the chr_accept_input() callback function instead of a write retry timer and to drop patch 2/2. Volker Rümelin (1):   ui/gtk: add a keyboard fifo to the VTE consoles  include/ui/gtk.h |  4 ++++  ui/gtk.c         | 42 +++++++++++++++++++++++++++++++++---------  2 files changed, 37 insertions(+), 9 deletions(-)