diff mbox

[PULL,11/23] channel-file: fix wrong parameter comments

Message ID 046303d38caf2e9919588f87850ac884a48dd567.1494140528.git.mjt@msgid.tls.msk.ru (mailing list archive)
State New, archived
Headers show

Commit Message

Michael Tokarev May 7, 2017, 7:02 a.m. UTC 
From: "sochin.jiang fix wrong parameter comments in channel-file.h" <sochin@aliyun.com>

Signed-off-by: sochin.jiang <sochin@aliyun.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 include/io/channel-file.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eric Blake May 9, 2017, 6:04 p.m. UTC | #1 
On 05/07/2017 02:02 AM, Michael Tokarev wrote:
> From: "sochin.jiang fix wrong parameter comments in channel-file.h" <sochin@aliyun.com>

Do we really want this HUGE email name, or can we get it touched up
before stefanha promotes his staging branch to master?

> 
> Signed-off-by: sochin.jiang <sochin@aliyun.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  include/io/channel-file.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
Stefan Hajnoczi May 9, 2017, 7:47 p.m. UTC | #2 
On Sun, May 07, 2017 at 10:02:14AM +0300, Michael Tokarev wrote:
> From: "sochin.jiang fix wrong parameter comments in channel-file.h" <sochin@aliyun.com>

Hi Michael,
This patch has a corrupted From field.  I do not modify pull requests
myself when merging.  Could you please resend?

Thanks,
Stefan
diff mbox

Patch

diff --git a/include/io/channel-file.h b/include/io/channel-file.h
index d2462c2ed7..79245f1183 100644
--- a/include/io/channel-file.h
+++ b/include/io/channel-file.h
@@ -71,7 +71,7 @@  qio_channel_file_new_fd(int fd);
 
 /**
  * qio_channel_file_new_path:
- * @fd: the file descriptor
+ * @path: the file path
  * @flags: the open flags (O_RDONLY|O_WRONLY|O_RDWR, etc)
  * @mode: the file creation mode if O_WRONLY is set in @flags
  * @errp: pointer to initialized error object