From patchwork Mon Jan 18 15:16:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Auger X-Patchwork-Id: 8055351 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7E11EBEEE5 for ; Mon, 18 Jan 2016 15:19:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BDF74203AC for ; Mon, 18 Jan 2016 15:19:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09E77203A1 for ; Mon, 18 Jan 2016 15:19:05 +0000 (UTC) Received: from localhost ([::1]:60274 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLBaC-00036J-Ce for patchwork-qemu-devel@patchwork.kernel.org; Mon, 18 Jan 2016 10:19:04 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLBYG-00087W-4F for qemu-devel@nongnu.org; Mon, 18 Jan 2016 10:17:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLBYB-0001cu-WE for qemu-devel@nongnu.org; Mon, 18 Jan 2016 10:17:04 -0500 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:34000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLBYB-0001ce-Ka for qemu-devel@nongnu.org; Mon, 18 Jan 2016 10:16:59 -0500 Received: by mail-wm0-x22e.google.com with SMTP id u188so108053963wmu.1 for ; Mon, 18 Jan 2016 07:16:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Q7OwAW9QxQc6J7yF0hoQRibJ3CCPh4GOSZraNe2Y6q0=; b=YPEVQKNIxw9AcdtRGTKUh2RRvB+uY0HpqvYZ6+bQ1CU2ov7D7KWjhIcmRCIViF+QFq PVUezZwCr/nRLUsxxz1fqvAbwd1WNoBDJHtSjvO5GsPySNrLbagjaoxnkoUJ3GbbDEWb /5YjvyPnTJbXdBBwGDXH+VBNIlSY4+Cygflq0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Q7OwAW9QxQc6J7yF0hoQRibJ3CCPh4GOSZraNe2Y6q0=; b=bDkUotL2kIlRdnu26k/z6pZbVwSY/v63p22FKKAxVj+Mnyd/c7NVhZt9xG946G+fOF vKIK50CgXk3Gw6DBCuyDYBD73by3bgzVurwqJUp9xoWLUC1YmWo12hMTKxa/arH1VO6c uOvVr8p/zETRctueTuUGN/uEk3H78Lv+Uz9kU8nLZq8dVPAr5qBERDi361Czf5zUhRZL DFwm2VQsy8SZ01tTMUrg2/+Dld4rW07Vuv60Wldd0b2cZEVHVct84h/u6+1q8uM2qPi/ H/JS3H4ITxYshVbznWkiJepyHXLHw9/5xkGqbt0X6te5rXFCxlCTLihC8iXd8c/2zFEY hDqg== X-Gm-Message-State: ALoCoQlnD89R5Fs1qWbJci8Xmjuvyvp4huP/131eGC2DrkfKLHSsNlssYVf8hzBifJRUp6XKSg/ptIzL8vNDhm2joLYMxby3Wg== X-Received: by 10.194.87.1 with SMTP id t1mr24383827wjz.170.1453130219153; Mon, 18 Jan 2016 07:16:59 -0800 (PST) Received: from new-host-9.home (LMontsouris-657-1-37-90.w80-11.abo.wanadoo.fr. [80.11.198.90]) by smtp.gmail.com with ESMTPSA id o7sm24230067wjf.45.2016.01.18.07.16.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 Jan 2016 07:16:57 -0800 (PST) From: Eric Auger To: eric.auger@st.com, eric.auger@linaro.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, david@gibson.dropbear.id.au, alex.williamson@redhat.com Date: Mon, 18 Jan 2016 15:16:40 +0000 Message-Id: <1453130204-655-5-git-send-email-eric.auger@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1453130204-655-1-git-send-email-eric.auger@linaro.org> References: <1453130204-655-1-git-send-email-eric.auger@linaro.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22e Cc: thomas.lendacky@amd.com, thuth@redhat.com, b.reynal@virtualopensystems.com, patches@linaro.org, crosthwaitepeter@gmail.com, suravee.suthikulpanit@amd.com, pbonzini@redhat.com, alex.bennee@linaro.org, christoffer.dall@linaro.org Subject: [Qemu-devel] [PATCH v5 4/8] device_tree: qemu_fdt_getprop converted to use the error API X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Current qemu_fdt_getprop exits if the property is not found. It is sometimes needed to read an optional property, in which case we do not wish to exit but simply returns a null value. This patch converts qemu_fdt_getprop to accept an Error **, and existing users are converted to pass &error_fatal. This preserves the existing behaviour. Then to use the API with your optional semantic a null parameter can be conveyed. Signed-off-by: Eric Auger Reviewed-by: Peter Crosthwaite --- v4 -> v5: - add Peter's R-b - remove comment about error_fatal v1 -> v2: - add a doc comment in the header file RFC -> v1: - get rid of qemu_fdt_getprop_optional and implement Peter's suggestion that consists in using the error API Signed-off-by: Eric Auger --- device_tree.c | 11 ++++++----- include/sysemu/device_tree.h | 13 ++++++++++++- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/device_tree.c b/device_tree.c index 3c88a37..45fd76d 100644 --- a/device_tree.c +++ b/device_tree.c @@ -333,18 +333,18 @@ int qemu_fdt_setprop_string(void *fdt, const char *node_path, } const void *qemu_fdt_getprop(void *fdt, const char *node_path, - const char *property, int *lenp) + const char *property, int *lenp, Error **errp) { int len; const void *r; + if (!lenp) { lenp = &len; } r = fdt_getprop(fdt, findnode_nofail(fdt, node_path), property, lenp); if (!r) { - error_report("%s: Couldn't get %s/%s: %s", __func__, - node_path, property, fdt_strerror(*lenp)); - exit(1); + error_setg(errp, "%s: Couldn't get %s/%s: %s", __func__, + node_path, property, fdt_strerror(*lenp)); } return r; } @@ -353,7 +353,8 @@ uint32_t qemu_fdt_getprop_cell(void *fdt, const char *node_path, const char *property) { int len; - const uint32_t *p = qemu_fdt_getprop(fdt, node_path, property, &len); + const uint32_t *p = qemu_fdt_getprop(fdt, node_path, property, &len, + &error_fatal); if (len != 4) { error_report("%s: %s/%s not 4 bytes long (not a cell?)", __func__, node_path, property); diff --git a/include/sysemu/device_tree.h b/include/sysemu/device_tree.h index 436b5dd..123beb5 100644 --- a/include/sysemu/device_tree.h +++ b/include/sysemu/device_tree.h @@ -45,8 +45,19 @@ int qemu_fdt_setprop_string(void *fdt, const char *node_path, int qemu_fdt_setprop_phandle(void *fdt, const char *node_path, const char *property, const char *target_node_path); +/** + * qemu_fdt_getprop: retrieve the value of a given property + * @fdt: pointer to the device tree blob + * @node_path: node path + * @property: name of the property to find + * @lenp: fdt error if any or length of the property on success + * @errp: handle to an error object + * + * returns a pointer to the property on success and NULL on failure + */ const void *qemu_fdt_getprop(void *fdt, const char *node_path, - const char *property, int *lenp); + const char *property, int *lenp, + Error **errp); uint32_t qemu_fdt_getprop_cell(void *fdt, const char *node_path, const char *property); uint32_t qemu_fdt_get_phandle(void *fdt, const char *path);