| Message ID | 1454583838-22272-1-git-send-email-pbonzini@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Paolo Bonzini (pbonzini@redhat.com) wrote: > page_cache.c is part of the XBZRLE implementation, move it to the right > directory. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Does that need tests/Makefile updating - I see: tests/test-xbzrle$(EXESUF): tests/test-xbzrle.o migration/xbzrle.o page_cache.o $(test-util-obj-y) I'm OK with moving this, although I didn't when I moved everything else because there's nothing stopping anyone using it outside of migration. Dave > --- > Makefile.objs | 1 - > migration/Makefile.objs | 2 +- > page_cache.c => migration/page_cache.c | 0 > 3 files changed, 1 insertion(+), 2 deletions(-) > rename page_cache.c => migration/page_cache.c (100%) > > diff --git a/Makefile.objs b/Makefile.objs > index 06b95c7..f950b0f 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -51,7 +51,6 @@ common-obj-$(CONFIG_LINUX) += fsdev/ > > common-obj-y += migration/ > common-obj-y += qemu-char.o #aio.o > -common-obj-y += page_cache.o > common-obj-y += qjson.o > > common-obj-$(CONFIG_SPICE) += spice-qemu-char.o > diff --git a/migration/Makefile.objs b/migration/Makefile.objs > index 0cac6d7..e5778de 100644 > --- a/migration/Makefile.objs > +++ b/migration/Makefile.objs > @@ -1,7 +1,7 @@ > common-obj-y += migration.o tcp.o > common-obj-y += vmstate.o > common-obj-y += qemu-file.o qemu-file-buf.o qemu-file-unix.o qemu-file-stdio.o > -common-obj-y += xbzrle.o postcopy-ram.o > +common-obj-y += xbzrle.o page_cache.o postcopy-ram.o > > common-obj-$(CONFIG_RDMA) += rdma.o > common-obj-$(CONFIG_POSIX) += exec.o unix.o fd.o > diff --git a/page_cache.c b/migration/page_cache.c > similarity index 100% > rename from page_cache.c > rename to migration/page_cache.c > -- > 2.5.0 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
On 04/02/2016 16:27, Dr. David Alan Gilbert wrote: > tests/test-xbzrle$(EXESUF): tests/test-xbzrle.o migration/xbzrle.o page_cache.o $(test-util-obj-y) > > I'm OK with moving this, although I didn't when I moved everything > else because there's nothing stopping anyone using it outside of migration. Oops... Paolo
diff --git a/Makefile.objs b/Makefile.objs index 06b95c7..f950b0f 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -51,7 +51,6 @@ common-obj-$(CONFIG_LINUX) += fsdev/ common-obj-y += migration/ common-obj-y += qemu-char.o #aio.o -common-obj-y += page_cache.o common-obj-y += qjson.o common-obj-$(CONFIG_SPICE) += spice-qemu-char.o diff --git a/migration/Makefile.objs b/migration/Makefile.objs index 0cac6d7..e5778de 100644 --- a/migration/Makefile.objs +++ b/migration/Makefile.objs @@ -1,7 +1,7 @@ common-obj-y += migration.o tcp.o common-obj-y += vmstate.o common-obj-y += qemu-file.o qemu-file-buf.o qemu-file-unix.o qemu-file-stdio.o -common-obj-y += xbzrle.o postcopy-ram.o +common-obj-y += xbzrle.o page_cache.o postcopy-ram.o common-obj-$(CONFIG_RDMA) += rdma.o common-obj-$(CONFIG_POSIX) += exec.o unix.o fd.o
page_cache.c is part of the XBZRLE implementation, move it to the right directory. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- Makefile.objs | 1 - migration/Makefile.objs | 2 +- page_cache.c => migration/page_cache.c | 0 3 files changed, 1 insertion(+), 2 deletions(-) rename page_cache.c => migration/page_cache.c (100%) diff --git a/page_cache.c b/migration/page_cache.c similarity index 100% rename from page_cache.c rename to migration/page_cache.c