From patchwork Tue Feb 16 14:57:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 8327601 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 025F8C02AA for ; Tue, 16 Feb 2016 14:58:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6800420259 for ; Tue, 16 Feb 2016 14:58:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F01B20279 for ; Tue, 16 Feb 2016 14:58:05 +0000 (UTC) Received: from localhost ([::1]:46815 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVh4m-000320-RL for patchwork-qemu-devel@patchwork.kernel.org; Tue, 16 Feb 2016 09:58:04 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVh4e-00031p-Py for qemu-devel@nongnu.org; Tue, 16 Feb 2016 09:57:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVh4Y-00074T-SM for qemu-devel@nongnu.org; Tue, 16 Feb 2016 09:57:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVh4Y-00074D-Ma for qemu-devel@nongnu.org; Tue, 16 Feb 2016 09:57:50 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 1E994471 for ; Tue, 16 Feb 2016 14:57:50 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-55.ams2.redhat.com [10.36.116.55]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1GEvlfq031946 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 16 Feb 2016 09:57:49 -0500 Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 64C0F303F81B; Tue, 16 Feb 2016 15:57:47 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Tue, 16 Feb 2016 15:57:47 +0100 Message-Id: <1455634667-10388-1-git-send-email-armbru@redhat.com> In-Reply-To: <1455303747-19776-1-git-send-email-ehabkost@redhat.com> References: <1455303747-19776-1-git-send-email-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: marcel@redhat.com, pbonzini@redhat.com, lersek@redhat.com, ehabkost@redhat.com Subject: [Qemu-devel] [PATCH 5/4] vl: Clean up machine selection in main(). X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We set machine_class to the default first, and update it to the real one later. Any use of machine_class in between is almost certainly wrong. Set it once and for all instead. Signed-off-by: Markus Armbruster Reviewed-by: Laszlo Ersek Reviewed-by: Marcel Apfelbaum --- vl.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index 7918e9f..098728c 100644 --- a/vl.c +++ b/vl.c @@ -2748,8 +2748,9 @@ static const QEMUOption *lookup_opt(int argc, char **argv, return popt; } -static void set_machine_options(MachineClass **machine_class) +static MachineClass *select_machine(MachineClass *dflt) { + MachineClass *machine_class = dflt; const char *optarg; QemuOpts *opts; Location loc; @@ -2761,16 +2762,17 @@ static void set_machine_options(MachineClass **machine_class) optarg = qemu_opt_get(opts, "type"); if (optarg) { - *machine_class = machine_parse(optarg); + machine_class = machine_parse(optarg); } - if (*machine_class == NULL) { + if (!machine_class) { error_report("No machine specified, and there is no default"); error_printf("Use -machine help to list supported machines\n"); exit(1); } loc_pop(&loc); + return machine_class; } static int machine_set_property(void *opaque, @@ -3075,7 +3077,6 @@ int main(int argc, char **argv, char **envp) os_setup_early_signal_handling(); module_call_init(MODULE_INIT_MACHINE); - machine_class = find_default_machine(); cpu_model = NULL; snapshot = 0; cyls = heads = secs = 0; @@ -4066,7 +4067,7 @@ int main(int argc, char **argv, char **envp) replay_configure(icount_opts); - set_machine_options(&machine_class); + machine_class = select_machine(find_default_machine()); set_memory_options(&ram_slots, &maxram_size, machine_class);