| Message ID | 1455895091-7589-3-git-send-email-richard.weiyang@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/19/2016 04:18 PM, Wei Yang wrote: > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is > the more proper on retrieving MSIX entries. > > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> > CC: Cornelia Huck <cornelia.huck@de.ibm.com> > CC: Christian Borntraeger <borntraeger@de.ibm.com> > --- > hw/s390x/s390-pci-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c > index 132588b..9d40039 100644 > --- a/hw/s390x/s390-pci-bus.c > +++ b/hw/s390x/s390-pci-bus.c > @@ -523,7 +523,7 @@ static int s390_pcihost_setup_msix(S390PCIBusDevice *pbdev) > return 0; > } > > - ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_CAP_FLAGS, > + ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_FLAGS, > pci_config_size(pbdev->pdev), sizeof(ctrl)); > table = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_TABLE, > pci_config_size(pbdev->pdev), sizeof(table)); > looks sane. Yi Min, can you ack/nack?
? Mon, 22 Feb 2016 14:15:07 +0100 Christian Borntraeger <borntraeger@de.ibm.com> ??: > On 02/19/2016 04:18 PM, Wei Yang wrote: > > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is > > the more proper on retrieving MSIX entries. > > > > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. > > > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> > > CC: Cornelia Huck <cornelia.huck@de.ibm.com> > > CC: Christian Borntraeger <borntraeger@de.ibm.com> > > --- > > hw/s390x/s390-pci-bus.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c > > index 132588b..9d40039 100644 > > --- a/hw/s390x/s390-pci-bus.c > > +++ b/hw/s390x/s390-pci-bus.c > > @@ -523,7 +523,7 @@ static int s390_pcihost_setup_msix(S390PCIBusDevice *pbdev) > > return 0; > > } > > > > - ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_CAP_FLAGS, > > + ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_FLAGS, > > pci_config_size(pbdev->pdev), sizeof(ctrl)); > > table = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_TABLE, > > pci_config_size(pbdev->pdev), sizeof(table)); > > > > looks sane. > Yi Min, can you ack/nack? > > It looks sane to me. A little change.
On Tue, Feb 23, 2016 at 02:17:11PM +0800, Yi Min Zhao wrote: >? Mon, 22 Feb 2016 14:15:07 +0100 >Christian Borntraeger <borntraeger@de.ibm.com> ??: > >> On 02/19/2016 04:18 PM, Wei Yang wrote: >> > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is >> > the more proper on retrieving MSIX entries. >> > >> > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. >> > >> > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> >> > CC: Cornelia Huck <cornelia.huck@de.ibm.com> >> > CC: Christian Borntraeger <borntraeger@de.ibm.com> >> > --- >> > hw/s390x/s390-pci-bus.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c >> > index 132588b..9d40039 100644 >> > --- a/hw/s390x/s390-pci-bus.c >> > +++ b/hw/s390x/s390-pci-bus.c >> > @@ -523,7 +523,7 @@ static int s390_pcihost_setup_msix(S390PCIBusDevice *pbdev) >> > return 0; >> > } >> > >> > - ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_CAP_FLAGS, >> > + ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_FLAGS, >> > pci_config_size(pbdev->pdev), sizeof(ctrl)); >> > table = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_TABLE, >> > pci_config_size(pbdev->pdev), sizeof(table)); >> > >> >> looks sane. >> Yi Min, can you ack/nack? >> >> > >It looks sane to me. A little change. Thanks Yi Min and Christian. So someone would pick it up?
On Fri, 19 Feb 2016 15:18:11 +0000 Wei Yang <richard.weiyang@gmail.com> wrote: > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is > the more proper on retrieving MSIX entries. > > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> > CC: Cornelia Huck <cornelia.huck@de.ibm.com> > CC: Christian Borntraeger <borntraeger@de.ibm.com> > --- > hw/s390x/s390-pci-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to s390-next.
On Wed, Feb 24, 2016 at 10:40:15AM +0100, Cornelia Huck wrote: >On Fri, 19 Feb 2016 15:18:11 +0000 >Wei Yang <richard.weiyang@gmail.com> wrote: > >> Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is >> the more proper on retrieving MSIX entries. >> >> This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. >> >> Signed-off-by: Wei Yang <richard.weiyang@gmail.com> >> CC: Cornelia Huck <cornelia.huck@de.ibm.com> >> CC: Christian Borntraeger <borntraeger@de.ibm.com> >> --- >> hw/s390x/s390-pci-bus.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > >Thanks, applied to s390-next. Thanks :-)
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 132588b..9d40039 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -523,7 +523,7 @@ static int s390_pcihost_setup_msix(S390PCIBusDevice *pbdev) return 0; } - ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_CAP_FLAGS, + ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_FLAGS, pci_config_size(pbdev->pdev), sizeof(ctrl)); table = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_TABLE, pci_config_size(pbdev->pdev), sizeof(table));
Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is the more proper on retrieving MSIX entries. This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. Signed-off-by: Wei Yang <richard.weiyang@gmail.com> CC: Cornelia Huck <cornelia.huck@de.ibm.com> CC: Christian Borntraeger <borntraeger@de.ibm.com> --- hw/s390x/s390-pci-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)