From patchwork Mon Mar 21 08:03:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastian Koppelmann X-Patchwork-Id: 8630211 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 376529F372 for ; Mon, 21 Mar 2016 08:04:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A05B720272 for ; Mon, 21 Mar 2016 08:04:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F21D420270 for ; Mon, 21 Mar 2016 08:04:46 +0000 (UTC) Received: from localhost ([::1]:56192 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahupS-0000Yn-Dh for patchwork-qemu-devel@patchwork.kernel.org; Mon, 21 Mar 2016 04:04:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahuo1-0006PH-18 for qemu-devel@nongnu.org; Mon, 21 Mar 2016 04:03:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahunw-0005UQ-Pr for qemu-devel@nongnu.org; Mon, 21 Mar 2016 04:03:16 -0400 Received: from mail.uni-paderborn.de ([131.234.142.9]:59595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahunw-0005Tz-KD for qemu-devel@nongnu.org; Mon, 21 Mar 2016 04:03:12 -0400 Received: from pova.uni-paderborn.de ([131.234.189.23] helo=localhost.localdomain) by mail.uni-paderborn.de with esmtp (Exim 4.84_2 zuban) id 1ahunu-0001tV-K9 for qemu-devel@nongnu.org; Mon, 21 Mar 2016 09:03:10 +0100 Received: from mail.uni-paderborn.de by pova with queue id 1075682-2 for qemu-devel@nongnu.org; Mon, 21 Mar 2016 08:03:10 GMT Received: from kbastian@mail.uni-paderborn.de (ip-84-118-248-54.unity-media.net [84.118.248.54]) by mail.uni-paderborn.de with SMTP id 1ahunu-0008Hy-3U; Mon, 21 Mar 2016 08:03:10 GMT (envelope-from kbastian@mail.uni-paderborn.de) X-Envelope-From: Received: from ip-84-118-248-54.unity-media.net ([84.118.248.54] helo=schnipp.localdomain) by mail.uni-paderborn.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_CBC_SHA256:128) (Exim 4.84_2 telepax) id 1ahunu-0008Hy-3U; Mon, 21 Mar 2016 09:03:10 +0100 From: Bastian Koppelmann To: qemu-devel@nongnu.org Date: Mon, 21 Mar 2016 09:03:01 +0100 Message-Id: <1458547383-23102-2-git-send-email-kbastian@mail.uni-paderborn.de> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1458547383-23102-1-git-send-email-kbastian@mail.uni-paderborn.de> References: <1458547383-23102-1-git-send-email-kbastian@mail.uni-paderborn.de> X-PMX-Version: 6.3.0.2556906, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.3.21.75717 X-IMT-Spam-Score: 0.0 () X-IMT-Authenticated-Sender: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 131.234.142.9 Cc: kbastian@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v2 1/3] target-tricore: add missing break in insn decode switch stmt X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP After decoding/translating a RRR_DIVIDE/RRRR_EXTRACT_INSERT type instruction we would simply fall through and would decode/translate another unintended RRR2_MADD/RRRW_EXTRACT_INSERT instruction. Signed-off-by: Bastian Koppelmann --- v1 -> v2: - Add second missing break target-tricore/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index d13e5c8..66f798a 100644 --- a/target-tricore/translate.c +++ b/target-tricore/translate.c @@ -8632,6 +8632,7 @@ static void decode_32Bit_opc(CPUTriCoreState *env, DisasContext *ctx) break; case OPCM_32_RRR_DIVIDE: decode_rrr_divide(env, ctx); + break; /* RRR2 Format */ case OPCM_32_RRR2_MADD: decode_rrr2_madd(env, ctx); @@ -8661,6 +8662,7 @@ static void decode_32Bit_opc(CPUTriCoreState *env, DisasContext *ctx) /* RRRR format */ case OPCM_32_RRRR_EXTRACT_INSERT: decode_rrrr_extract_insert(env, ctx); + break; /* RRRW format */ case OPCM_32_RRRW_EXTRACT_INSERT: decode_rrrw_extract_insert(env, ctx);