From patchwork Thu Mar 31 18:15:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Bligh X-Patchwork-Id: 8715281 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 293799F30C for ; Thu, 31 Mar 2016 18:16:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 873DE202B8 for ; Thu, 31 Mar 2016 18:16:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB27E20295 for ; Thu, 31 Mar 2016 18:16:00 +0000 (UTC) Received: from localhost ([::1]:33744 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alh8S-0006ev-6i for patchwork-qemu-devel@patchwork.kernel.org; Thu, 31 Mar 2016 14:16:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alh86-0006SU-8o for qemu-devel@nongnu.org; Thu, 31 Mar 2016 14:15:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alh82-0004Kc-W1 for qemu-devel@nongnu.org; Thu, 31 Mar 2016 14:15:38 -0400 Received: from mail.avalus.com ([89.16.176.221]:57228) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alh82-0004Jr-LX for qemu-devel@nongnu.org; Thu, 31 Mar 2016 14:15:34 -0400 Received: by mail.avalus.com (Postfix) with ESMTPSA id 503B2C5605D; Thu, 31 Mar 2016 19:15:33 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=alex.org.uk; s=mail; t=1459448133; bh=vDF4zt07QI7dydtq/ol4jhPsMHtqWws7JaZIuCHuFE8=; h=From:To:Cc:Subject:Date; b=m8aryoc8/p+30TjfkzET0Pa8uLIc17uy2deOlR+TFM6xbeTwoqaEFr/NcJt8o4DwI hGvnkrtbIZNfSb1/LxjX6zUOpWjNhMUH9tD6XLmSrzyzLg3+ApLKyOa382PmTr4QcS Nm1UdgG6z22I3O6lZU2MUwCIbYHW3+FVW/hNeqZE= From: Alex Bligh To: Eric Blake , Wouter Verhelst Date: Thu, 31 Mar 2016 19:15:32 +0100 Message-Id: <1459448132-52364-1-git-send-email-alex@alex.org.uk> X-Mailer: git-send-email 1.9.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 89.16.176.221 Cc: "nbd-general@lists.sourceforge.net" , "qemu-devel@nongnu.org" , Alex Bligh Subject: [Qemu-devel] [PATCH 2/2] Correct definition of NBD_CMD_FLAG_FUA X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP NBD_CMD_FLAG_FUA is defined as 1<<0 in the documentation, but 1<<16 in nbd.h. It is not used anywhere within the code. 1<<16 cannot work as the flags word is only 16 bits long. It is doubtful whether anyone is using NBD_CMD_FLAG_FUA at the moment in any case. Signed-off-by: Alex Bligh --- nbd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd.h b/nbd.h index f2a32dd..53b6ca1 100644 --- a/nbd.h +++ b/nbd.h @@ -38,7 +38,7 @@ enum { }; #define NBD_CMD_MASK_COMMAND 0x0000ffff -#define NBD_CMD_FLAG_FUA (1<<16) +#define NBD_CMD_FLAG_FUA (1 << 0) /* values for flags field */ #define NBD_FLAG_HAS_FLAGS (1 << 0) /* Flags are there */