From patchwork Thu Mar 31 23:16:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Bligh X-Patchwork-Id: 8719141 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 56DA9C0553 for ; Thu, 31 Mar 2016 23:16:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AEB8B2034E for ; Thu, 31 Mar 2016 23:16:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 097B2202FF for ; Thu, 31 Mar 2016 23:16:57 +0000 (UTC) Received: from localhost ([::1]:34965 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1allpf-0002ER-AJ for patchwork-qemu-devel@patchwork.kernel.org; Thu, 31 Mar 2016 19:16:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1allpY-0002E9-FL for qemu-devel@nongnu.org; Thu, 31 Mar 2016 19:16:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1allpX-0004Gt-Gb for qemu-devel@nongnu.org; Thu, 31 Mar 2016 19:16:48 -0400 Received: from mail.avalus.com ([2001:41c8:10:1dd::10]:54740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1allpX-0004GA-9s for qemu-devel@nongnu.org; Thu, 31 Mar 2016 19:16:47 -0400 Received: by mail.avalus.com (Postfix) with ESMTPSA id 506F3C5607B; Fri, 1 Apr 2016 00:16:46 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=alex.org.uk; s=mail; t=1459466206; bh=MVijD6Rl1UL1OibpeZv0UrTEEQDcVKVZ0seFwalHvtU=; h=From:To:Cc:Subject:Date; b=icjduJvFyQ5kLyJ1GIBej3lnQ629VdRdAWnTDMMpOnN6+5ToBfQNmZkNR/Be2EQY0 J+MDqXr147VDO9IBZbYi/BvuuTrhwn3Z12ChWpESA4tHlP7cS/YHzeU2Vv97hs6mkP 0DZAJqG9JkOC8ciVwWaUXftozMlmqU9WiTisj23E= From: Alex Bligh To: Eric Blake , Wouter Verhelst Date: Fri, 1 Apr 2016 00:16:48 +0100 Message-Id: <1459466208-56393-1-git-send-email-alex@alex.org.uk> X-Mailer: git-send-email 1.9.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 2001:41c8:10:1dd::10 Cc: "nbd-general@lists.sourceforge.net" , "qemu-devel@nongnu.org" , Alex Bligh Subject: [Qemu-devel] [PATCH] Docs: proto.md: Clarify NUL in export name X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Clarify that * The name is not NUL terminated (not just that the length 'does not include NUL termination' which might be taken to mean there is NUL termination but the length doesn't include it. * The name cannot itself include embedded NUL characters (despite it not being NUL terminated). Signed-off-by: Alex Bligh --- doc/proto.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/proto.md b/doc/proto.md index c1e05c5..7729051 100644 --- a/doc/proto.md +++ b/doc/proto.md @@ -292,7 +292,8 @@ of the newstyle negotiation. haggling, and proceed to the transmission phase. Data: name of the export, free-form UTF-8 text (subject to limitations by server implementation). The length of the name is determined from the - option header, and does NOT include a NUL terminator. If the + option header. The name is not NUL terminated, and may not + contain embedded NUL characters. If the chosen export does not exist or requirements for the chosen export are not met (e.g., the client did not negotiate TLS for an export where the server requires it), the server should close the