From patchwork Fri Apr 1 09:58:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Bligh X-Patchwork-Id: 8722101 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1D8109F7C9 for ; Fri, 1 Apr 2016 09:58:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 80EFF203B8 for ; Fri, 1 Apr 2016 09:58:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B98AB203B5 for ; Fri, 1 Apr 2016 09:58:54 +0000 (UTC) Received: from localhost ([::1]:43081 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alvqw-0000qA-7Z for patchwork-qemu-devel@patchwork.kernel.org; Fri, 01 Apr 2016 05:58:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alvqo-0000q5-Es for qemu-devel@nongnu.org; Fri, 01 Apr 2016 05:58:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alvql-0000bX-9D for qemu-devel@nongnu.org; Fri, 01 Apr 2016 05:58:46 -0400 Received: from mail.avalus.com ([89.16.176.221]:49414) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alvql-0000bS-3H for qemu-devel@nongnu.org; Fri, 01 Apr 2016 05:58:43 -0400 Received: by mail.avalus.com (Postfix) with ESMTPSA id 35C26C5609E; Fri, 1 Apr 2016 10:58:42 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=alex.org.uk; s=mail; t=1459504722; bh=HLQlpQH7VCINUb8dlkLPyoWnwd0JpbKQtu/DATIoPnE=; h=From:To:Cc:Subject:Date; b=ds0eiW/+fqXC7CPMZJXY8FwJ9mGDKphCYxXN0fIq4kx55ibXxSy1+t7nSY4r+pKwx 7CAj0D1PXX5TUzynpmgaLHuIMfxyGLBxrsQrx7kUiS4AbgLIyL45BZxdfkBy0/atHx oU65QXElAKDMuK3rFQpPn57nSZu3LSm4TrLTz4eI= From: Alex Bligh To: Eric Blake , Wouter Verhelst Date: Fri, 1 Apr 2016 10:58:39 +0100 Message-Id: <1459504719-65038-1-git-send-email-alex@alex.org.uk> X-Mailer: git-send-email 1.9.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 89.16.176.221 Cc: "nbd-general@lists.sourceforge.net" , "qemu-devel@nongnu.org" , Alex Bligh Subject: [Qemu-devel] [PATCH] doc/proto.md: Clients MUST not set unknown client flags X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Clients MUST NOT set unknown client flags. Currently this is permitted (but 'SHOULD NOT' be done), with the result that the server MUST drop the connection if it happens. This in effect gives the client an inappropriate way to close the connection. Signed-off-by: Alex Bligh Reviewed-by: Eric Blake --- doc/proto.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/proto.md b/doc/proto.md index 8c83382..6a7ebda 100644 --- a/doc/proto.md +++ b/doc/proto.md @@ -308,7 +308,7 @@ receiving the handshake flags from the server. set `NBD_FLAG_NO_ZEROES`. If set, the server MUST NOT send the 124 bytes of zeroes at the end of the negotiation. -Clients SHOULD NOT set any other flags; the server MUST drop the +Clients MUST NOT set any other flags; the server MUST drop the connection if the client sets an unknown flag, or a flag that does not match something advertised by the server.