From patchwork Mon Apr 4 11:05:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: sergey.fedorov@linaro.org X-Patchwork-Id: 8739991 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2667B9F38C for ; Mon, 4 Apr 2016 11:06:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A5D6120204 for ; Mon, 4 Apr 2016 11:05:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F37992024F for ; Mon, 4 Apr 2016 11:05:57 +0000 (UTC) Received: from localhost ([::1]:57880 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an2KT-0007gL-CI for patchwork-qemu-devel@patchwork.kernel.org; Mon, 04 Apr 2016 07:05:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an2KI-0007dx-As for qemu-devel@nongnu.org; Mon, 04 Apr 2016 07:05:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1an2KD-000140-Az for qemu-devel@nongnu.org; Mon, 04 Apr 2016 07:05:46 -0400 Received: from mail-lf0-x22a.google.com ([2a00:1450:4010:c07::22a]:35204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an2KC-00013t-Kl for qemu-devel@nongnu.org; Mon, 04 Apr 2016 07:05:41 -0400 Received: by mail-lf0-x22a.google.com with SMTP id c126so45675711lfb.2 for ; Mon, 04 Apr 2016 04:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=IofTgNV2+VJIbJy7ZU3DhOGGKH6mrTWUkS2SuCHm7mY=; b=P6q4iBCAYkC6H3C9q3GX1J2dsQMuyxcNpHHEwfBFhCGXnTFyl4970s/KctetkFTxPF 0tBCzL0Iw+t/QCXiMA34wAAEv3DuCbNdCX7v46novHTLrwxBPGS8sfoGnuBQaBaY6nfk 82AL48U0L2NSsj+lzREG7QcFU37ZdwBZ6MyGw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=IofTgNV2+VJIbJy7ZU3DhOGGKH6mrTWUkS2SuCHm7mY=; b=GJwjemQ1zCfi0tCyaBUBEx2Hva+FrUHvBz6kH+T+WkkVxMHRBTMJwfgobWJ6o8qHkW OenaoMCVLA7QDZA1uHFPs7IGcClPEuIt/83k+0C0aKDyTeanDbLlzNxEG1ItHCTTCKHn bsyKOeW1bqUnOw26hforVHIufXE7e0ZmA6vyqIJJeEbxY9a/2/TE7DdQ1+XImO5B+FkG xvKpeWrX/wwFceCE7roPfstH7qldYnjkAnrWKz1BhX2nBAj8G1PHqQolVeGtKvZUTYa9 t+VDMcpDY1fVfVFaSpNKKW+ypEmu1sHj7vqEgS+IKYgiY9gFXHZtWqmgiEQu5VRjwP/1 mKWQ== X-Gm-Message-State: AD7BkJINjZt9E5O2oeO7wDPomJhNbyMlo5PQm9pH6Na3+GuJOunw/zB702D6zhl2SIHe/j/U X-Received: by 10.25.78.80 with SMTP id c77mr2825247lfb.62.1459767939525; Mon, 04 Apr 2016 04:05:39 -0700 (PDT) Received: from localhost.localdomain ([195.91.132.170]) by smtp.gmail.com with ESMTPSA id f134sm4725811lff.34.2016.04.04.04.05.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Apr 2016 04:05:38 -0700 (PDT) From: Sergey Fedorov To: qemu-devel@nongnu.org Date: Mon, 4 Apr 2016 14:05:18 +0300 Message-Id: <1459767918-796-1-git-send-email-sergey.fedorov@linaro.org> X-Mailer: git-send-email 2.7.3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::22a Cc: qemu-trivial@nongnu.org, Sergey Fedorov , Sergey Fedorov , Stefan Weil Subject: [Qemu-devel] [PATCH] tci: Fix build with no '-DNDEBUG' X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sergey Fedorov assert() always evaluates its argument so there's no need to #ifdef the definitions which is only used for assert(). Actually, doing so generates a compilation warning which is treated as an error in QEMU build by default. Let compiler sort out and eliminate unnecessary local variables. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov --- tci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tci.c b/tci.c index 7cbb39ed4b6a..d709e008f3f9 100644 --- a/tci.c +++ b/tci.c @@ -472,10 +472,8 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr) for (;;) { TCGOpcode opc = tb_ptr[0]; -#if !defined(NDEBUG) uint8_t op_size = tb_ptr[1]; uint8_t *old_code_ptr = tb_ptr; -#endif tcg_target_ulong t0; tcg_target_ulong t1; tcg_target_ulong t2;