From patchwork Thu Apr 28 21:33:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: sergey.fedorov@linaro.org X-Patchwork-Id: 8975151 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1AAE49F1C1 for ; Thu, 28 Apr 2016 21:35:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 426B920274 for ; Thu, 28 Apr 2016 21:35:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 399B520219 for ; Thu, 28 Apr 2016 21:35:38 +0000 (UTC) Received: from localhost ([::1]:51070 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avtaz-0005TL-ET for patchwork-qemu-devel@patchwork.kernel.org; Thu, 28 Apr 2016 17:35:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avtZW-0002cE-QA for qemu-devel@nongnu.org; Thu, 28 Apr 2016 17:34:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avtZV-0005Pt-Bd for qemu-devel@nongnu.org; Thu, 28 Apr 2016 17:34:06 -0400 Received: from mail-lf0-x22d.google.com ([2a00:1450:4010:c07::22d]:35867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avtZU-0005Pi-VV for qemu-devel@nongnu.org; Thu, 28 Apr 2016 17:34:05 -0400 Received: by mail-lf0-x22d.google.com with SMTP id u64so98731203lff.3 for ; Thu, 28 Apr 2016 14:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Hgdm7dn+UG2J7WDxuitlBnSt6oRJuplaK2i2EyXiQRs=; b=FXSJy8DxGP0vBymt1D5/vQNhvmiUYVYm/+Q1kYnV3vtxirPxDNY29tTBUNgPvuhKwi /GKk9J3SQ5D5zATs5F9HzEpiPn3yXeNhnQhzbnFRsnr5f6MDrBWO0CdGCEwE4AHhSNPN spdpsXWtcb/tU7OP5NA8Xvx/KNs83BvuqWNgI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Hgdm7dn+UG2J7WDxuitlBnSt6oRJuplaK2i2EyXiQRs=; b=Y9ePxKErtILE9bfSn0/ZYtpuz3mU9kl3Kduvy1+5rwdX5ZURIkpOcSHF9SdfMup77K oPiQZo9KVziu3KwG5Z/14SRQ8jAOlGpTS1Do3y6gUm+AcRw4eA3q057EtoB5UXck2hGp lr7sAy6cSddwNirhusXMl6YDtpmO/a+MQRDdnIdKWokXJk/Y+J7oQA/MZB+pvB3gogVs 4VVER6iNIpe6VeyONE7HJHk9Jjlam53txv5Xc/Tsz2xoGzXH0hht5f6L5TeKgPqiyJZ/ f6uAa5dVsEr21bJ1fYcIjy0OYJrmv9Cmla3e5SabDL3FYjED8rq+gCMUswv/KBwmFBS6 N4pQ== X-Gm-Message-State: AOPr4FXOav6Ow5EopSF06hmENKKMe8MyrvRMfvMUQVU+bL9BP5NxRVHDqUnWbDSnNSJAKqCy X-Received: by 10.112.73.203 with SMTP id n11mr7242788lbv.35.1461879244173; Thu, 28 Apr 2016 14:34:04 -0700 (PDT) Received: from sergey-laptop.Dlink (broadband-46-188-121-115.2com.net. [46.188.121.115]) by smtp.gmail.com with ESMTPSA id m7sm1953148lbr.6.2016.04.28.14.34.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 28 Apr 2016 14:34:03 -0700 (PDT) From: Sergey Fedorov To: qemu-devel@nongnu.org Date: Fri, 29 Apr 2016 00:33:47 +0300 Message-Id: <1461879235-7694-3-git-send-email-sergey.fedorov@linaro.org> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1461879235-7694-1-git-send-email-sergey.fedorov@linaro.org> References: <1461879235-7694-1-git-send-email-sergey.fedorov@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::22d Subject: [Qemu-devel] [PATCH v5 02/10] tcg: Use uintptr_t type for jmp_list_{next|first} fields of TB X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sergey Fedorov , Peter Crosthwaite , Paolo Bonzini , Sergey Fedorov , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sergey Fedorov These fields do not contain pure pointers to a TranslationBlock structure. So uintptr_t is the most appropriate type for them. Also put some asserts to assure that the two least significant bits of the pointer are always zero before assigning it to jmp_list_first. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée --- Changes in v4: * Removed assert from tb_add_jump() * Minor commit message rewording Changes in v2: * Eliminated duplicate dereference of 'ptb' in tb_jmp_remove() include/exec/exec-all.h | 12 +++++++----- translate-all.c | 38 ++++++++++++++++++++------------------ 2 files changed, 27 insertions(+), 23 deletions(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 445d946d84fb..64c2a660bcb2 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-all.h @@ -277,14 +277,16 @@ struct TranslationBlock { * jmp_list_first points to the first TB jumping to this one. * jmp_list_next is used to point to the next TB in a list. * Since each TB can have two jumps, it can participate in two lists. - * The two least significant bits of a pointer are used to choose which - * data field holds a pointer to the next TB: + * jmp_list_first and jmp_list_next are 4-byte aligned pointers to a + * TranslationBlock structure, but the two least significant bits of + * them are used to encode which data field of the pointed TB should + * be used to traverse the list further from that TB: * 0 => jmp_list_next[0], 1 => jmp_list_next[1], 2 => jmp_list_first. * In other words, 0/1 tells which jump is used in the pointed TB, * and 2 means that this is a pointer back to the target TB of this list. */ - struct TranslationBlock *jmp_list_next[2]; - struct TranslationBlock *jmp_list_first; + uintptr_t jmp_list_next[2]; + uintptr_t jmp_list_first; }; #include "qemu/thread.h" @@ -382,7 +384,7 @@ static inline void tb_add_jump(TranslationBlock *tb, int n, /* add in TB jmp circular list */ tb->jmp_list_next[n] = tb_next->jmp_list_first; - tb_next->jmp_list_first = (TranslationBlock *)((uintptr_t)tb | n); + tb_next->jmp_list_first = (uintptr_t)tb | n; } } diff --git a/translate-all.c b/translate-all.c index c6613d13c980..2fb16466c15e 100644 --- a/translate-all.c +++ b/translate-all.c @@ -928,17 +928,17 @@ static inline void tb_page_remove(TranslationBlock **ptb, TranslationBlock *tb) static inline void tb_jmp_remove(TranslationBlock *tb, int n) { - TranslationBlock *tb1, **ptb; + TranslationBlock *tb1; + uintptr_t *ptb, ntb; unsigned int n1; ptb = &tb->jmp_list_next[n]; - tb1 = *ptb; - if (tb1) { + if (*ptb) { /* find tb(n) in circular list */ for (;;) { - tb1 = *ptb; - n1 = (uintptr_t)tb1 & 3; - tb1 = (TranslationBlock *)((uintptr_t)tb1 & ~3); + ntb = *ptb; + n1 = ntb & 3; + tb1 = (TranslationBlock *)(ntb & ~3); if (n1 == n && tb1 == tb) { break; } @@ -951,7 +951,7 @@ static inline void tb_jmp_remove(TranslationBlock *tb, int n) /* now we can suppress tb(n) from the list */ *ptb = tb->jmp_list_next[n]; - tb->jmp_list_next[n] = NULL; + tb->jmp_list_next[n] = (uintptr_t)NULL; } } @@ -970,7 +970,7 @@ void tb_phys_invalidate(TranslationBlock *tb, tb_page_addr_t page_addr) PageDesc *p; unsigned int h, n1; tb_page_addr_t phys_pc; - TranslationBlock *tb1, *tb2; + uintptr_t tb1, tb2; /* remove the TB from the hash list */ phys_pc = tb->page_addr[0] + (tb->pc & ~TARGET_PAGE_MASK); @@ -1006,19 +1006,20 @@ void tb_phys_invalidate(TranslationBlock *tb, tb_page_addr_t page_addr) /* suppress any remaining jumps to this TB */ tb1 = tb->jmp_list_first; for (;;) { - n1 = (uintptr_t)tb1 & 3; + TranslationBlock *tmp_tb; + n1 = tb1 & 3; if (n1 == 2) { break; } - tb1 = (TranslationBlock *)((uintptr_t)tb1 & ~3); - tb2 = tb1->jmp_list_next[n1]; - tb_reset_jump(tb1, n1); - tb1->jmp_list_next[n1] = NULL; + tmp_tb = (TranslationBlock *)(tb1 & ~3); + tb2 = tmp_tb->jmp_list_next[n1]; + tb_reset_jump(tmp_tb, n1); + tmp_tb->jmp_list_next[n1] = (uintptr_t)NULL; tb1 = tb2; } - /* fail safe */ - tb->jmp_list_first = (TranslationBlock *)((uintptr_t)tb | 2); + assert(((uintptr_t)tb & 3) == 0); + tb->jmp_list_first = (uintptr_t)tb | 2; /* fail safe */ tcg_ctx.tb_ctx.tb_phys_invalidate_count++; } @@ -1492,9 +1493,10 @@ static void tb_link_page(TranslationBlock *tb, tb_page_addr_t phys_pc, tb->page_addr[1] = -1; } - tb->jmp_list_first = (TranslationBlock *)((uintptr_t)tb | 2); - tb->jmp_list_next[0] = NULL; - tb->jmp_list_next[1] = NULL; + assert(((uintptr_t)tb & 3) == 0); + tb->jmp_list_first = (uintptr_t)tb | 2; + tb->jmp_list_next[0] = (uintptr_t)NULL; + tb->jmp_list_next[1] = (uintptr_t)NULL; /* init original jump addresses */ if (tb->jmp_reset_offset[0] != TB_JMP_RESET_OFFSET_INVALID) {