From patchwork Thu Apr 28 21:33:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: sergey.fedorov@linaro.org X-Patchwork-Id: 8975161 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A0E279F1C1 for ; Thu, 28 Apr 2016 21:36:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 028A720220 for ; Thu, 28 Apr 2016 21:36:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08C1D20212 for ; Thu, 28 Apr 2016 21:36:44 +0000 (UTC) Received: from localhost ([::1]:51082 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avtc3-0007pu-A1 for patchwork-qemu-devel@patchwork.kernel.org; Thu, 28 Apr 2016 17:36:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avtZb-0002lJ-2L for qemu-devel@nongnu.org; Thu, 28 Apr 2016 17:34:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avtZa-0005SC-0C for qemu-devel@nongnu.org; Thu, 28 Apr 2016 17:34:10 -0400 Received: from mail-lf0-x234.google.com ([2a00:1450:4010:c07::234]:35132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avtZZ-0005Rq-PK for qemu-devel@nongnu.org; Thu, 28 Apr 2016 17:34:09 -0400 Received: by mail-lf0-x234.google.com with SMTP id c126so111929453lfb.2 for ; Thu, 28 Apr 2016 14:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LYqnClR7EjyTTIFlQ2nn5NIIlNtnYjkjEY/SIfh+De4=; b=gEnJ2nAsf7eGoy26G1FwpINZyhGVEVf/YZn92A11Ogbjdl8MagXqjofHBOUI7oQL4K oBYNjvFwrXBR5P7pbxQT5iPhOGc6bSNsLzlcHs0jMuEro80o1gBpa2dsFCduf+mUa0vf UR0v/jnX7DpHAX2QhRcZyRqyAUmGwYy6YNgh8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LYqnClR7EjyTTIFlQ2nn5NIIlNtnYjkjEY/SIfh+De4=; b=ltBnmlAZuj41os/u8gOM3iRTCGDj2KjFekrRSyfEGwTd5VMm3cHkVFrvLViiSDuJOn ZHkD9WQKZi0cShsOOzuNSKfDLrnCUSULNFJ1d7C8RfkEpU4qoJnXBl8KbC6nIDtd3iAV XjtRe/EzUKiWGjsgxVZaaaFrshSykzSOzI1ucKfoCsa8A66CtMKr6lj3JzoBjuWSRTGN A5ZIHh4BR1HsSWjcGT57m3ZpwDFzWy80NvoFoXe6tsZ8OQ0Ow80D/qPOspUt+VNtk7Jv iWKJpg1/afoCRNsj1wmYxDu6/pH0zNpU+bfbGN3o3lprj8m1dbNzQ5ChzsKJzUo/EmoH jS5Q== X-Gm-Message-State: AOPr4FXz0Tdzx1FKWQjVS6B1yJFb8Q8QSqhMPOdutxcMmGsUTMv7D4B71S2uJKYjqTxveL7Z X-Received: by 10.112.167.3 with SMTP id zk3mr7215862lbb.116.1461879249099; Thu, 28 Apr 2016 14:34:09 -0700 (PDT) Received: from sergey-laptop.Dlink (broadband-46-188-121-115.2com.net. [46.188.121.115]) by smtp.gmail.com with ESMTPSA id m7sm1953148lbr.6.2016.04.28.14.34.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 28 Apr 2016 14:34:07 -0700 (PDT) From: Sergey Fedorov To: qemu-devel@nongnu.org Date: Fri, 29 Apr 2016 00:33:51 +0300 Message-Id: <1461879235-7694-7-git-send-email-sergey.fedorov@linaro.org> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1461879235-7694-1-git-send-email-sergey.fedorov@linaro.org> References: <1461879235-7694-1-git-send-email-sergey.fedorov@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::234 Subject: [Qemu-devel] [PATCH v5 06/10] tcg: Rename tb_jmp_remove() to tb_remove_from_jmp_list() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sergey Fedorov , Peter Crosthwaite , Paolo Bonzini , Sergey Fedorov , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sergey Fedorov tb_jmp_remove() was only used to remove the TB from a list of all TBs jumping to the same TB which is n-th jump destination of the given TB. Put a comment briefly describing the function behavior and rename it to better reflect its purpose. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée --- translate-all.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/translate-all.c b/translate-all.c index 1dc1a73c1d55..5e057baaa346 100644 --- a/translate-all.c +++ b/translate-all.c @@ -924,7 +924,8 @@ static inline void tb_page_remove(TranslationBlock **ptb, TranslationBlock *tb) } } -static inline void tb_jmp_remove(TranslationBlock *tb, int n) +/* remove the TB from a list of TBs jumping to the n-th jump target of the TB */ +static inline void tb_remove_from_jmp_list(TranslationBlock *tb, int n) { TranslationBlock *tb1; uintptr_t *ptb, ntb; @@ -998,8 +999,8 @@ void tb_phys_invalidate(TranslationBlock *tb, tb_page_addr_t page_addr) } /* suppress this TB from the two jump lists */ - tb_jmp_remove(tb, 0); - tb_jmp_remove(tb, 1); + tb_remove_from_jmp_list(tb, 0); + tb_remove_from_jmp_list(tb, 1); /* suppress any remaining jumps to this TB */ tb1 = tb->jmp_list_first;