From patchwork Mon May 2 12:33:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Mammedov X-Patchwork-Id: 8993641 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 151959F39D for ; Mon, 2 May 2016 16:06:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 046932024D for ; Mon, 2 May 2016 16:06:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63ACC20222 for ; Mon, 2 May 2016 16:06:33 +0000 (UTC) Received: from localhost ([::1]:36504 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axDLa-0002sF-Ji for patchwork-qemu-devel@patchwork.kernel.org; Mon, 02 May 2016 08:53:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axD46-00073A-2g for qemu-devel@nongnu.org; Mon, 02 May 2016 08:35:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axD3l-0008WB-7t for qemu-devel@nongnu.org; Mon, 02 May 2016 08:35:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axD3l-0008SX-3k for qemu-devel@nongnu.org; Mon, 02 May 2016 08:34:45 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 086CA8111B for ; Mon, 2 May 2016 12:34:34 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.34.112.60]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u42CXqcA000450; Mon, 2 May 2016 08:34:32 -0400 From: Igor Mammedov To: qemu-devel@nongnu.org Date: Mon, 2 May 2016 14:33:32 +0200 Message-Id: <1462192431-146342-24-git-send-email-imammedo@redhat.com> In-Reply-To: <1462192431-146342-1-git-send-email-imammedo@redhat.com> References: <1462192431-146342-1-git-send-email-imammedo@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 23/42] tests: pc-cpu-test: turn on cpu-hotplug explicily X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drjones@redhat.com, ehabkost@redhat.com, mst@redhat.com, armbru@redhat.com, marcel@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Machine types before 2.7 have legacy CPU hotplug enabled by defaut to not regress existing setups where it's always enabled. But since 2.7 CPU hotplug is disabled y default and requires explicit enabling using 'cpu-hotplug' parameter in '-machine' option. So turn it on for cpu-hotplug testcase to allow it test 2.7 and later machine types. Fixes following failure: /x86_64/cpu/pc-q35-2.7/add/1x3x2&maxcpus=12: ** ERROR:tests/pc-cpu-test.c:44:test_pc_with_cpu_add: assertion failed: (!qdict_haskey(response, "error")) Signed-off-by: Igor Mammedov --- tests/pc-cpu-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/pc-cpu-test.c b/tests/pc-cpu-test.c index 6b34ca5..5c9fd1e 100644 --- a/tests/pc-cpu-test.c +++ b/tests/pc-cpu-test.c @@ -31,7 +31,7 @@ static void test_pc_with_cpu_add(gconstpointer data) QDict *response; unsigned int i; - args = g_strdup_printf("-machine %s -cpu %s " + args = g_strdup_printf("-machine %s,cpu-hotplug=on -cpu %s " "-smp sockets=%u,cores=%u,threads=%u,maxcpus=%u", s->machine, s->cpu_model, s->sockets, s->cores, s->threads, s->maxcpus);