[18/52] target-m68k: Some fixes to SR and flags management

Commit Message

Laurent Vivier May 4, 2016, 8:11 p.m. UTC

From: Richard Henderson <[e-mail]>

Signed-off-by: Richard Henderson <[e-mail]>
Signed-off-by: Laurent Vivier <[e-mail]>
---
 target-m68k/cpu.h       |  3 ++-
 target-m68k/helper.c    | 17 +++++++++++++++--
 target-m68k/op_helper.c |  5 +++--
 target-m68k/translate.c |  2 +-
 4 files changed, 21 insertions(+), 6 deletions(-)

Comments

Richard Henderson May 6, 2016, 4:49 p.m. UTC | #1

On 05/04/2016 10:11 AM, Laurent Vivier wrote:
> -uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op)
> +static uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op)
>  {
>      int flags;
>      uint32_t src;
> @@ -271,6 +271,18 @@ set_x:
>      return flags;
>  }
>
> +uint32_t cpu_m68k_get_ccr(CPUM68KState *env)
> +{
> +    return cpu_m68k_flush_flags(env, env->cc_op) | env->cc_x * CCF_X;
> +}

This probably ought to get squished into the previous, to avoid thrashing.


r~

Patch

diff --git a/target-m68k/cpu.h b/target-m68k/cpu.h
index b2d9f3a..8347d04 100644
--- a/target-m68k/cpu.h
+++ b/target-m68k/cpu.h
@@ -129,7 +129,8 @@  int cpu_m68k_exec(CPUState *cpu);
    is returned if the signal was handled by the virtual CPU.  */
 int cpu_m68k_signal_handler(int host_signum, void *pinfo,
                            void *puc);
-uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op);
+uint32_t cpu_m68k_get_ccr(CPUM68KState *env);
+void cpu_m68k_set_ccr(CPUM68KState *env, uint32_t);
 
 typedef enum {
     CC_OP_DYNAMIC, /* Use env->cc_op  */
diff --git a/target-m68k/helper.c b/target-m68k/helper.c
index e9ec8bc..ffed180 100644
--- a/target-m68k/helper.c
+++ b/target-m68k/helper.c
@@ -131,7 +131,7 @@  void m68k_cpu_init_gdb(M68kCPU *cpu)
     /* TODO: Add [E]MAC registers.  */
 }
 
-uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op)
+static uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op)
 {
     int flags;
     uint32_t src;
@@ -271,6 +271,18 @@  set_x:
     return flags;
 }
 
+uint32_t cpu_m68k_get_ccr(CPUM68KState *env)
+{
+    return cpu_m68k_flush_flags(env, env->cc_op) | env->cc_x * CCF_X;
+}
+
+void cpu_m68k_set_ccr(CPUM68KState *env, uint32_t val)
+{
+    env->cc_op = CC_OP_FLAGS;
+    env->cc_dest = val & 0xf;
+    env->cc_x = (val & CCF_X ? 1 : 0);
+}
+
 void HELPER(movec)(CPUM68KState *env, uint32_t reg, uint32_t val)
 {
     M68kCPU *cpu = m68k_env_get_cpu(env);
@@ -465,7 +477,8 @@  uint32_t HELPER(addx_cc)(CPUM68KState *env, uint32_t op1, uint32_t op2)
 
 void HELPER(set_sr)(CPUM68KState *env, uint32_t val)
 {
-    env->sr = val & 0xffff;
+    env->sr = val & 0xffe0;
+    cpu_m68k_set_ccr(env, val);
     m68k_switch_sp(env);
 }
 
diff --git a/target-m68k/op_helper.c b/target-m68k/op_helper.c
index 17d0a11..9262946 100644
--- a/target-m68k/op_helper.c
+++ b/target-m68k/op_helper.c
@@ -62,9 +62,9 @@  static void do_rte(CPUM68KState *env)
     fmt = cpu_ldl_kernel(env, sp);
     env->pc = cpu_ldl_kernel(env, sp + 4);
     sp |= (fmt >> 28) & 3;
-    env->sr = fmt & 0xffff;
     env->aregs[7] = sp + 8;
-    m68k_switch_sp(env);
+
+    helper_set_sr(env, fmt);
 }
 
 static void do_interrupt_all(CPUM68KState *env, int is_hw)
@@ -111,6 +111,7 @@  static void do_interrupt_all(CPUM68KState *env, int is_hw)
     fmt |= 0x40000000;
     fmt |= vector << 16;
     fmt |= env->sr;
+    fmt |= cpu_m68k_get_ccr(env);
 
     env->sr |= SR_S;
     if (is_hw) {
diff --git a/target-m68k/translate.c b/target-m68k/translate.c
index a116c17..ddc3100 100644
--- a/target-m68k/translate.c
+++ b/target-m68k/translate.c
@@ -3141,7 +3141,7 @@  void m68k_cpu_dump_state(CPUState *cs, FILE *f, fprintf_function cpu_fprintf,
                      i, u.l.upper, u.l.lower, *(double *)&u.d);
       }
     cpu_fprintf (f, "PC = %08x   ", env->pc);
-    sr = env->sr | cpu_m68k_flush_flags(env, env->cc_op) | env->cc_x * CCF_X;
+    sr = env->sr | cpu_m68k_get_ccr(env);
     cpu_fprintf (f, "SR = %04x %c%c%c%c%c ", sr, (sr & CCF_X) ? 'X' : '-',
                  (sr & CCF_N) ? 'N' : '-', (sr & CCF_Z) ? 'Z' : '-',
                  (sr & CCF_V) ? 'V' : '-', (sr & CCF_C) ? 'C' : '-');