| Message ID | 1468550849-22172-2-git-send-email-liang.z.li@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Liang Li (liang.z.li@intel.com) wrote: > Since there in wrapper around madvise(), the virtio-balloon > code is able to work without the precompiled directive, the > directive can be removed. > > Signed-off-by: Liang Li <liang.z.li@intel.com> > Suggested-by: Thomas Huth <thuth@redhat.com> This one could be posted separately. Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > hw/virtio/virtio-balloon.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c > index 1a22e6d..62931b3 100644 > --- a/hw/virtio/virtio-balloon.c > +++ b/hw/virtio/virtio-balloon.c > @@ -34,13 +34,11 @@ > > static void balloon_page(void *addr, int deflate) > { > -#if defined(__linux__) > if (!qemu_balloon_is_inhibited() && (!kvm_enabled() || > kvm_has_sync_mmu())) { > qemu_madvise(addr, BALLOON_PAGE_SIZE, > deflate ? QEMU_MADV_WILLNEED : QEMU_MADV_DONTNEED); > } > -#endif > } > > static const char *balloon_stat_names[] = { > -- > 1.9.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> * Liang Li (liang.z.li@intel.com) wrote: > > Since there in wrapper around madvise(), the virtio-balloon code is > > able to work without the precompiled directive, the directive can be > > removed. > > > > Signed-off-by: Liang Li <liang.z.li@intel.com> > > Suggested-by: Thomas Huth <thuth@redhat.com> > > This one could be posted separately. > > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > I will send a separate one. Thanks! David. Liang
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 1a22e6d..62931b3 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virtio/virtio-balloon.c @@ -34,13 +34,11 @@ static void balloon_page(void *addr, int deflate) { -#if defined(__linux__) if (!qemu_balloon_is_inhibited() && (!kvm_enabled() || kvm_has_sync_mmu())) { qemu_madvise(addr, BALLOON_PAGE_SIZE, deflate ? QEMU_MADV_WILLNEED : QEMU_MADV_DONTNEED); } -#endif } static const char *balloon_stat_names[] = {
Since there in wrapper around madvise(), the virtio-balloon code is able to work without the precompiled directive, the directive can be removed. Signed-off-by: Liang Li <liang.z.li@intel.com> Suggested-by: Thomas Huth <thuth@redhat.com> --- hw/virtio/virtio-balloon.c | 2 -- 1 file changed, 2 deletions(-)