From patchwork Thu Sep 15 06:14:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dmitry Fleytman X-Patchwork-Id: 9332835 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7A78A6077F for ; Thu, 15 Sep 2016 06:16:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6C7502929C for ; Thu, 15 Sep 2016 06:16:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 618622929F; Thu, 15 Sep 2016 06:16:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 100DF2929C for ; Thu, 15 Sep 2016 06:16:54 +0000 (UTC) Received: from localhost ([::1]:60062 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkPyf-0003n1-4G for patchwork-qemu-devel@patchwork.kernel.org; Thu, 15 Sep 2016 02:16:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkPy0-0003lJ-Ok for qemu-devel@nongnu.org; Thu, 15 Sep 2016 02:16:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkPxz-0001CU-O4 for qemu-devel@nongnu.org; Thu, 15 Sep 2016 02:16:12 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:32874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkPxz-00017x-IB for qemu-devel@nongnu.org; Thu, 15 Sep 2016 02:16:11 -0400 Received: by mail-wm0-f66.google.com with SMTP id b187so5452393wme.0 for ; Wed, 14 Sep 2016 23:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5MySlGOFEo/0ZQaBw7l5xqMDmJcpj2rPMST2pSXeY64=; b=i1+PDtlDzkMvN+g0JCB76re7UYgWOZzm9lJdxoscEdzE4sVTn/18h86F2fsxY/9gZF 1xyH7VJI9tJ8LouebAsAsgRUb6UzNPmRAYRo9ASh0wvSBYL7oRvYrjhv21Xc/Lvsigv4 M0f5VWS9oikX76OBzc8/g91V4mCv0Vcdxn3SxIfA4hJlFCF7GjAUCthB/M6U8pZoMdKf 8felBZDBDZUfgCNX//Jr+1ub49WWcmUV69Rthns+HCQPJ7vxdDXuuEMj50IGm0Zkok+K rKJnjlIgdgmAQr9vgicvZfOj4XSl9YLFVD6pa+NiCkv+w30tzRRh3S67KPfSncGhyIEX dFwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5MySlGOFEo/0ZQaBw7l5xqMDmJcpj2rPMST2pSXeY64=; b=NCgh3g3lHvSJd8icArE2iAaj9wAxOnsfvMmzNjgQ+q9TS5fVTc31qYOx0ZBmEF3bLN QgSVcMrY9MtJsgMDgyUjwioBEp4NlTET/SxPuEi3drX5VaEQQCki9tscMHgSPGD2L382 PRdZuAAa7VMVXbKLFMTi4/i3ot5StJHqsPsffhClcYQeXWyyjTF+q6e++xawo+iLG0Xu PtISh8HZtoYqCI834hDglHosnL7Z5H0AkmTvW00U7uKl2ZmpfH3ATZe/eCtarJ+utOh9 JMHNX517zhtzYL9zH/CwPIiutG5gQx+gIS+zf+4YF0UJORdwXHWvBs/cfjMzLSWy4MxH DY9w== X-Gm-Message-State: AE9vXwOdyoiGdomvK/gQTZ39wyPiBKSaTrGeZZQjuWzImJHGtN/ulGzNyu3puAqjCex/aw== X-Received: by 10.28.66.6 with SMTP id p6mr1141925wma.59.1473920089665; Wed, 14 Sep 2016 23:14:49 -0700 (PDT) Received: from bark.daynix ([141.226.163.133]) by smtp.gmail.com with ESMTPSA id jd4sm1732011wjb.6.2016.09.14.23.14.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Sep 2016 23:14:49 -0700 (PDT) From: Dmitry Fleytman To: qemu-devel@nongnu.org Date: Thu, 15 Sep 2016 09:14:27 +0300 Message-Id: <1473920070-21938-5-git-send-email-dmitry@daynix.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1473920070-21938-1-git-send-email-dmitry@daynix.com> References: <1473920070-21938-1-git-send-email-dmitry@daynix.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 74.125.82.66 Subject: [Qemu-devel] [PATCH 4/7] e1000e: Fix PBACLR implementation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Vugenfirer , Jason Wang , Shmulik Ladkani Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes incorrect check for interrypt type being used. PBSCLR register is valid for MSI-X only. See spec. 10.2.3.13 MSI—X PBA Clear Signed-off-by: Dmitry Fleytman --- hw/net/e1000e_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 22765cb..c38ed10 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -2347,7 +2347,7 @@ e1000e_set_pbaclr(E1000ECore *core, int index, uint32_t val) core->mac[PBACLR] = val & E1000_PBACLR_VALID_MASK; - if (msix_enabled(core->owner)) { + if (!msix_enabled(core->owner)) { return; }