From patchwork Thu Sep 15 06:14:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Fleytman X-Patchwork-Id: 9332841 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A2BF16077A for ; Thu, 15 Sep 2016 06:21:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 94DC929293 for ; Thu, 15 Sep 2016 06:21:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 89C342929D; Thu, 15 Sep 2016 06:21:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3957E29293 for ; Thu, 15 Sep 2016 06:21:39 +0000 (UTC) Received: from localhost ([::1]:60090 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkQ3G-0007ff-DA for patchwork-qemu-devel@patchwork.kernel.org; Thu, 15 Sep 2016 02:21:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkPy3-0003n2-7m for qemu-devel@nongnu.org; Thu, 15 Sep 2016 02:16:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkPy2-0001DN-9z for qemu-devel@nongnu.org; Thu, 15 Sep 2016 02:16:15 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkPy2-00018M-4N for qemu-devel@nongnu.org; Thu, 15 Sep 2016 02:16:14 -0400 Received: by mail-wm0-f66.google.com with SMTP id 133so3447343wmq.2 for ; Wed, 14 Sep 2016 23:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=426q6dXd2M/JiDkgmxKBX5yVRM8+Nymi/fGSYPpkhFs=; b=JIfu/LwurYh8bF2JbG3NHO/zXgJe8m0NHNuxczsbjdyZNMcLumjHQJl4CPZUasLuWh 2+6KjQ3CupDTPsbVWlkf0FVt69kWvlnx+buGnvCP9zD7IdPQ4DGr86PyNf9Fqh+zoJvu GoR+QUmNYA0NTRzSdjT4PjOShojD2JfzL5+dxxcUf4jrUTcTx1w9PdUXwHbOcpovE6am XdWTLfeXZfnJtaaNfbweXr2RPsPZVruC7NBzwo2hI1wwACJkeSw8FkOMKzhmipHNYjZe DM6dfE1FlPfbwJct/LSUXu93LASp3PsVtgZQS3PQMOz3n9Pnr9tWDBAjzuH9d3Oyu+J2 5fMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=426q6dXd2M/JiDkgmxKBX5yVRM8+Nymi/fGSYPpkhFs=; b=AgS51YarA2EvdYX5/qOCXrNhTqNwLt3tquMe24IEpCOR10Aw5mpHYul9yI/jAKJZsz pn0M+StYPo7dvv/VZKtKBWAsBLW8E829xubBLcLXiMDGUpkRkHwicaDRrS4hhjPSZ7Fy v5BDAMoVojCX13F/Ti6NdV7RN4HQf5J3G5raT+zki5B1ZGxIu1dcICCCoHhLiBa5HKEc dUMZrQNFAOC9rQPnilNDLk1jgFhtbouSR2A4MvqCHJnk29EhvjWbt+kFQw79KINikIj2 BHXw+gM+NnOfHmxk7SqpIHI0yzXMkOOomL/FmhrohkpD98XDspJQA40o22tOQQ00GPsZ KxgQ== X-Gm-Message-State: AE9vXwMshr/XESCeB0wFU18ePRf3GqdmBuzFNxdxG/QTxvNQpyc2Mz1B1VxVEW1EsVQNrw== X-Received: by 10.28.210.70 with SMTP id j67mr1181891wmg.10.1473920092226; Wed, 14 Sep 2016 23:14:52 -0700 (PDT) Received: from bark.daynix ([141.226.163.133]) by smtp.gmail.com with ESMTPSA id jd4sm1732011wjb.6.2016.09.14.23.14.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Sep 2016 23:14:51 -0700 (PDT) From: Dmitry Fleytman To: qemu-devel@nongnu.org Date: Thu, 15 Sep 2016 09:14:29 +0300 Message-Id: <1473920070-21938-7-git-send-email-dmitry@daynix.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1473920070-21938-1-git-send-email-dmitry@daynix.com> References: <1473920070-21938-1-git-send-email-dmitry@daynix.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 74.125.82.66 Subject: [Qemu-devel] [PATCH 6/7] e1000e: Fix spurious RX TCP ACK interrupts X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Vugenfirer , Jason Wang , Shmulik Ladkani Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Do not raise ACK interrupts when RFCTL.ACKDIS bit is set (see spec. 10.2.5.16). Signed-off-by: Dmitry Fleytman --- hw/net/e1000e_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index e70e669..f4ec79f 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -1710,7 +1710,8 @@ e1000e_receive_iov(E1000ECore *core, const struct iovec *iov, int iovcnt) } /* Perform ACK receive detection */ - if (e1000e_is_tcp_ack(core, core->rx_pkt)) { + if (!(core->mac[RFCTL] & E1000_RFCTL_ACK_DIS) && + (e1000e_is_tcp_ack(core, core->rx_pkt))) { n |= E1000_ICS_ACK; }