| Message ID | 1476792613-11712-18-git-send-email-zhang.zhanghailiang@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote: > configure --enable-colo/--disable-colo to switch COLO > support on/off. > COLO feature is enabled by default. > > Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com> > Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com> > Signed-off-by: Gonglei <arei.gonglei@huawei.com> > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Reviewed-by: Amit Shah <amit.shah@redhat.com> > v19: > - fix colo_supported() to return true > v11: > - Turn COLO on in default (Eric's suggestion) Can you recap why the suggestion was made to switch it on by default? Amit
On 10/26/2016 01:07 AM, Amit Shah wrote: > On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote: >> configure --enable-colo/--disable-colo to switch COLO >> support on/off. >> COLO feature is enabled by default. >> >> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com> >> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com> >> Signed-off-by: Gonglei <arei.gonglei@huawei.com> >> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > > Reviewed-by: Amit Shah <amit.shah@redhat.com> > >> v19: >> - fix colo_supported() to return true >> v11: >> - Turn COLO on in default (Eric's suggestion) > > Can you recap why the suggestion was made to switch it on by default? If the feature doesn't depend on external libraries, then enabling compilation by default will avoid bitrot. But mentioning this rationale in the commit message never hurts :)
On 2016/10/26 14:07, Amit Shah wrote: > On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote: >> configure --enable-colo/--disable-colo to switch COLO >> support on/off. >> COLO feature is enabled by default. >> >> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com> >> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com> >> Signed-off-by: Gonglei <arei.gonglei@huawei.com> >> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > > Reviewed-by: Amit Shah <amit.shah@redhat.com> > >> v19: >> - fix colo_supported() to return true >> v11: >> - Turn COLO on in default (Eric's suggestion) > > Can you recap why the suggestion was made to switch it on by default? > Hmm, this is suggested by Eric long time ago, and he has replied you email as well. :) > > Amit > > . >
On 2016/10/26 21:42, Eric Blake wrote: > On 10/26/2016 01:07 AM, Amit Shah wrote: >> On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote: >>> configure --enable-colo/--disable-colo to switch COLO >>> support on/off. >>> COLO feature is enabled by default. >>> >>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com> >>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com> >>> Signed-off-by: Gonglei <arei.gonglei@huawei.com> >>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> >> >> Reviewed-by: Amit Shah <amit.shah@redhat.com> >> >>> v19: >>> - fix colo_supported() to return true >>> v11: >>> - Turn COLO on in default (Eric's suggestion) >> >> Can you recap why the suggestion was made to switch it on by default? > > If the feature doesn't depend on external libraries, then enabling > compilation by default will avoid bitrot. > I agreed. > But mentioning this rationale in the commit message never hurts :) > Good idea, i'll add this instruction in commit message. Thank you very much for your speedy reply. :)
On (Wed) 26 Oct 2016 [08:42:27], Eric Blake wrote: > On 10/26/2016 01:07 AM, Amit Shah wrote: > > On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote: > >> configure --enable-colo/--disable-colo to switch COLO > >> support on/off. > >> COLO feature is enabled by default. > >> > >> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com> > >> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com> > >> Signed-off-by: Gonglei <arei.gonglei@huawei.com> > >> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > > > > Reviewed-by: Amit Shah <amit.shah@redhat.com> > > > >> v19: > >> - fix colo_supported() to return true > >> v11: > >> - Turn COLO on in default (Eric's suggestion) > > > > Can you recap why the suggestion was made to switch it on by default? > > If the feature doesn't depend on external libraries, then enabling > compilation by default will avoid bitrot. Yes, that's fair, thanks. > But mentioning this rationale in the commit message never hurts :) Yep! Amit
diff --git a/configure b/configure index dd9e679..6cf3f99 100755 --- a/configure +++ b/configure @@ -230,6 +230,7 @@ vhost_net="no" vhost_scsi="no" vhost_vsock="no" kvm="no" +colo="yes" rdma="" gprof="no" debug_tcg="no" @@ -918,6 +919,10 @@ for opt do ;; --enable-kvm) kvm="yes" ;; + --disable-colo) colo="no" + ;; + --enable-colo) colo="yes" + ;; --disable-tcg-interpreter) tcg_interpreter="no" ;; --enable-tcg-interpreter) tcg_interpreter="yes" @@ -1363,6 +1368,7 @@ disabled with --disable-FEATURE, default is enabled if available: fdt fdt device tree bluez bluez stack connectivity kvm KVM acceleration support + colo COarse-grain LOck-stepping VM for Non-stop Service rdma RDMA-based migration support vde support for vde network netmap support for netmap network @@ -4911,6 +4917,7 @@ echo "Linux AIO support $linux_aio" echo "ATTR/XATTR support $attr" echo "Install blobs $blobs" echo "KVM support $kvm" +echo "COLO support $colo" echo "RDMA support $rdma" echo "TCG interpreter $tcg_interpreter" echo "fdt support $fdt" @@ -5532,6 +5539,10 @@ if have_backend "syslog"; then fi echo "CONFIG_TRACE_FILE=$trace_file" >> $config_host_mak +if test "$colo" = "yes"; then + echo "CONFIG_COLO=y" >> $config_host_mak +fi + if test "$rdma" = "yes" ; then echo "CONFIG_RDMA=y" >> $config_host_mak fi diff --git a/migration/colo.c b/migration/colo.c index 31664e0..a39cd99 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -24,7 +24,7 @@ bool colo_supported(void) { - return false; + return true; } bool migration_in_colo_state(void)