From patchwork Wed Nov 2 09:48:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ashijeet Acharya X-Patchwork-Id: 9408869 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 673E96022E for ; Wed, 2 Nov 2016 09:52:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4C791283F9 for ; Wed, 2 Nov 2016 09:52:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3E59C288E9; Wed, 2 Nov 2016 09:52:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_WEB, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 104F628AAE for ; Wed, 2 Nov 2016 09:52:00 +0000 (UTC) Received: from localhost ([::1]:53670 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1sD9-0006u4-NA for patchwork-qemu-devel@patchwork.kernel.org; Wed, 02 Nov 2016 05:51:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1sCr-0006sW-N7 for qemu-devel@nongnu.org; Wed, 02 Nov 2016 05:51:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1sCm-0004XR-QZ for qemu-devel@nongnu.org; Wed, 02 Nov 2016 05:51:41 -0400 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:36500) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c1sCm-0004Wf-Ks; Wed, 02 Nov 2016 05:51:36 -0400 Received: by mail-pf0-x244.google.com with SMTP id n85so1327745pfi.3; Wed, 02 Nov 2016 02:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=UUyN7eR3ZfUKJgZmoLN7YZntfbaSgY13pYPT5Gg1A8g=; b=VjrUxkrND0A//AzwG2ILma3CN/IdflP/FWGkPcx4ikq/4piMbsoRb3jX4sOi5sgnhf IY4DG1FMO9NfGjklAtMT+rU9qgiNl3zMgkMf84ie3V+C4lodT1TXRlRnnduXd1HvKLVX gfQozs5BIJR/+7GstxphTWRo1jsueuPB5kSbPeajoKD258ssNfo/sHFQKESiDlKPRDdz R29K2sQGEwk1REgYBDAqUc2Bihk5+eZMTtiYJl+kHlSFPsTYtNA6XuXn2yQiN7lwunkj CQ7bDVQC2isdbHCO+QhW8sGWYZhgjUV/3GljtOWgTwT0sFXu0otURe4LzKtV7toV2pfr U3LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=UUyN7eR3ZfUKJgZmoLN7YZntfbaSgY13pYPT5Gg1A8g=; b=IX/GiXZWr8jWJieFfRxq5ldtTUF251cS6BnyeblnpEVa2mjLpfAylYcz0Bgw3H5qPw aDr02nAe0L8dbLCnB/8I54cxh9StG82jrnsGQ4tofx6+q4LVKFOfMa6XHpvKx55AJTYZ Ge4yRTJOrYfuXYioJRbRAM8ZVVyHz4KgW2O/si6rokObc8+jP7SPuk8WoKdgSCctcmeL OrZ6zkEPXuGXtu4TCV8f/oEsB3ftp6dHP5abc2o6LYgFlX1rb5Edey6QHKObjFat6aFI Xlk0qs0nu+N9T3hgqUXvYygaUsDkQi4eNaPJ0PDMweFnMNvQrBc+44HvbTLxuYTp4VBU 88uw== X-Gm-Message-State: ABUngvfz4uNHgR75r+7kvzLdPwm334fulspiUsowqIc1Q6T5Q+lnIZrZJkusEVT4QkwrUQ== X-Received: by 10.99.109.6 with SMTP id i6mr3372597pgc.139.1478080295243; Wed, 02 Nov 2016 02:51:35 -0700 (PDT) Received: from linux.local ([27.251.197.196]) by smtp.gmail.com with ESMTPSA id vz6sm1147959pab.15.2016.11.02.02.51.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 02 Nov 2016 02:51:34 -0700 (PDT) From: Ashijeet Acharya To: kwolf@redhat.com Date: Wed, 2 Nov 2016 15:18:40 +0530 Message-Id: <1478080120-3277-1-git-send-email-ashijeetacharya@gmail.com> X-Mailer: git-send-email 2.6.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::244 Subject: [Qemu-devel] [PATCH v2] block/nbd: Fix the regression to free leaked visitor X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com, Ashijeet Acharya , pbonzini@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch frees the leaked visitor in nbd_refresh_filename() and uses visit_free() to fix it. The leak was introduced by the commit 491d6c7. Signed-off-by: Ashijeet Acharya Reviewed-by: Eric Blake --- Changes in v2: - Include the regression commit id in the commit message --- block/nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/nbd.c b/block/nbd.c index 8ef1438..ff9d01a 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -545,6 +545,7 @@ static void nbd_refresh_filename(BlockDriverState *bs, QDict *options) qdict_put(opts, "tls-creds", qstring_from_str(s->tlscredsid)); } + visit_free(ov); qdict_flatten(opts); bs->full_open_options = opts; }