| Message ID | 1478517229-140028-14-git-send-email-guangrong.xiao@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Nov 07, 2016 at 07:13:48PM +0800, Xiao Guangrong wrote: > to make the code more clearer > > Suggested-by: Igor Mammedov <imammedo@redhat.com> > Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com> > --- > hw/acpi/nvdimm.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
On Mon, 7 Nov 2016 19:13:48 +0800 Xiao Guangrong <guangrong.xiao@linux.intel.com> wrote: > to make the code more clearer > > Suggested-by: Igor Mammedov <imammedo@redhat.com> > Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > hw/acpi/nvdimm.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c > index 6692648..5f48b75 100644 > --- a/hw/acpi/nvdimm.c > +++ b/hw/acpi/nvdimm.c > @@ -1098,13 +1098,11 @@ static void nvdimm_build_fit(Aml *dev) > buf_size = aml_local(1); > fit = aml_local(2); > > - aml_append(dev, aml_create_dword_field(aml_buffer(4, NULL), > - aml_int(0), NVDIMM_DSM_RFIT_STATUS)); > + aml_append(dev, aml_name_decl(NVDIMM_DSM_RFIT_STATUS, aml_int(0))); > > /* build helper function, RFIT. */ > method = aml_method("RFIT", 1, AML_SERIALIZED); > - aml_append(method, aml_create_dword_field(aml_buffer(4, NULL), > - aml_int(0), "OFST")); > + aml_append(method, aml_name_decl("OFST", aml_int(0))); > > /* prepare input package. */ > pkg = aml_package(1);
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 6692648..5f48b75 100644 --- a/hw/acpi/nvdimm.c +++ b/hw/acpi/nvdimm.c @@ -1098,13 +1098,11 @@ static void nvdimm_build_fit(Aml *dev) buf_size = aml_local(1); fit = aml_local(2); - aml_append(dev, aml_create_dword_field(aml_buffer(4, NULL), - aml_int(0), NVDIMM_DSM_RFIT_STATUS)); + aml_append(dev, aml_name_decl(NVDIMM_DSM_RFIT_STATUS, aml_int(0))); /* build helper function, RFIT. */ method = aml_method("RFIT", 1, AML_SERIALIZED); - aml_append(method, aml_create_dword_field(aml_buffer(4, NULL), - aml_int(0), "OFST")); + aml_append(method, aml_name_decl("OFST", aml_int(0))); /* prepare input package. */ pkg = aml_package(1);
to make the code more clearer Suggested-by: Igor Mammedov <imammedo@redhat.com> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com> --- hw/acpi/nvdimm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)