From patchwork Wed Jul 12 09:12:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Hao X-Patchwork-Id: 9835677 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5BFA260363 for ; Wed, 12 Jul 2017 00:59:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3A8FB28536 for ; Wed, 12 Jul 2017 00:59:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2B770285D1; Wed, 12 Jul 2017 00:59:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=2.0 tests=BAYES_00, DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B5FCE28536 for ; Wed, 12 Jul 2017 00:59:58 +0000 (UTC) Received: from localhost ([::1]:49568 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dV60T-0003PS-KA for patchwork-qemu-devel@patchwork.kernel.org; Tue, 11 Jul 2017 20:59:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dV5zs-0003P9-3B for qemu-devel@nongnu.org; Tue, 11 Jul 2017 20:59:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dV5zo-0006Uo-1x for qemu-devel@nongnu.org; Tue, 11 Jul 2017 20:59:20 -0400 Received: from mxhk.zte.com.cn ([63.217.80.70]:50455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dV5zn-0006UL-Ex for qemu-devel@nongnu.org; Tue, 11 Jul 2017 20:59:15 -0400 X-scanvirus: By SEG_CYREN AntiVirus Engine X-scanresult: CLEAN X-MAILFROM: X-RCPTTO: X-FROMIP: 10.30.3.20 X-SEG-Scaned: 1 X-Received: unknown,10.30.3.20,20170712084936 Received: from unknown (HELO mse01.zte.com.cn) (10.30.3.20) by localhost with (AES256-SHA encrypted) SMTP; 12 Jul 2017 00:49:36 -0000 Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id v6C0wOkP004280; Wed, 12 Jul 2017 08:58:24 +0800 (GMT-8) (envelope-from peng.hao2@zte.com.cn) Received: from localhost.localdomain ([10.74.120.59]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2017071208582752-3700603 ; Wed, 12 Jul 2017 08:58:27 +0800 From: Peng Hao To: rth@twiddle.net, pbonzini@redhat.com, ehabkost@redhat.com, kvm@vger.kernel.org, mtosatti@redhat.com Date: Wed, 12 Jul 2017 17:12:07 +0800 Message-Id: <1499850727-50728-1-git-send-email-peng.hao2@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-07-12 08:58:27, Serialize by Router on notes_smtp/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-07-12 08:58:16, Serialize complete at 2017-07-12 08:58:16 X-MAIL: mse01.zte.com.cn v6C0wOkP004280 X-HQIP: 127.0.0.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-Received-From: 63.217.80.70 Subject: [Qemu-devel] [PATCH] target-i386:kvm_get/put_vcpu_events don't handle sipi_vector X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peng Hao , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP qemu call kvm_get_vcpu_events, and kernel return sipi_vector always 0, never valid when reporting to user space. But qemu call kvm_put_vcpu_events will make sipi_vector in kernel be 0. This will accidently modify sipi_vector when sipi_vector in kernel is not 0. Signed-off-by: Peng Hao Reviewed-by: Wang Yechao --- target/i386/kvm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index f84a49d..bbbd696 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -2417,7 +2417,6 @@ static int kvm_put_vcpu_events(X86CPU *cpu, int level) events.nmi.masked = !!(env->hflags2 & HF2_NMI_MASK); events.nmi.pad = 0; - events.sipi_vector = env->sipi_vector; events.flags = 0; if (has_msr_smbase) { @@ -2506,8 +2505,6 @@ static int kvm_get_vcpu_events(X86CPU *cpu) } } - env->sipi_vector = events.sipi_vector; - return 0; }