diff mbox

qga-win32: remove a redundancy code

Message ID 1500158641-23033-1-git-send-email-peng.hao2@zte.com.cn (mailing list archive)
State New, archived
Headers show

Commit Message

Peng Hao July 15, 2017, 10:44 p.m. UTC 
In the first line of run_agent,it has set ga_state = s,don't need
set ga_state = s again behind.

Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
---
 qga/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé July 17, 2017, 4:35 a.m. UTC | #1 
Cc'ing qemu-trivial

On 07/15/2017 07:44 PM, Peng Hao wrote:
> In the first line of run_agent,it has set ga_state = s,don't need
> set ga_state = s again behind.
> 
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>   qga/main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qga/main.c b/qga/main.c
> index 405c129..dcd6104 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -1314,7 +1314,7 @@ static int run_agent(GAState *s, GAConfig *config, int socket_activation)
>       ga_command_state_init(s, s->command_state);
>       ga_command_state_init_all(s->command_state);
>       json_message_parser_init(&s->parser, process_event);
> -    ga_state = s;
> +
>   #ifndef _WIN32
>       if (!register_signal_handlers()) {
>           g_critical("failed to register signal handlers");
>
diff mbox

Patch

diff --git a/qga/main.c b/qga/main.c
index 405c129..dcd6104 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -1314,7 +1314,7 @@  static int run_agent(GAState *s, GAConfig *config, int socket_activation)
     ga_command_state_init(s, s->command_state);
     ga_command_state_init_all(s->command_state);
     json_message_parser_init(&s->parser, process_event);
-    ga_state = s;
+
 #ifndef _WIN32
     if (!register_signal_handlers()) {
         g_critical("failed to register signal handlers");