From patchwork Thu Jul 27 14:33:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ashijeet Acharya X-Patchwork-Id: 9867029 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EBC6B6035E for ; Thu, 27 Jul 2017 14:36:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DDFB828821 for ; Thu, 27 Jul 2017 14:36:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D29F52882A; Thu, 27 Jul 2017 14:36:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5AA1028821 for ; Thu, 27 Jul 2017 14:36:23 +0000 (UTC) Received: from localhost ([::1]:43383 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dajtm-0002uD-GS for patchwork-qemu-devel@patchwork.kernel.org; Thu, 27 Jul 2017 10:36:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dajpn-000886-Bg for qemu-devel@nongnu.org; Thu, 27 Jul 2017 10:32:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dajpm-00066o-Dr for qemu-devel@nongnu.org; Thu, 27 Jul 2017 10:32:15 -0400 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:35795) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dajpm-000662-6e; Thu, 27 Jul 2017 10:32:14 -0400 Received: by mail-pg0-x244.google.com with SMTP id d193so20699253pgc.2; Thu, 27 Jul 2017 07:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tM8UOu8eAzwq/xiojBsV091KEnmCM0u0ncyRbQWidxk=; b=Le8/9UFWEeM46lk+LlGZOW2jUQ5ftBerC8Si+IPTbStrfkuHGqbcKoHqqMb+DnRycl sJZ1+pmzjydEFGMBmx/DJ54GQ632trLz0Mw8WjMSmmrsgR/Xa2OJWeQ+lMPRjomhsMPy ipK2ngBQaug8+wF8k1GdZCIHmO1ulXYkc9G1CknQglqHT837WyDl3uD9ldE5ojJpenFS JKPYo+yPYo+ncfzPomrYqsFlPHOo+FSemRl1zJHzXgVcaAqrUrwuoEGe1t8nSaHwBZXy 6H2l5GIHOj01/vw8NFIDffuGaPmGzaIvJvhin7Iu2yztA21cSQ5O6Y1qAsnb4pL1kOwE Z/GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tM8UOu8eAzwq/xiojBsV091KEnmCM0u0ncyRbQWidxk=; b=FkM+shQFENlUQ579Xcd1zbEhhRN0iewqSOWo/SMewd70D2LiLYmROBa548+FffmJSA KcbLGc4z8fQuuDyVYOgogSlXZgjbFv5DOssvJkCJMI7E0tPPOX24oMTM9CYTR1SBIOmL weoWgVe21Ey2WgbXXGLh0Oqt2zN44V1W4rWkyWuo7FlQLT5wgto9/909pskdYIEzF5/H iaPp7VV5KwXz0xLvggKAy+vEazdq3bG7CngRk7WFVlSiHH79oWqKWJk6r4toFu1+24+D F51edxOjCQA51R4NSC0XAmVpRmP2Iq4Wsm3gIyFqyfMs5qZv7GZ+PuQr5VFAMkh8Xxq1 rVSQ== X-Gm-Message-State: AIVw113HB8EL8ARpyyCq1hZuHDaJGP9ptKTn/QkrtROwlPhlNPocOuNT EHjfZ4rAG6CN2g== X-Received: by 10.98.9.135 with SMTP id 7mr4347530pfj.15.1501165933211; Thu, 27 Jul 2017 07:32:13 -0700 (PDT) Received: from linux.local ([27.251.197.195]) by smtp.gmail.com with ESMTPSA id y14sm32579540pfa.52.2017.07.27.07.32.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 27 Jul 2017 07:32:12 -0700 (PDT) From: Ashijeet Acharya To: famz@redhat.com Date: Thu, 27 Jul 2017 20:03:10 +0530 Message-Id: <1501165990-28033-9-git-send-email-ashijeetacharya@gmail.com> X-Mailer: git-send-email 2.6.2 In-Reply-To: <1501165990-28033-1-git-send-email-ashijeetacharya@gmail.com> References: <1501165990-28033-1-git-send-email-ashijeetacharya@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 Subject: [Qemu-devel] [PATCH v8 8/8] vmdk: Make vmdk_get_cluster_offset() return cluster offset only X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-block@nongnu.org, stefanha@gmail.com, qemu-devel@nongnu.org, mreitz@redhat.com, Ashijeet Acharya , jsnow@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP vmdk_alloc_clusters() introduced earlier now handles the task of allocating clusters and performing COW when needed. Thus we can change vmdk_get_cluster_offset() to stick to the sole purpose of returning cluster offset using sector number. Update the changes at all call sites. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 56 ++++++++++++-------------------------------------------- 1 file changed, 12 insertions(+), 44 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 4a59ca4..a84b26c 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1494,25 +1494,16 @@ static int vmdk_alloc_clusters(BlockDriverState *bs, * For flat extents, the start offset as parsed from the description file is * returned. * - * For sparse extents, look up in L1, L2 table. If allocate is true, return an - * offset for a new cluster and update L2 cache. If there is a backing file, - * COW is done before returning; otherwise, zeroes are written to the allocated - * cluster. Both COW and zero writing skips the sector range - * [@skip_start_sector, @skip_end_sector) passed in by caller, because caller - * has new data to write there. + * For sparse extents, look up the L1, L2 table. * * Returns: VMDK_OK if cluster exists and mapped in the image. - * VMDK_UNALLOC if cluster is not mapped and @allocate is false. - * VMDK_ERROR if failed. + * VMDK_UNALLOC if cluster is not mapped. + * VMDK_ERROR if failed */ static int vmdk_get_cluster_offset(BlockDriverState *bs, VmdkExtent *extent, - VmdkMetaData *m_data, uint64_t offset, - bool allocate, - uint64_t *cluster_offset, - uint64_t skip_start_bytes, - uint64_t skip_end_bytes) + uint64_t *cluster_offset) { int l1_index, l2_offset, l2_index; uint32_t *l2_table; @@ -1537,31 +1528,9 @@ static int vmdk_get_cluster_offset(BlockDriverState *bs, } if (!cluster_sector || zeroed) { - if (!allocate) { - return zeroed ? VMDK_ZEROED : VMDK_UNALLOC; - } - - cluster_sector = extent->next_cluster_sector; - extent->next_cluster_sector += extent->cluster_sectors; - - /* First of all we write grain itself, to avoid race condition - * that may to corrupt the image. - * This problem may occur because of insufficient space on host disk - * or inappropriate VM shutdown. - */ - ret = vmdk_perform_cow(bs, extent, cluster_sector * BDRV_SECTOR_SIZE, - offset, skip_start_bytes, skip_end_bytes); - if (ret) { - return ret; - } - if (m_data) { - m_data->valid = 1; - m_data->l1_index = l1_index; - m_data->l2_index = l2_index; - m_data->l2_offset = l2_offset; - m_data->l2_cache_entry = &l2_table[l2_index]; - } + return zeroed ? VMDK_ZEROED : VMDK_UNALLOC; } + *cluster_offset = cluster_sector << BDRV_SECTOR_BITS; return VMDK_OK; } @@ -1604,9 +1573,7 @@ static int64_t coroutine_fn vmdk_co_get_block_status(BlockDriverState *bs, return 0; } qemu_co_mutex_lock(&s->lock); - ret = vmdk_get_cluster_offset(bs, extent, NULL, - sector_num * 512, false, &offset, - 0, 0); + ret = vmdk_get_cluster_offset(bs, extent, sector_num * 512, &offset); qemu_co_mutex_unlock(&s->lock); index_in_cluster = vmdk_find_index_in_cluster(extent, sector_num); @@ -1797,13 +1764,14 @@ vmdk_co_preadv(BlockDriverState *bs, uint64_t offset, uint64_t bytes, ret = -EIO; goto fail; } - ret = vmdk_get_cluster_offset(bs, extent, NULL, - offset, false, &cluster_offset, 0, 0); + offset_in_cluster = vmdk_find_offset_in_cluster(extent, offset); n_bytes = MIN(bytes, extent->cluster_sectors * BDRV_SECTOR_SIZE - offset_in_cluster); + ret = vmdk_get_cluster_offset(bs, extent, offset, &cluster_offset); + if (ret != VMDK_OK) { /* if not allocated, try to read from parent image, if exist */ if (bs->backing && ret != VMDK_ZEROED) { @@ -2550,9 +2518,9 @@ static int vmdk_check(BlockDriverState *bs, BdrvCheckResult *result, sector_num); break; } - ret = vmdk_get_cluster_offset(bs, extent, NULL, + ret = vmdk_get_cluster_offset(bs, extent, sector_num << BDRV_SECTOR_BITS, - false, &cluster_offset, 0, 0); + &cluster_offset); if (ret == VMDK_ERROR) { fprintf(stderr, "ERROR: could not get cluster_offset for sector %"