From patchwork Mon Sep 11 18:56:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Xu X-Patchwork-Id: 9947949 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 26097602C9 for ; Mon, 11 Sep 2017 18:39:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1E53D28D05 for ; Mon, 11 Sep 2017 18:39:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0F7D128D13; Mon, 11 Sep 2017 18:39:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9E94F28D05 for ; Mon, 11 Sep 2017 18:39:55 +0000 (UTC) Received: from localhost ([::1]:59934 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drTcg-0003lN-Hq for patchwork-qemu-devel@patchwork.kernel.org; Mon, 11 Sep 2017 14:39:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drTZk-0001Rq-8A for qemu-devel@nongnu.org; Mon, 11 Sep 2017 14:36:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drTZj-0005lL-Gj for qemu-devel@nongnu.org; Mon, 11 Sep 2017 14:36:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54212) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1drTZj-0005ky-AZ for qemu-devel@nongnu.org; Mon, 11 Sep 2017 14:36:51 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5F0C58AE7F for ; Mon, 11 Sep 2017 18:36:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5F0C58AE7F Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=wexu@redhat.com Received: from Wei-Dev.nay.redhat.com (dhcp-15-231.nay.redhat.com [10.66.15.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6175E600C4; Mon, 11 Sep 2017 18:36:48 +0000 (UTC) From: wexu@redhat.com To: qemu-devel@nongnu.org Date: Tue, 12 Sep 2017 02:56:32 +0800 Message-Id: <1505156192-18994-4-git-send-email-wexu@redhat.com> In-Reply-To: <1505156192-18994-1-git-send-email-wexu@redhat.com> References: <1505156192-18994-1-git-send-email-wexu@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 11 Sep 2017 18:36:50 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [Patch 3/3] vfio: remove checking duplicated vfio device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcel@redhat.com, jasowang@redhat.com, alex.williamson@redhat.com, Wei Xu Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Xu This has been done when introducing 'vfio_lookup_as()' patch as a side work to reuse the loop. Signed-off-by: Wei Xu --- hw/vfio/pci.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 856cefd..d78f756 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -2632,7 +2632,6 @@ static void vfio_unregister_req_notifier(VFIOPCIDevice *vdev) static void vfio_realize(PCIDevice *pdev, Error **errp) { VFIOPCIDevice *vdev = DO_UPCAST(VFIOPCIDevice, pdev, pdev); - VFIODevice *vbasedev_iter; VFIOGroup *group; char *tmp, group_path[PATH_MAX], *group_name; Error *err = NULL; @@ -2697,14 +2696,6 @@ static void vfio_realize(PCIDevice *pdev, Error **errp) goto error; } - QLIST_FOREACH(vbasedev_iter, &group->device_list, next) { - if (strcmp(vbasedev_iter->name, vdev->vbasedev.name) == 0) { - error_setg(errp, "device is already attached"); - vfio_put_group(group); - goto error; - } - } - ret = vfio_get_device(group, vdev->vbasedev.name, &vdev->vbasedev, errp); if (ret) { vfio_put_group(group);