From patchwork Tue May 24 19:34:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 9134183 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4A5486075E for ; Tue, 24 May 2016 19:35:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C0372825C for ; Tue, 24 May 2016 19:35:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 30F2F2829E; Tue, 24 May 2016 19:35:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B334B2825C for ; Tue, 24 May 2016 19:35:02 +0000 (UTC) Received: from localhost ([::1]:55061 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5I6X-000798-TB for patchwork-qemu-devel@patchwork.kernel.org; Tue, 24 May 2016 15:35:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5I66-000759-NS for qemu-devel@nongnu.org; Tue, 24 May 2016 15:34:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5I60-0003fT-Oh for qemu-devel@nongnu.org; Tue, 24 May 2016 15:34:33 -0400 Received: from mx5-phx2.redhat.com ([209.132.183.37]:49057) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5I60-0003fL-Gf for qemu-devel@nongnu.org; Tue, 24 May 2016 15:34:28 -0400 Received: from zmail17.collab.prod.int.phx2.redhat.com (zmail17.collab.prod.int.phx2.redhat.com [10.5.83.19]) by mx5-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4OJYOpi029413; Tue, 24 May 2016 15:34:24 -0400 Date: Tue, 24 May 2016 15:34:24 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau To: Gerd Hoffmann Message-ID: <1510504332.743167.1464118464547.JavaMail.zimbra@redhat.com> In-Reply-To: <1464097171.20136.4.camel@redhat.com> References: <1455873289-349-1-git-send-email-kraxel@redhat.com> <1458307049.6882.54.camel@redhat.com> <1458555845.4299.49.camel@redhat.com> <1464011569.29367.27.camel@redhat.com> <1464097171.20136.4.camel@redhat.com> MIME-Version: 1.0 X-Originating-IP: [10.3.116.122] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF46 (Linux)/8.0.6_GA_5922) Thread-Topic: spice/gl: create dummy primary surface (RfC) Thread-Index: T5BHrpKO8C+CCyGUIX6pSkF0420jZA== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.37 Subject: Re: [Qemu-devel] [Spice-devel] [PATCH v2 10/12] spice/gl: create dummy primary surface (RfC) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: spice-devel , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , QEMU Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hi ----- Original Message ----- > On Mo, 2016-05-23 at 16:03 +0200, Marc-André Lureau wrote: > > Hi > > > > On Mon, May 23, 2016 at 3:52 PM, Gerd Hoffmann wrote: > > > Hi, > > > > > > Resuming to work on this after 2.6 freeze break ... > > > > > >> I have done some more testing and sent a series for spice-gtk fixing > > >> display with gl scanout-only case. And a minor patch to spice server > > >> to solve a cursor initialization when there is no canvas. > > What is the upstream status of this? Built a bunch of fresh packages > today, including new spice-server and spice-gtk from master branch. And > a bunch spice-gtk dependencies, due to soname change. Still not working > without the dummy primary surface. spicy from master works for me. However I found an issue with virt-viewer, due to delayed widget realize in this gl-only case, see: https://lists.freedesktop.org/archives/spice-devel/2016-May/029446.html > > > >> (process:21117): Spice-CRITICAL **: > > >> red-qxl.c:900:spice_qxl_gl_draw_async: condition > > >> `qxl_state->scanout.drm_dma_buf_fd != -1' failed > > > I can't really make sense of a call to spice_qxl_gl_draw_async() if > > there is no scanout backing. So I can imagine the fix is on qemu side. > > Indeed. That one should be fixed now. Thanks > > > Do you have an up to date branch for testing? > > Pushed fresh branch to the usual work/virgl location. I found a cursor issue, due to spice worker being idle, and this solves it: What do you think? commit bae34dde7b229cc87347639ac34d835b80725e1f Author: Marc-André Lureau Date: Tue May 24 20:34:05 2016 +0200 spice: wakeup worker to pick up mouse changes Signed-off-by: Marc-André Lureau diff --git a/ui/spice-display.c b/ui/spice-display.c index 5ed7630..a04432c 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -766,6 +766,7 @@ static void display_mouse_set(DisplayChangeListener *dcl, g_free(ssd->ptr_move); ssd->ptr_move = qemu_spice_create_cursor_update(ssd, NULL, on); qemu_mutex_unlock(&ssd->lock); + qemu_spice_wakeup(ssd); } static void display_mouse_define(DisplayChangeListener *dcl, @@ -784,6 +785,7 @@ static void display_mouse_define(DisplayChangeListener *dcl, g_free(ssd->ptr_define); ssd->ptr_define = qemu_spice_create_cursor_update(ssd, c, 0); qemu_mutex_unlock(&ssd->lock); + qemu_spice_wakeup(ssd); } static const DisplayChangeListenerOps display_listener_ops = {