| Message ID | 1523541337-23919-1-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 12 April 2018 at 14:55, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > It is not uncommon for a contemporary FDT to be larger than 64 KiB, > leading to failures loading the device tree from sysfs: > > qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE > > Hence increase the limit to 1 MiB, like on PPC. > > For reference, the largest arm64 DTB created from the Linux sources is > ca. 75 KiB large (100 KiB when built with symbols/fixup support). > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > v3: > - Update example size figures, > > v2: > - Enlarge from 128 KiB to 1 MiB, as suggested by Peter Maydell. > --- > device_tree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks; applied to target-arm.next for 2.13. I'll add cc:qemu-stable too. -- PMM
diff --git a/device_tree.c b/device_tree.c index 19458b32bf81e55e..52c3358a55838d33 100644 --- a/device_tree.c +++ b/device_tree.c @@ -29,7 +29,7 @@ #include <libfdt.h> -#define FDT_MAX_SIZE 0x10000 +#define FDT_MAX_SIZE 0x100000 void *create_device_tree(int *sizep) {
It is not uncommon for a contemporary FDT to be larger than 64 KiB, leading to failures loading the device tree from sysfs: qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE Hence increase the limit to 1 MiB, like on PPC. For reference, the largest arm64 DTB created from the Linux sources is ca. 75 KiB large (100 KiB when built with symbols/fixup support). Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- v3: - Update example size figures, v2: - Enlarge from 128 KiB to 1 MiB, as suggested by Peter Maydell. --- device_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)