| Message ID | 1524119244-1240-1-git-send-email-saipava@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 19 April 2018 at 08:27, Sai Pavan Boddu <sai.pavan.boddu@xilinx.com> wrote: > SNOOP_NONE state handle is moved above in the if ladder, as it's same > as SNOOP_STRIPPING during data cycles. > > Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com> > Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com> > --- > Changes for V2: > Fixed commit message > Reordered to code, to avoid code duplication. > Changes for V3: > Dropped the cover letter, as its a minor fix now > Fixed commit message by explaining only what's fixed > removed the dummy_byte decrement changes > > hw/ssi/xilinx_spips.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c > index 426f971..03f5fae 100644 > --- a/hw/ssi/xilinx_spips.c > +++ b/hw/ssi/xilinx_spips.c > @@ -616,7 +616,8 @@ static void xilinx_spips_flush_txfifo(XilinxSPIPS *s) > if (fifo8_is_empty(&s->tx_fifo)) { > xilinx_spips_update_ixr(s); > return; > - } else if (s->snoop_state == SNOOP_STRIPING) { > + } else if (s->snoop_state == SNOOP_STRIPING || > + s->snoop_state == SNOOP_NONE) { > for (i = 0; i < num_effective_busses(s); ++i) { > tx_rx[i] = fifo8_pop(&s->tx_fifo); > } > -- > 2.7.4 > > >
On 20 April 2018 at 18:26, francisco iglesias <frasse.iglesias@gmail.com> wrote: > > > On 19 April 2018 at 08:27, Sai Pavan Boddu <sai.pavan.boddu@xilinx.com> > wrote: >> >> SNOOP_NONE state handle is moved above in the if ladder, as it's same >> as SNOOP_STRIPPING during data cycles. >> >> Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com> > > > Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com> > >> Applied to target-arm.next, thanks. -- PMM
diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 426f971..03f5fae 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -616,7 +616,8 @@ static void xilinx_spips_flush_txfifo(XilinxSPIPS *s) if (fifo8_is_empty(&s->tx_fifo)) { xilinx_spips_update_ixr(s); return; - } else if (s->snoop_state == SNOOP_STRIPING) { + } else if (s->snoop_state == SNOOP_STRIPING || + s->snoop_state == SNOOP_NONE) { for (i = 0; i < num_effective_busses(s); ++i) { tx_rx[i] = fifo8_pop(&s->tx_fifo); }
SNOOP_NONE state handle is moved above in the if ladder, as it's same as SNOOP_STRIPPING during data cycles. Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com> --- Changes for V2: Fixed commit message Reordered to code, to avoid code duplication. Changes for V3: Dropped the cover letter, as its a minor fix now Fixed commit message by explaining only what's fixed removed the dummy_byte decrement changes hw/ssi/xilinx_spips.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)