From patchwork Tue Aug 21 09:46:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Nefedov X-Patchwork-Id: 10571295 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6572E139B for ; Tue, 21 Aug 2018 09:50:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 53C0829CDF for ; Tue, 21 Aug 2018 09:50:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 481A429CE8; Tue, 21 Aug 2018 09:50:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C444B29CDF for ; Tue, 21 Aug 2018 09:50:52 +0000 (UTC) Received: from localhost ([::1]:51995 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fs3JM-0006u7-0P for patchwork-qemu-devel@patchwork.kernel.org; Tue, 21 Aug 2018 05:50:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fs3FR-0003qs-2c for qemu-devel@nongnu.org; Tue, 21 Aug 2018 05:46:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fs3FO-0007up-KS for qemu-devel@nongnu.org; Tue, 21 Aug 2018 05:46:48 -0400 Received: from mail-eopbgr40122.outbound.protection.outlook.com ([40.107.4.122]:7520 helo=EUR03-DB5-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fs3FM-0007oN-LK; Tue, 21 Aug 2018 05:46:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1+oL0BKEpv7OLF4/VmVEQPpQoiUiRM8mPV9ZTbBeV6A=; b=c3AfqtZhAw5Mac7ipFDvB8BTEOIDJuPpDcXbI6IqZYbLbbCfK+tgYVGmqGelpG5xd0emn9bbqyNZh5a6hRVmWY/cFTyEd12l0/0zkz0bvNSTy+G4H6MylwTDkjB/9gGf7hpFJay2Hqyw4cFv5iKH+P8wX8ACSYQHg27iQKZO1/w= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=anton.nefedov@virtuozzo.com; Received: from xantnef-ws.sw.ru (185.231.240.5) by AM0PR08MB3347.eurprd08.prod.outlook.com (2603:10a6:208:5f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1059.22; Tue, 21 Aug 2018 09:46:40 +0000 From: Anton Nefedov To: qemu-devel@nongnu.org Date: Tue, 21 Aug 2018 12:46:12 +0300 Message-Id: <1534844779-118784-2-git-send-email-anton.nefedov@virtuozzo.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1534844779-118784-1-git-send-email-anton.nefedov@virtuozzo.com> References: <1534844779-118784-1-git-send-email-anton.nefedov@virtuozzo.com> MIME-Version: 1.0 X-Originating-IP: [185.231.240.5] X-ClientProxiedBy: HE1PR08CA0076.eurprd08.prod.outlook.com (2603:10a6:7:2a::47) To AM0PR08MB3347.eurprd08.prod.outlook.com (2603:10a6:208:5f::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e847e81e-9958-4282-95b4-08d6074affc1 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:AM0PR08MB3347; X-Microsoft-Exchange-Diagnostics: 1; AM0PR08MB3347; 3:K5xJzusjobWLujj81hxFNxey2enSJvUTuA+euca5wK6Gxtuw+qK++p9tpjND8yMPrIIXasHq45wVyIlO9v8iEBLF32UErk6IirJUYsD75s0ZlLrjHMkj67Ew6qc1TM/OfEFujcLAx/N6S7Q1mm7xEM1ud5ZHdUil/PAQj30H71yhLJ9DLV60OX7miPz8Ckx3NEgfINQQTpO7qS5nKa+6YQ3XhvTMR5GZME85xpR2LtCLoMG6wg0eN4NRHB2CXFZ7; 25:hoWfi3pm9/6TH0xWzrlEHdK60HK0i9a95e0aXaRDyvOnmcrr/95cgOtgwrk2whGBBiq4qg4QBs/DnSG4ZDzV3MGGhNP6E46WQEGi2g6dfikkThh4yQHJP17qmGYthGjv0bO7hf7XjvnGh3a9OQJZQFnzxKfYjaD8cxI5uchJcPxp4aXKwt3M0vVpTxcTmCDgqMADrgo+Ir42AR8atArgKA6eueVVWO+j8wgFCkea6V8byJN0laDvC5g+R0Q6UKZY+lRt6jAeuJnd2XFPsfLTINGrTLDY46DMh8KqmWxa3b+z/LBU/neR/otBfB9GTyEdxvLyB4IfX7xg56PS+oYOjA==; 31:oVsdrL74jZuBYy6PYOkmKR5PElsK1eCypMBgc/PWKl9WVLHvREaxof5p/tzpZ2GDwBhbl8ru4whtS+hV2fDPyMfUEs3uwVyIH8RxBnNh+IlYhXvPUDiRzt41IQGYxOLlO2ba4Pml5Q49p7SVxKLMi/lP9WtXKtrtqFNbVmiyYaaxx368Vw3q0b4p7+jo6v/eoWuaY0i3kviREOonF3wOMTiJG2KSLfP7zXsj6Z1dvgo= X-MS-TrafficTypeDiagnostic: AM0PR08MB3347: X-Microsoft-Exchange-Diagnostics: 1; AM0PR08MB3347; 20:Rq2XC3K3UcVMAhrLBCQinC4D5gcxi0ugJptR1qim/XIgsw3sxjEdH/6gu01Qg4/gIGd6H+ZVlPjW4n8d1a5EHuzm8gWcDBGdTMxYPPIEdSVs06LV1TMMHJk5AbvIkeREraGeR8fPblt/PpXbXRHB4LFi1EQXF8BtGAdQQT6207juRIhd0yhbOyRx2oaj5UxxdlIEBrUvZ26JOoIp4z+RidqCuPQIKpCS5Q7tp7DXYhHlOFmkDnMaMWG5X9LMxO73IHLZFLvOI/18DKhD5HIs3cdXfgwFv+DS0fc+QbdSXB5eQe7c7ys8tCjV3+IGQ4XPzA7mjVlvXr3NT+NV+skDiP9+fe1lV4DV2Tf0/8y0QM2379jSLHESAqgskYWAVNb6btebDhY01VSNmyOMWqQ02I/RYcLeqnOEn6Rj79E16la3nNVT6GAZFYRjIJDuWbt/JVGaotgdugRHQTuxqG6oKsEK3nOB5PcUsmKImBT5QitSYsEn8oAPUyG/UG4onby7; 4:04AwMKXGxkzq+BbxnknfGRxGKBzBpUfDonbmvRCh3+kuHSKkIQBBIdPMoOYD5Pbvg5d6W4O51MEfWS4MuLW/TtLMvVWmcABbBAAPJGuQO1wT/YTd0Y60ANg1yToFWJpWDQk8Mq7tbiYKFXi851w2JR/q0hlMIe/d3JZe3X2aKUaJCf0amMx1N5dOQkuAPEmhced3yt08Cs8BNQVyWlXqOagsb+I48KTDkJ3zsZi/CHVf6xPHCISJYSozzBA5jpoYnA/2FYBRwgzoP3I0QwvFUQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231311)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123560045)(20161123564045)(201708071742011)(7699016); SRVR:AM0PR08MB3347; BCL:0; PCL:0; RULEID:; SRVR:AM0PR08MB3347; X-Forefront-PRVS: 0771670921 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(39850400004)(136003)(396003)(376002)(366004)(346002)(199004)(189003)(36756003)(305945005)(53416004)(105586002)(51416003)(48376002)(50226002)(8936002)(6116002)(7736002)(956004)(3846002)(69596002)(50466002)(68736007)(186003)(106356001)(2616005)(16526019)(16586007)(47776003)(486006)(476003)(52116002)(446003)(66066001)(86362001)(14444005)(107886003)(76176011)(2351001)(4326008)(316002)(5660300001)(25786009)(53936002)(478600001)(2361001)(6506007)(386003)(2906002)(6916009)(6486002)(6512007)(81156014)(81166006)(97736004)(6666003)(11346002)(8676002)(26005)(7416002)(44832011); DIR:OUT; SFP:1102; SCL:1; SRVR:AM0PR08MB3347; H:xantnef-ws.sw.ru; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM0PR08MB3347; 23:KjXsEOm9r+h6d6Nx80SfDhQfkHfqJc0bmKlDvb1d7?= nwPq0mnD8FdoJUvh9a95HudE73KNGQrVaxD4q9MzuHojPuI83WVBfb84QdQ1IwykuLML8FIXy/oxdE/Q0v9O/8y2capWzzNtb7GN3GSAnxgbYpHroVSzeZMSJQ2XSnm4LqZDMttGiQ4l232PY3YgnnGHhQU7hwbqaNfHy1/QgIm6ohW0wEI2Ep+VTDljaN8/sFnT39TFgWFQdqbDRK/qsfoNU+jlNevJhd8TVykJsy1VGhaETCc1zskQe8zgfoeDRIuppxH7MpuOreKMSUX1wVng8VAwBjTMZRNDk9zQwhwdeSIvMLRUP/pP/D6Xk4WuvCdGefd9nrEI33wAc+g+r+jMwAE2Uh2RLfsGf2JImlRb+qfENyVdtCPM1wqbIyk6FzT7sMl4sk3BZpjcdGyf9l8mxa3mEXd0wvjSeIB1oBIEZaRC9ojfSlWt9cWM6w6SOGJ5yQepHujk0thu7ki3GmEwKkSttNwO8Uzz+V36fS4gjqmxgNibHBg82EhbC0GdMSRrCYnF4EdFta63/vP+oXXVmCOEun15Bs8qps0Vfou9BrKWcS5Gg8oIDL+vrMLLSZPqMOK3TIEP3Cw/fuQR75DOhK07pi5vMp6s3juRJqk8QNd0iOd05NmfESmfj0DQJGXufDPUbwvPAHfa5JDF71pXp+3FeK/woCIhvuuC6AG4dkiusHlJKFMVoHbi3X1nq90F+05aqOEfG62YDpkoodb0PdqosDz09msOXrdd8D3QtTOeuFjoV+xcRHxQyxtJ1r9sPQeK94jSh6Y0ZG4UjpXb0wrtLbIk+UDkRjwo7KzWQyVEV+f8uyXmdiGthCNgpNflVBCd1272ldfZ+jRUk409p+hSOfj0AsLMq7wz12OlHEuYuifJsmSYrBvViVhZI21iSkEkUb/zX2qAa0YdJQVmpxE8Vk3RIKAroPrym/A38EzWal/Svg7/4LS2flSZSpK2qG0w+deqllT8frBCro27A2RvuqFrmefkyq56LU2JF6ovV9ZEUvxyVFrwlhYrWuB+ol45cI6EtAjfHUNgCoFXOVUhBWNiuQfnDWiaC97NFWUVQOuSb72TE6hff4mDRVgIc4o1aJkW1RzHEiLa2MbN2pMm6eoimAKj5eYf16UXJoiEmmDLHVa4MJcAhg5p1r4+JcS5eFdObaPfmONhV0qJ4IVGUqanA5B5Zhb3XQL2QehDxVfdQAM1PjiB12eI3T6FNJPfFaGbUOW3qbSfkqPx81AKh42liwBbEmVmDmsw0j/I1RVGBJyE3dHnSdffmHilrS/ywSMsORMN/+V9AJn X-Microsoft-Antispam-Message-Info: 7vvaF1Wh5jL7hvpPjTgwaxS+u1SkcPre9uZWEemlX4n2G+7ZkapseF23db0QsBewzMylrQaq8ZSwQLnlVyEF/M54IY9ZcB5HPr7lln5wmk7bm71m1+ZerrIh2+JnqRQtXt6kSYFFSigewXJrU1a9qNTpCv0vbC0qKwhpmW4VGABZGMNBzKZ/Rph92SEnpcM2L7OLcxoHWEa25hd16cTEnDx5cw+vqFClL4wyvLW3lfEK1I6+fPqanS8303VH3djSDpM/5YG/p1it9OS/5CLAszPx+4i/pejOHj7H9mpTcPIU5hc8V67ljprpBwT+E1vbJLYwAuh9eWXJXqBzhaxLdhVqEibWcc1jsZoGMNLaJOE= X-Microsoft-Exchange-Diagnostics: 1; AM0PR08MB3347; 6:rWbD5tc5zrN5aSAoTzZGf2kRImtAiJMv6gsbjCd/mt321BDeHFMfynljJYFsckbQCwAp6M/8j4kN2LllbKR3TthORJkiIyKla0kXmEB1ikX8uGjsYVmt7sVXRBDI+ylYGpikCPvq5FJ0lg0BE4mgNlX+v/OjLv6IJK6alDLk7YOLBPcs7RsBXlNh63oWtsrp3QLRuF2jsfnLgLY/mD1zj5WbZkbmCMvCDgBWjxe8vV8QxtGD2wbW8ffvNSDuBkxvM1bhD3Hes+aNy4rHIAaQJKNUaoTvXimMjCTxGy9TefNSd/8fHkYf4IAkqL4ZpkRw37wwXZAaVIVvLaHmLmG42g9zAvp3J26tvG3+BANO9SyMJ7vvr+9xgyn9o6gV209R2MgY7S/QHWAvADGW+3vezBE2PSqNtFZxWZIBeyog1w1yXa3C6LbQbXU2LzIDRNnloOm2AFzqbCSK4qEIAK0Gpg==; 5:KR8hXfQeuYTiBMr6i1sx1tQvzeio+RshS11UGdmm2q0BmF1zPN8XhRP0lniPRiiOwnFct1zXoYtHKlNXxBMXur1sNrLWA9DfVjp73hENb7h+TENk4aD6f+rTbK/5EHtFUW99sdnJD0UDf0xPP5fkkSFlU2clX1C7D0rZviL6y4k=; 7:HhDnd2SUqcNgtoRrAEaICG5IE2iAUKGTbHwc9n/LOA1op3XHpjVZgyZw/NY+75ddecApO1ieHjnkCt+Tk49Hy8N7oAiWFsnjj5zHLguzlGFsqc4fRqPWdy0rrjBvtcn7PmdfXxia9jJ6pb0mILljw8oIPGmq7QyetCSeumLxmQEu3pkndlJKCwcD7BZVhNDLYVCwZMfvTrGDDTwYkfsXGPYiLouv2vvNSGVN8d2/wqvSkLQs0qYmn1vQHczIwq5V SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM0PR08MB3347; 20:5KzVQns1qg61ckOpY2mve7DWotG+/eF1sze8a8JyDtVNxKZ2Tq2fU8vtOMScVsaHqx/oj6draYh2gBmYgzhUAVLFVMyHqg2wo4+dftxAdwus5AHrYAHKaeBSmRU1czsijRRLbvPgQw5kdKOK3aD3Xbs+LgZZ71D4jXOYr5w0NBc= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2018 09:46:40.8417 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e847e81e-9958-4282-95b4-08d6074affc1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3347 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.4.122 Subject: [Qemu-devel] [PATCH v4 1/8] qapi: group BlockDeviceStats fields X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, Anton Nefedov , famz@redhat.com, den@virtuozzo.com, qemu-block@nongnu.org, armbru@redhat.com, mreitz@redhat.com, berto@igalia.com, pbonzini@redhat.com, jsnow@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Make the stat fields definition slightly more readable. Also reorder total_time_ns stats read-write-flush as done elsewhere. Cosmetic change only. Signed-off-by: Anton Nefedov --- qapi/block-core.json | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 4c7a37a..44d992f 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -784,12 +784,12 @@ # @flush_operations: The number of cache flush operations performed by the # device (since 0.15.0) # -# @flush_total_time_ns: Total time spend on cache flushes in nano-seconds -# (since 0.15.0). +# @rd_total_time_ns: Total time spent on reads in nanoseconds (since 0.15.0). # -# @wr_total_time_ns: Total time spend on writes in nano-seconds (since 0.15.0). +# @wr_total_time_ns: Total time spent on writes in nanoseconds (since 0.15.0). # -# @rd_total_time_ns: Total_time_spend on reads in nano-seconds (since 0.15.0). +# @flush_total_time_ns: Total time spent on cache flushes in nanoseconds +# (since 0.15.0). # # @wr_highest_offset: The offset after the greatest byte written to the # device. The intended use of this information is for @@ -842,14 +842,18 @@ # Since: 0.14.0 ## { 'struct': 'BlockDeviceStats', - 'data': {'rd_bytes': 'int', 'wr_bytes': 'int', 'rd_operations': 'int', - 'wr_operations': 'int', 'flush_operations': 'int', - 'flush_total_time_ns': 'int', 'wr_total_time_ns': 'int', - 'rd_total_time_ns': 'int', 'wr_highest_offset': 'int', - 'rd_merged': 'int', 'wr_merged': 'int', '*idle_time_ns': 'int', + 'data': {'rd_bytes': 'int', 'wr_bytes': 'int', + 'rd_operations': 'int', 'wr_operations': 'int', + 'flush_operations': 'int', + 'rd_total_time_ns': 'int', 'wr_total_time_ns': 'int', + 'flush_total_time_ns': 'int', + 'wr_highest_offset': 'int', + 'rd_merged': 'int', 'wr_merged': 'int', + '*idle_time_ns': 'int', 'failed_rd_operations': 'int', 'failed_wr_operations': 'int', - 'failed_flush_operations': 'int', 'invalid_rd_operations': 'int', - 'invalid_wr_operations': 'int', 'invalid_flush_operations': 'int', + 'failed_flush_operations': 'int', + 'invalid_rd_operations': 'int', 'invalid_wr_operations': 'int', + 'invalid_flush_operations': 'int', 'account_invalid': 'bool', 'account_failed': 'bool', 'timed_stats': ['BlockDeviceTimedStats'], '*x_rd_latency_histogram': 'BlockLatencyHistogramInfo',