| Message ID | 1544253511-82742-1-git-send-email-peng.hao2@zte.com.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/watchdog/wdt_i6300esb : remove a unnecessary comment | expand |
On 08/12/18 08:18, Peng Hao wrote: > The registered memory region of i6300esb is not suitable for coalesced > mmio, because a write for the region may trigger an immediate action > and can't be delayed. > > Signed-off-by: Peng Hao <peng.hao2@zte.com.cn> > --- > hw/watchdog/wdt_i6300esb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c > index 7b59469..1c6eddf 100644 > --- a/hw/watchdog/wdt_i6300esb.c > +++ b/hw/watchdog/wdt_i6300esb.c > @@ -449,7 +449,6 @@ static void i6300esb_realize(PCIDevice *dev, Error **errp) > memory_region_init_io(&d->io_mem, OBJECT(d), &i6300esb_ops, d, > "i6300esb", 0x10); > pci_register_bar(&d->dev, 0, 0, &d->io_mem); > - /* qemu_register_coalesced_mmio (addr, 0x10); ? */ > } > > static void i6300esb_exit(PCIDevice *dev) > Queued, thanks. Paolo
diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c index 7b59469..1c6eddf 100644 --- a/hw/watchdog/wdt_i6300esb.c +++ b/hw/watchdog/wdt_i6300esb.c @@ -449,7 +449,6 @@ static void i6300esb_realize(PCIDevice *dev, Error **errp) memory_region_init_io(&d->io_mem, OBJECT(d), &i6300esb_ops, d, "i6300esb", 0x10); pci_register_bar(&d->dev, 0, 0, &d->io_mem); - /* qemu_register_coalesced_mmio (addr, 0x10); ? */ } static void i6300esb_exit(PCIDevice *dev)
The registered memory region of i6300esb is not suitable for coalesced mmio, because a write for the region may trigger an immediate action and can't be delayed. Signed-off-by: Peng Hao <peng.hao2@zte.com.cn> --- hw/watchdog/wdt_i6300esb.c | 1 - 1 file changed, 1 deletion(-)