| Message ID | 1623436283-20213-2-git-send-email-eric.devolder@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | acpi: Error Record Serialization Table, ERST, support for QEMU | expand |
On Fri, 11 Jun 2021 14:31:18 -0400 Eric DeVolder <eric.devolder@oracle.com> wrote: > Following the guidelines in tests/qtest/bios-tables-test.c, this > change adds empty placeholder files per step 1 for the new ERST > table, and excludes resulting changed files in bios-tables-test-allowed-diff.h > per step 2. > > Signed-off-by: Eric DeVolder <eric.devolder@oracle.com> Acked-by: Igor Mammedov <imammedo@redhat.com> > --- > tests/data/acpi/microvm/ERST | 0 > tests/data/acpi/pc/ERST | 0 > tests/data/acpi/q35/ERST | 0 > tests/qtest/bios-tables-test-allowed-diff.h | 4 ++++ > 4 files changed, 4 insertions(+) > create mode 100644 tests/data/acpi/microvm/ERST > create mode 100644 tests/data/acpi/pc/ERST > create mode 100644 tests/data/acpi/q35/ERST > > diff --git a/tests/data/acpi/microvm/ERST b/tests/data/acpi/microvm/ERST > new file mode 100644 > index 0000000..e69de29 > diff --git a/tests/data/acpi/pc/ERST b/tests/data/acpi/pc/ERST > new file mode 100644 > index 0000000..e69de29 > diff --git a/tests/data/acpi/q35/ERST b/tests/data/acpi/q35/ERST > new file mode 100644 > index 0000000..e69de29 > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h > index dfb8523..e004c71 100644 > --- a/tests/qtest/bios-tables-test-allowed-diff.h > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > @@ -1 +1,5 @@ > /* List of comma-separated changed AML files to ignore */ > +"tests/data/acpi/pc/ERST", > +"tests/data/acpi/q35/ERST", > +"tests/data/acpi/microvm/ERST", > +
On Tue, 22 Jun 2021 08:34:09 +0200 Igor Mammedov <imammedo@redhat.com> wrote: > On Fri, 11 Jun 2021 14:31:18 -0400 > Eric DeVolder <eric.devolder@oracle.com> wrote: > > > Following the guidelines in tests/qtest/bios-tables-test.c, this > > change adds empty placeholder files per step 1 for the new ERST > > table, and excludes resulting changed files in bios-tables-test-allowed-diff.h > > per step 2. > > > > Signed-off-by: Eric DeVolder <eric.devolder@oracle.com> > Acked-by: Igor Mammedov <imammedo@redhat.com> > > > --- > > tests/data/acpi/microvm/ERST | 0 > > tests/data/acpi/pc/ERST | 0 > > tests/data/acpi/q35/ERST | 0 wait, you are adding empty template files here but the later matching bios-tables-test is nowhere to be found Was testcase lost somewhere along the way? also it seems you add ERST only to pc/q35, so why tests/data/acpi/microvm/ERST is here? > > tests/qtest/bios-tables-test-allowed-diff.h | 4 ++++ > > 4 files changed, 4 insertions(+) > > create mode 100644 tests/data/acpi/microvm/ERST > > create mode 100644 tests/data/acpi/pc/ERST > > create mode 100644 tests/data/acpi/q35/ERST > > > > diff --git a/tests/data/acpi/microvm/ERST b/tests/data/acpi/microvm/ERST > > new file mode 100644 > > index 0000000..e69de29 > > diff --git a/tests/data/acpi/pc/ERST b/tests/data/acpi/pc/ERST > > new file mode 100644 > > index 0000000..e69de29 > > diff --git a/tests/data/acpi/q35/ERST b/tests/data/acpi/q35/ERST > > new file mode 100644 > > index 0000000..e69de29 > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h > > index dfb8523..e004c71 100644 > > --- a/tests/qtest/bios-tables-test-allowed-diff.h > > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > > @@ -1 +1,5 @@ > > /* List of comma-separated changed AML files to ignore */ > > +"tests/data/acpi/pc/ERST", > > +"tests/data/acpi/q35/ERST", > > +"tests/data/acpi/microvm/ERST", > > + > >
diff --git a/tests/data/acpi/microvm/ERST b/tests/data/acpi/microvm/ERST new file mode 100644 index 0000000..e69de29 diff --git a/tests/data/acpi/pc/ERST b/tests/data/acpi/pc/ERST new file mode 100644 index 0000000..e69de29 diff --git a/tests/data/acpi/q35/ERST b/tests/data/acpi/q35/ERST new file mode 100644 index 0000000..e69de29 diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523..e004c71 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1 +1,5 @@ /* List of comma-separated changed AML files to ignore */ +"tests/data/acpi/pc/ERST", +"tests/data/acpi/q35/ERST", +"tests/data/acpi/microvm/ERST", +
Following the guidelines in tests/qtest/bios-tables-test.c, this change adds empty placeholder files per step 1 for the new ERST table, and excludes resulting changed files in bios-tables-test-allowed-diff.h per step 2. Signed-off-by: Eric DeVolder <eric.devolder@oracle.com> --- tests/data/acpi/microvm/ERST | 0 tests/data/acpi/pc/ERST | 0 tests/data/acpi/q35/ERST | 0 tests/qtest/bios-tables-test-allowed-diff.h | 4 ++++ 4 files changed, 4 insertions(+) create mode 100644 tests/data/acpi/microvm/ERST create mode 100644 tests/data/acpi/pc/ERST create mode 100644 tests/data/acpi/q35/ERST