| Message ID | 1628202639-16361-11-git-send-email-eric.devolder@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | acpi: Error Record Serialization Table, ERST, support for QEMU | expand |
Well, I discovered today that running "make check" again resulted in bios table mismatches. In looking into this further, I think I might finally have an understanding as to how this is all to work. My bios-tables-test-allowed-diff for step 1 now looks like: "tests/data/acpi/pc/DSDT.acpierst", "tests/data/acpi/pc/ERST", "tests/data/acpi/q35/DSDT.acpierst", "tests/data/acpi/q35/ERST", "tests/data/acpi/microvm/ERST.pcie", and with the corresponding empty files and by using the .variant = ".acpierst" in bios-tables-test, I am able to run "make check" multiple times now without failures. So, that means patch 01/10 and 10/10 are wrong. I'm assuming there will be other items to address, so I'll plan for these fixes in v7. My apologies, eric On 8/5/21 5:30 PM, Eric DeVolder wrote: > Following the guidelines in tests/qtest/bios-tables-test.c, this > is step 6, the re-generated ACPI tables binary blobs. > > Signed-off-by: Eric DeVolder <eric.devolder@oracle.com> > --- > tests/data/acpi/microvm/ERST.pcie | Bin 0 -> 912 bytes > tests/data/acpi/pc/DSDT | Bin 6002 -> 6009 bytes > tests/data/acpi/pc/ERST | Bin 0 -> 912 bytes > tests/data/acpi/q35/DSDT | Bin 8289 -> 8306 bytes > tests/data/acpi/q35/ERST | Bin 0 -> 912 bytes > tests/qtest/bios-tables-test-allowed-diff.h | 6 ------ > 6 files changed, 6 deletions(-) > create mode 100644 tests/data/acpi/microvm/ERST.pcie > > diff --git a/tests/data/acpi/microvm/ERST.pcie b/tests/data/acpi/microvm/ERST.pcie > new file mode 100644 > index 0000000000000000000000000000000000000000..d9a2b3211ab5893a50751ad52be3782579e367f2 > GIT binary patch > literal 912 > zcmaKpO%8%E5QPUQ|KVrvh9h_c12J)@5f?5!k_Ygv*jGA8UW7?#`}+D#XXyDpKHiZ? > z@anI_W$gOrZRl(SB7!yMqx}#E4EC&a5=}m^g_!0^0`kEl)DOuIXM6D@@*xq*8vyqH > z)b0KTlmlgmH~xt7vG<k#Z1~z=OnyT76ZX;Ysy^;NC0^^$`kY?zKK;^vMtny1JAD$P > zc^BR{l;i*H`IJAW`~~?1`_TXD_wQ2@UlL!DU$GCpQ-4i-O}x_^JdQTRH^e)=(_c$` > LOT5z?_v4Aa+v(5& > > literal 0 > HcmV?d00001 > > diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT > index cc1223773e9c459a8d2f20666c051a74338d40b7..bff625a25602fa954b5b395fea53e3c7dfaca485 100644 > GIT binary patch > delta 85 > zcmeyQ_fwC{CD<jTQk;Q-F=QiG057Ni!kGAAr+5MP$;rGe;+`zQh8FQ0@s2J*JPZuX > l3>=QZp?+M<lN)&@ggD~CY!RV&S1$v`0B2XP&5C@1oB+Xc6m$Rp > > delta 65 > zcmeyV_eqb-CD<jTNSuLzao$F*0A5ayg)#BLPVoW`laqN{#GF`y4K3n1;)6r|xR^QO > V9bJNW7#Nr*U*I#`Y|7`t2>@&@5ljF8 > > diff --git a/tests/data/acpi/pc/ERST b/tests/data/acpi/pc/ERST > index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..f24fadd345c798ee5c17cdb66e0e1703bd1b2f26 100644 > GIT binary patch > literal 912 > zcmaKpOAdlC6h#XZC=fn#CoF*_7>J28jW}>wF2KFG3zs9lTPTnl;U#=7r>E_sr(1u2 > z21<FK_R^jEx_w-`TFO&O;T_LLF4O@x8LMi!H}5Z^t6_Tah{H!Y?i2S%JoA7!BFgz1 > zf~;?N{b8^}H2K=viyuzh`L7M``U{CiG=Ib#4X^gc{m10T<lDURCp`CW$T#HMd{o-? > zH~aE`PznCu9;f*enm;9;GDrTme_0zSBR|7ODR;g(@qEM!N8Z_gL4HBL%^N<3mgJY@ > R+q~0XMSexT%^U0Ee0~)`g#iEn > > literal 0 > HcmV?d00001 > > diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT > index 842533f53e6db40935c3cdecd1d182edba6c17d4..950c286b4c751f3c116a11d8892779942375e16b 100644 > GIT binary patch > delta 59 > zcmaFp@X3M8CD<jTNP&TYv2`OCrvjHhYfOBwQ@nsX>ttC4TZ!l<{$N9cc#e2SmmnSn > O1||j(wg6|p5C#C(xDBxY > > delta 42 > xcmez5@X&$FCD<h-QGtPh@##h`P6aMMmYDcpr+5K3mdUaTw(KHo0nUCQ3;+kH3ZMW0 > > diff --git a/tests/data/acpi/q35/ERST b/tests/data/acpi/q35/ERST > index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..f24fadd345c798ee5c17cdb66e0e1703bd1b2f26 100644 > GIT binary patch > literal 912 > zcmaKpOAdlC6h#XZC=fn#CoF*_7>J28jW}>wF2KFG3zs9lTPTnl;U#=7r>E_sr(1u2 > z21<FK_R^jEx_w-`TFO&O;T_LLF4O@x8LMi!H}5Z^t6_Tah{H!Y?i2S%JoA7!BFgz1 > zf~;?N{b8^}H2K=viyuzh`L7M``U{CiG=Ib#4X^gc{m10T<lDURCp`CW$T#HMd{o-? > zH~aE`PznCu9;f*enm;9;GDrTme_0zSBR|7ODR;g(@qEM!N8Z_gL4HBL%^N<3mgJY@ > R+q~0XMSexT%^U0Ee0~)`g#iEn > > literal 0 > HcmV?d00001 > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h > index b3aaf76..dfb8523 100644 > --- a/tests/qtest/bios-tables-test-allowed-diff.h > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > @@ -1,7 +1 @@ > /* List of comma-separated changed AML files to ignore */ > -"tests/data/acpi/pc/ERST", > -"tests/data/acpi/q35/ERST", > -"tests/data/acpi/microvm/ERST", > -"tests/data/acpi/pc/DSDT", > -"tests/data/acpi/q35/DSDT", > -"tests/data/acpi/microvm/DSDT", >
Igor, I'm not sure if I should post v7 with the correction to the tables, or await your guidance/feedback on v6. Thanks, eric On 8/6/21 12:16 PM, Eric DeVolder wrote: > Well, I discovered today that running "make check" again resulted in > bios table mismatches. In looking into this further, I think I might > finally have an understanding as to how this is all to work. My > bios-tables-test-allowed-diff for step 1 now looks like: > > "tests/data/acpi/pc/DSDT.acpierst", > "tests/data/acpi/pc/ERST", > "tests/data/acpi/q35/DSDT.acpierst", > "tests/data/acpi/q35/ERST", > "tests/data/acpi/microvm/ERST.pcie", > > and with the corresponding empty files and by using the > .variant = ".acpierst" > in bios-tables-test, I am able to run "make check" multiple times > now without failures. > > So, that means patch 01/10 and 10/10 are wrong. I'm assuming there > will be other items to address, so I'll plan for these fixes in > v7. > > My apologies, > eric > > > On 8/5/21 5:30 PM, Eric DeVolder wrote: >> Following the guidelines in tests/qtest/bios-tables-test.c, this >> is step 6, the re-generated ACPI tables binary blobs. >> >> Signed-off-by: Eric DeVolder <eric.devolder@oracle.com> >> --- >> tests/data/acpi/microvm/ERST.pcie | Bin 0 -> 912 bytes >> tests/data/acpi/pc/DSDT | Bin 6002 -> 6009 bytes >> tests/data/acpi/pc/ERST | Bin 0 -> 912 bytes >> tests/data/acpi/q35/DSDT | Bin 8289 -> 8306 bytes >> tests/data/acpi/q35/ERST | Bin 0 -> 912 bytes >> tests/qtest/bios-tables-test-allowed-diff.h | 6 ------ >> 6 files changed, 6 deletions(-) >> create mode 100644 tests/data/acpi/microvm/ERST.pcie >> >> diff --git a/tests/data/acpi/microvm/ERST.pcie b/tests/data/acpi/microvm/ERST.pcie >> new file mode 100644 >> index 0000000000000000000000000000000000000000..d9a2b3211ab5893a50751ad52be3782579e367f2 >> GIT binary patch >> literal 912 >> zcmaKpO%8%E5QPUQ|KVrvh9h_c12J)@5f?5!k_Ygv*jGA8UW7?#`}+D#XXyDpKHiZ? >> z@anI_W$gOrZRl(SB7!yMqx}#E4EC&a5=}m^g_!0^0`kEl)DOuIXM6D@@*xq*8vyqH >> z)b0KTlmlgmH~xt7vG<k#Z1~z=OnyT76ZX;Ysy^;NC0^^$`kY?zKK;^vMtny1JAD$P >> zc^BR{l;i*H`IJAW`~~?1`_TXD_wQ2@UlL!DU$GCpQ-4i-O}x_^JdQTRH^e)=(_c$` >> LOT5z?_v4Aa+v(5& >> >> literal 0 >> HcmV?d00001 >> >> diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT >> index cc1223773e9c459a8d2f20666c051a74338d40b7..bff625a25602fa954b5b395fea53e3c7dfaca485 100644 >> GIT binary patch >> delta 85 >> zcmeyQ_fwC{CD<jTQk;Q-F=QiG057Ni!kGAAr+5MP$;rGe;+`zQh8FQ0@s2J*JPZuX >> l3>=QZp?+M<lN)&@ggD~CY!RV&S1$v`0B2XP&5C@1oB+Xc6m$Rp >> >> delta 65 >> zcmeyV_eqb-CD<jTNSuLzao$F*0A5ayg)#BLPVoW`laqN{#GF`y4K3n1;)6r|xR^QO >> V9bJNW7#Nr*U*I#`Y|7`t2>@&@5ljF8 >> >> diff --git a/tests/data/acpi/pc/ERST b/tests/data/acpi/pc/ERST >> index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..f24fadd345c798ee5c17cdb66e0e1703bd1b2f26 100644 >> GIT binary patch >> literal 912 >> zcmaKpOAdlC6h#XZC=fn#CoF*_7>J28jW}>wF2KFG3zs9lTPTnl;U#=7r>E_sr(1u2 >> z21<FK_R^jEx_w-`TFO&O;T_LLF4O@x8LMi!H}5Z^t6_Tah{H!Y?i2S%JoA7!BFgz1 >> zf~;?N{b8^}H2K=viyuzh`L7M``U{CiG=Ib#4X^gc{m10T<lDURCp`CW$T#HMd{o-? >> zH~aE`PznCu9;f*enm;9;GDrTme_0zSBR|7ODR;g(@qEM!N8Z_gL4HBL%^N<3mgJY@ >> R+q~0XMSexT%^U0Ee0~)`g#iEn >> >> literal 0 >> HcmV?d00001 >> >> diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT >> index 842533f53e6db40935c3cdecd1d182edba6c17d4..950c286b4c751f3c116a11d8892779942375e16b 100644 >> GIT binary patch >> delta 59 >> zcmaFp@X3M8CD<jTNP&TYv2`OCrvjHhYfOBwQ@nsX>ttC4TZ!l<{$N9cc#e2SmmnSn >> O1||j(wg6|p5C#C(xDBxY >> >> delta 42 >> xcmez5@X&$FCD<h-QGtPh@##h`P6aMMmYDcpr+5K3mdUaTw(KHo0nUCQ3;+kH3ZMW0 >> >> diff --git a/tests/data/acpi/q35/ERST b/tests/data/acpi/q35/ERST >> index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..f24fadd345c798ee5c17cdb66e0e1703bd1b2f26 100644 >> GIT binary patch >> literal 912 >> zcmaKpOAdlC6h#XZC=fn#CoF*_7>J28jW}>wF2KFG3zs9lTPTnl;U#=7r>E_sr(1u2 >> z21<FK_R^jEx_w-`TFO&O;T_LLF4O@x8LMi!H}5Z^t6_Tah{H!Y?i2S%JoA7!BFgz1 >> zf~;?N{b8^}H2K=viyuzh`L7M``U{CiG=Ib#4X^gc{m10T<lDURCp`CW$T#HMd{o-? >> zH~aE`PznCu9;f*enm;9;GDrTme_0zSBR|7ODR;g(@qEM!N8Z_gL4HBL%^N<3mgJY@ >> R+q~0XMSexT%^U0Ee0~)`g#iEn >> >> literal 0 >> HcmV?d00001 >> >> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h >> b/tests/qtest/bios-tables-test-allowed-diff.h >> index b3aaf76..dfb8523 100644 >> --- a/tests/qtest/bios-tables-test-allowed-diff.h >> +++ b/tests/qtest/bios-tables-test-allowed-diff.h >> @@ -1,7 +1 @@ >> /* List of comma-separated changed AML files to ignore */ >> -"tests/data/acpi/pc/ERST", >> -"tests/data/acpi/q35/ERST", >> -"tests/data/acpi/microvm/ERST", >> -"tests/data/acpi/pc/DSDT", >> -"tests/data/acpi/q35/DSDT", >> -"tests/data/acpi/microvm/DSDT", >>
On Fri, 27 Aug 2021 16:45:15 -0500 Eric DeVolder <eric.devolder@oracle.com> wrote: > Igor, > I'm not sure if I should post v7 with the correction to the tables, > or await your guidance/feedback on v6. Hopefully, I'll be back to reviewing patches (including yours) next week. > Thanks, > eric > > > On 8/6/21 12:16 PM, Eric DeVolder wrote: > > Well, I discovered today that running "make check" again resulted in > > bios table mismatches. In looking into this further, I think I might > > finally have an understanding as to how this is all to work. My > > bios-tables-test-allowed-diff for step 1 now looks like: > > > > "tests/data/acpi/pc/DSDT.acpierst", > > "tests/data/acpi/pc/ERST", > > "tests/data/acpi/q35/DSDT.acpierst", > > "tests/data/acpi/q35/ERST", > > "tests/data/acpi/microvm/ERST.pcie", > > > > and with the corresponding empty files and by using the > > .variant = ".acpierst" > > in bios-tables-test, I am able to run "make check" multiple times > > now without failures. > > > > So, that means patch 01/10 and 10/10 are wrong. I'm assuming there > > will be other items to address, so I'll plan for these fixes in > > v7. > > > > My apologies, > > eric > > > > > > On 8/5/21 5:30 PM, Eric DeVolder wrote: > >> Following the guidelines in tests/qtest/bios-tables-test.c, this > >> is step 6, the re-generated ACPI tables binary blobs. > >> > >> Signed-off-by: Eric DeVolder <eric.devolder@oracle.com> > >> --- > >> tests/data/acpi/microvm/ERST.pcie | Bin 0 -> 912 bytes > >> tests/data/acpi/pc/DSDT | Bin 6002 -> 6009 bytes > >> tests/data/acpi/pc/ERST | Bin 0 -> 912 bytes > >> tests/data/acpi/q35/DSDT | Bin 8289 -> 8306 bytes > >> tests/data/acpi/q35/ERST | Bin 0 -> 912 bytes > >> tests/qtest/bios-tables-test-allowed-diff.h | 6 ------ > >> 6 files changed, 6 deletions(-) > >> create mode 100644 tests/data/acpi/microvm/ERST.pcie > >> > >> diff --git a/tests/data/acpi/microvm/ERST.pcie b/tests/data/acpi/microvm/ERST.pcie > >> new file mode 100644 > >> index 0000000000000000000000000000000000000000..d9a2b3211ab5893a50751ad52be3782579e367f2 > >> GIT binary patch > >> literal 912 > >> zcmaKpO%8%E5QPUQ|KVrvh9h_c12J)@5f?5!k_Ygv*jGA8UW7?#`}+D#XXyDpKHiZ? > >> z@anI_W$gOrZRl(SB7!yMqx}#E4EC&a5=}m^g_!0^0`kEl)DOuIXM6D@@*xq*8vyqH > >> z)b0KTlmlgmH~xt7vG<k#Z1~z=OnyT76ZX;Ysy^;NC0^^$`kY?zKK;^vMtny1JAD$P > >> zc^BR{l;i*H`IJAW`~~?1`_TXD_wQ2@UlL!DU$GCpQ-4i-O}x_^JdQTRH^e)=(_c$` > >> LOT5z?_v4Aa+v(5& > >> > >> literal 0 > >> HcmV?d00001 > >> > >> diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT > >> index cc1223773e9c459a8d2f20666c051a74338d40b7..bff625a25602fa954b5b395fea53e3c7dfaca485 100644 > >> GIT binary patch > >> delta 85 > >> zcmeyQ_fwC{CD<jTQk;Q-F=QiG057Ni!kGAAr+5MP$;rGe;+`zQh8FQ0@s2J*JPZuX > >> l3>=QZp?+M<lN)&@ggD~CY!RV&S1$v`0B2XP&5C@1oB+Xc6m$Rp > >> > >> delta 65 > >> zcmeyV_eqb-CD<jTNSuLzao$F*0A5ayg)#BLPVoW`laqN{#GF`y4K3n1;)6r|xR^QO > >> V9bJNW7#Nr*U*I#`Y|7`t2>@&@5ljF8 > >> > >> diff --git a/tests/data/acpi/pc/ERST b/tests/data/acpi/pc/ERST > >> index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..f24fadd345c798ee5c17cdb66e0e1703bd1b2f26 100644 > >> GIT binary patch > >> literal 912 > >> zcmaKpOAdlC6h#XZC=fn#CoF*_7>J28jW}>wF2KFG3zs9lTPTnl;U#=7r>E_sr(1u2 > >> z21<FK_R^jEx_w-`TFO&O;T_LLF4O@x8LMi!H}5Z^t6_Tah{H!Y?i2S%JoA7!BFgz1 > >> zf~;?N{b8^}H2K=viyuzh`L7M``U{CiG=Ib#4X^gc{m10T<lDURCp`CW$T#HMd{o-? > >> zH~aE`PznCu9;f*enm;9;GDrTme_0zSBR|7ODR;g(@qEM!N8Z_gL4HBL%^N<3mgJY@ > >> R+q~0XMSexT%^U0Ee0~)`g#iEn > >> > >> literal 0 > >> HcmV?d00001 > >> > >> diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT > >> index 842533f53e6db40935c3cdecd1d182edba6c17d4..950c286b4c751f3c116a11d8892779942375e16b 100644 > >> GIT binary patch > >> delta 59 > >> zcmaFp@X3M8CD<jTNP&TYv2`OCrvjHhYfOBwQ@nsX>ttC4TZ!l<{$N9cc#e2SmmnSn > >> O1||j(wg6|p5C#C(xDBxY > >> > >> delta 42 > >> xcmez5@X&$FCD<h-QGtPh@##h`P6aMMmYDcpr+5K3mdUaTw(KHo0nUCQ3;+kH3ZMW0 > >> > >> diff --git a/tests/data/acpi/q35/ERST b/tests/data/acpi/q35/ERST > >> index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..f24fadd345c798ee5c17cdb66e0e1703bd1b2f26 100644 > >> GIT binary patch > >> literal 912 > >> zcmaKpOAdlC6h#XZC=fn#CoF*_7>J28jW}>wF2KFG3zs9lTPTnl;U#=7r>E_sr(1u2 > >> z21<FK_R^jEx_w-`TFO&O;T_LLF4O@x8LMi!H}5Z^t6_Tah{H!Y?i2S%JoA7!BFgz1 > >> zf~;?N{b8^}H2K=viyuzh`L7M``U{CiG=Ib#4X^gc{m10T<lDURCp`CW$T#HMd{o-? > >> zH~aE`PznCu9;f*enm;9;GDrTme_0zSBR|7ODR;g(@qEM!N8Z_gL4HBL%^N<3mgJY@ > >> R+q~0XMSexT%^U0Ee0~)`g#iEn > >> > >> literal 0 > >> HcmV?d00001 > >> > >> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h > >> b/tests/qtest/bios-tables-test-allowed-diff.h > >> index b3aaf76..dfb8523 100644 > >> --- a/tests/qtest/bios-tables-test-allowed-diff.h > >> +++ b/tests/qtest/bios-tables-test-allowed-diff.h > >> @@ -1,7 +1 @@ > >> /* List of comma-separated changed AML files to ignore */ > >> -"tests/data/acpi/pc/ERST", > >> -"tests/data/acpi/q35/ERST", > >> -"tests/data/acpi/microvm/ERST", > >> -"tests/data/acpi/pc/DSDT", > >> -"tests/data/acpi/q35/DSDT", > >> -"tests/data/acpi/microvm/DSDT", > >> >
On Thu, 5 Aug 2021 18:30:39 -0400 Eric DeVolder <eric.devolder@oracle.com> wrote: > Following the guidelines in tests/qtest/bios-tables-test.c, this > is step 6, the re-generated ACPI tables binary blobs. commit message should include ASL diff for new/changed content for example see commit: 1aaef7d8092803 acpi: unit-test: Update WAET ACPI Table expected binaries > > Signed-off-by: Eric DeVolder <eric.devolder@oracle.com> > --- > tests/data/acpi/microvm/ERST.pcie | Bin 0 -> 912 bytes > tests/data/acpi/pc/DSDT | Bin 6002 -> 6009 bytes > tests/data/acpi/pc/ERST | Bin 0 -> 912 bytes > tests/data/acpi/q35/DSDT | Bin 8289 -> 8306 bytes > tests/data/acpi/q35/ERST | Bin 0 -> 912 bytes > tests/qtest/bios-tables-test-allowed-diff.h | 6 ------ > 6 files changed, 6 deletions(-) > create mode 100644 tests/data/acpi/microvm/ERST.pcie > > diff --git a/tests/data/acpi/microvm/ERST.pcie b/tests/data/acpi/microvm/ERST.pcie > new file mode 100644 > index 0000000000000000000000000000000000000000..d9a2b3211ab5893a50751ad52be3782579e367f2 > GIT binary patch > literal 912 > zcmaKpO%8%E5QPUQ|KVrvh9h_c12J)@5f?5!k_Ygv*jGA8UW7?#`}+D#XXyDpKHiZ? > z@anI_W$gOrZRl(SB7!yMqx}#E4EC&a5=}m^g_!0^0`kEl)DOuIXM6D@@*xq*8vyqH > z)b0KTlmlgmH~xt7vG<k#Z1~z=OnyT76ZX;Ysy^;NC0^^$`kY?zKK;^vMtny1JAD$P > zc^BR{l;i*H`IJAW`~~?1`_TXD_wQ2@UlL!DU$GCpQ-4i-O}x_^JdQTRH^e)=(_c$` > LOT5z?_v4Aa+v(5& > > literal 0 > HcmV?d00001 > > diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT > index cc1223773e9c459a8d2f20666c051a74338d40b7..bff625a25602fa954b5b395fea53e3c7dfaca485 100644 > GIT binary patch > delta 85 > zcmeyQ_fwC{CD<jTQk;Q-F=QiG057Ni!kGAAr+5MP$;rGe;+`zQh8FQ0@s2J*JPZuX > l3>=QZp?+M<lN)&@ggD~CY!RV&S1$v`0B2XP&5C@1oB+Xc6m$Rp > > delta 65 > zcmeyV_eqb-CD<jTNSuLzao$F*0A5ayg)#BLPVoW`laqN{#GF`y4K3n1;)6r|xR^QO > V9bJNW7#Nr*U*I#`Y|7`t2>@&@5ljF8 > > diff --git a/tests/data/acpi/pc/ERST b/tests/data/acpi/pc/ERST > index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..f24fadd345c798ee5c17cdb66e0e1703bd1b2f26 100644 > GIT binary patch > literal 912 > zcmaKpOAdlC6h#XZC=fn#CoF*_7>J28jW}>wF2KFG3zs9lTPTnl;U#=7r>E_sr(1u2 > z21<FK_R^jEx_w-`TFO&O;T_LLF4O@x8LMi!H}5Z^t6_Tah{H!Y?i2S%JoA7!BFgz1 > zf~;?N{b8^}H2K=viyuzh`L7M``U{CiG=Ib#4X^gc{m10T<lDURCp`CW$T#HMd{o-? > zH~aE`PznCu9;f*enm;9;GDrTme_0zSBR|7ODR;g(@qEM!N8Z_gL4HBL%^N<3mgJY@ > R+q~0XMSexT%^U0Ee0~)`g#iEn > > literal 0 > HcmV?d00001 > > diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT > index 842533f53e6db40935c3cdecd1d182edba6c17d4..950c286b4c751f3c116a11d8892779942375e16b 100644 > GIT binary patch > delta 59 > zcmaFp@X3M8CD<jTNP&TYv2`OCrvjHhYfOBwQ@nsX>ttC4TZ!l<{$N9cc#e2SmmnSn > O1||j(wg6|p5C#C(xDBxY > > delta 42 > xcmez5@X&$FCD<h-QGtPh@##h`P6aMMmYDcpr+5K3mdUaTw(KHo0nUCQ3;+kH3ZMW0 > > diff --git a/tests/data/acpi/q35/ERST b/tests/data/acpi/q35/ERST > index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..f24fadd345c798ee5c17cdb66e0e1703bd1b2f26 100644 > GIT binary patch > literal 912 > zcmaKpOAdlC6h#XZC=fn#CoF*_7>J28jW}>wF2KFG3zs9lTPTnl;U#=7r>E_sr(1u2 > z21<FK_R^jEx_w-`TFO&O;T_LLF4O@x8LMi!H}5Z^t6_Tah{H!Y?i2S%JoA7!BFgz1 > zf~;?N{b8^}H2K=viyuzh`L7M``U{CiG=Ib#4X^gc{m10T<lDURCp`CW$T#HMd{o-? > zH~aE`PznCu9;f*enm;9;GDrTme_0zSBR|7ODR;g(@qEM!N8Z_gL4HBL%^N<3mgJY@ > R+q~0XMSexT%^U0Ee0~)`g#iEn > > literal 0 > HcmV?d00001 > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h > index b3aaf76..dfb8523 100644 > --- a/tests/qtest/bios-tables-test-allowed-diff.h > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > @@ -1,7 +1 @@ > /* List of comma-separated changed AML files to ignore */ > -"tests/data/acpi/pc/ERST", > -"tests/data/acpi/q35/ERST", > -"tests/data/acpi/microvm/ERST", > -"tests/data/acpi/pc/DSDT", > -"tests/data/acpi/q35/DSDT", > -"tests/data/acpi/microvm/DSDT",
On 9/21/21 6:24 AM, Igor Mammedov wrote: > On Thu, 5 Aug 2021 18:30:39 -0400 > Eric DeVolder <eric.devolder@oracle.com> wrote: > >> Following the guidelines in tests/qtest/bios-tables-test.c, this >> is step 6, the re-generated ACPI tables binary blobs. > > > commit message should include ASL diff for new/changed content > > for example see commit: > 1aaef7d8092803 acpi: unit-test: Update WAET ACPI Table expected binaries done > >> >> Signed-off-by: Eric DeVolder <eric.devolder@oracle.com> >> --- >> tests/data/acpi/microvm/ERST.pcie | Bin 0 -> 912 bytes >> tests/data/acpi/pc/DSDT | Bin 6002 -> 6009 bytes >> tests/data/acpi/pc/ERST | Bin 0 -> 912 bytes >> tests/data/acpi/q35/DSDT | Bin 8289 -> 8306 bytes >> tests/data/acpi/q35/ERST | Bin 0 -> 912 bytes >> tests/qtest/bios-tables-test-allowed-diff.h | 6 ------ >> 6 files changed, 6 deletions(-) >> create mode 100644 tests/data/acpi/microvm/ERST.pcie >> >> diff --git a/tests/data/acpi/microvm/ERST.pcie b/tests/data/acpi/microvm/ERST.pcie >> new file mode 100644 >> index 0000000000000000000000000000000000000000..d9a2b3211ab5893a50751ad52be3782579e367f2 >> GIT binary patch >> literal 912 >> zcmaKpO%8%E5QPUQ|KVrvh9h_c12J)@5f?5!k_Ygv*jGA8UW7?#`}+D#XXyDpKHiZ? >> z@anI_W$gOrZRl(SB7!yMqx}#E4EC&a5=}m^g_!0^0`kEl)DOuIXM6D@@*xq*8vyqH >> z)b0KTlmlgmH~xt7vG<k#Z1~z=OnyT76ZX;Ysy^;NC0^^$`kY?zKK;^vMtny1JAD$P >> zc^BR{l;i*H`IJAW`~~?1`_TXD_wQ2@UlL!DU$GCpQ-4i-O}x_^JdQTRH^e)=(_c$` >> LOT5z?_v4Aa+v(5& >> >> literal 0 >> HcmV?d00001 >> >> diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT >> index cc1223773e9c459a8d2f20666c051a74338d40b7..bff625a25602fa954b5b395fea53e3c7dfaca485 100644 >> GIT binary patch >> delta 85 >> zcmeyQ_fwC{CD<jTQk;Q-F=QiG057Ni!kGAAr+5MP$;rGe;+`zQh8FQ0@s2J*JPZuX >> l3>=QZp?+M<lN)&@ggD~CY!RV&S1$v`0B2XP&5C@1oB+Xc6m$Rp >> >> delta 65 >> zcmeyV_eqb-CD<jTNSuLzao$F*0A5ayg)#BLPVoW`laqN{#GF`y4K3n1;)6r|xR^QO >> V9bJNW7#Nr*U*I#`Y|7`t2>@&@5ljF8 >> >> diff --git a/tests/data/acpi/pc/ERST b/tests/data/acpi/pc/ERST >> index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..f24fadd345c798ee5c17cdb66e0e1703bd1b2f26 100644 >> GIT binary patch >> literal 912 >> zcmaKpOAdlC6h#XZC=fn#CoF*_7>J28jW}>wF2KFG3zs9lTPTnl;U#=7r>E_sr(1u2 >> z21<FK_R^jEx_w-`TFO&O;T_LLF4O@x8LMi!H}5Z^t6_Tah{H!Y?i2S%JoA7!BFgz1 >> zf~;?N{b8^}H2K=viyuzh`L7M``U{CiG=Ib#4X^gc{m10T<lDURCp`CW$T#HMd{o-? >> zH~aE`PznCu9;f*enm;9;GDrTme_0zSBR|7ODR;g(@qEM!N8Z_gL4HBL%^N<3mgJY@ >> R+q~0XMSexT%^U0Ee0~)`g#iEn >> >> literal 0 >> HcmV?d00001 >> >> diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT >> index 842533f53e6db40935c3cdecd1d182edba6c17d4..950c286b4c751f3c116a11d8892779942375e16b 100644 >> GIT binary patch >> delta 59 >> zcmaFp@X3M8CD<jTNP&TYv2`OCrvjHhYfOBwQ@nsX>ttC4TZ!l<{$N9cc#e2SmmnSn >> O1||j(wg6|p5C#C(xDBxY >> >> delta 42 >> xcmez5@X&$FCD<h-QGtPh@##h`P6aMMmYDcpr+5K3mdUaTw(KHo0nUCQ3;+kH3ZMW0 >> >> diff --git a/tests/data/acpi/q35/ERST b/tests/data/acpi/q35/ERST >> index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..f24fadd345c798ee5c17cdb66e0e1703bd1b2f26 100644 >> GIT binary patch >> literal 912 >> zcmaKpOAdlC6h#XZC=fn#CoF*_7>J28jW}>wF2KFG3zs9lTPTnl;U#=7r>E_sr(1u2 >> z21<FK_R^jEx_w-`TFO&O;T_LLF4O@x8LMi!H}5Z^t6_Tah{H!Y?i2S%JoA7!BFgz1 >> zf~;?N{b8^}H2K=viyuzh`L7M``U{CiG=Ib#4X^gc{m10T<lDURCp`CW$T#HMd{o-? >> zH~aE`PznCu9;f*enm;9;GDrTme_0zSBR|7ODR;g(@qEM!N8Z_gL4HBL%^N<3mgJY@ >> R+q~0XMSexT%^U0Ee0~)`g#iEn >> >> literal 0 >> HcmV?d00001 >> >> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h >> index b3aaf76..dfb8523 100644 >> --- a/tests/qtest/bios-tables-test-allowed-diff.h >> +++ b/tests/qtest/bios-tables-test-allowed-diff.h >> @@ -1,7 +1 @@ >> /* List of comma-separated changed AML files to ignore */ >> -"tests/data/acpi/pc/ERST", >> -"tests/data/acpi/q35/ERST", >> -"tests/data/acpi/microvm/ERST", >> -"tests/data/acpi/pc/DSDT", >> -"tests/data/acpi/q35/DSDT", >> -"tests/data/acpi/microvm/DSDT", >
diff --git a/tests/data/acpi/microvm/ERST.pcie b/tests/data/acpi/microvm/ERST.pcie new file mode 100644 index 0000000000000000000000000000000000000000..d9a2b3211ab5893a50751ad52be3782579e367f2 GIT binary patch literal 912 zcmaKpO%8%E5QPUQ|KVrvh9h_c12J)@5f?5!k_Ygv*jGA8UW7?#`}+D#XXyDpKHiZ? z@anI_W$gOrZRl(SB7!yMqx}#E4EC&a5=}m^g_!0^0`kEl)DOuIXM6D@@*xq*8vyqH z)b0KTlmlgmH~xt7vG<k#Z1~z=OnyT76ZX;Ysy^;NC0^^$`kY?zKK;^vMtny1JAD$P zc^BR{l;i*H`IJAW`~~?1`_TXD_wQ2@UlL!DU$GCpQ-4i-O}x_^JdQTRH^e)=(_c$` LOT5z?_v4Aa+v(5& literal 0 HcmV?d00001 diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT index cc1223773e9c459a8d2f20666c051a74338d40b7..bff625a25602fa954b5b395fea53e3c7dfaca485 100644 GIT binary patch delta 85 zcmeyQ_fwC{CD<jTQk;Q-F=QiG057Ni!kGAAr+5MP$;rGe;+`zQh8FQ0@s2J*JPZuX l3>=QZp?+M<lN)&@ggD~CY!RV&S1$v`0B2XP&5C@1oB+Xc6m$Rp delta 65 zcmeyV_eqb-CD<jTNSuLzao$F*0A5ayg)#BLPVoW`laqN{#GF`y4K3n1;)6r|xR^QO V9bJNW7#Nr*U*I#`Y|7`t2>@&@5ljF8 diff --git a/tests/data/acpi/pc/ERST b/tests/data/acpi/pc/ERST index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..f24fadd345c798ee5c17cdb66e0e1703bd1b2f26 100644 GIT binary patch literal 912 zcmaKpOAdlC6h#XZC=fn#CoF*_7>J28jW}>wF2KFG3zs9lTPTnl;U#=7r>E_sr(1u2 z21<FK_R^jEx_w-`TFO&O;T_LLF4O@x8LMi!H}5Z^t6_Tah{H!Y?i2S%JoA7!BFgz1 zf~;?N{b8^}H2K=viyuzh`L7M``U{CiG=Ib#4X^gc{m10T<lDURCp`CW$T#HMd{o-? zH~aE`PznCu9;f*enm;9;GDrTme_0zSBR|7ODR;g(@qEM!N8Z_gL4HBL%^N<3mgJY@ R+q~0XMSexT%^U0Ee0~)`g#iEn literal 0 HcmV?d00001 diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT index 842533f53e6db40935c3cdecd1d182edba6c17d4..950c286b4c751f3c116a11d8892779942375e16b 100644 GIT binary patch delta 59 zcmaFp@X3M8CD<jTNP&TYv2`OCrvjHhYfOBwQ@nsX>ttC4TZ!l<{$N9cc#e2SmmnSn O1||j(wg6|p5C#C(xDBxY delta 42 xcmez5@X&$FCD<h-QGtPh@##h`P6aMMmYDcpr+5K3mdUaTw(KHo0nUCQ3;+kH3ZMW0 diff --git a/tests/data/acpi/q35/ERST b/tests/data/acpi/q35/ERST index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..f24fadd345c798ee5c17cdb66e0e1703bd1b2f26 100644 GIT binary patch literal 912 zcmaKpOAdlC6h#XZC=fn#CoF*_7>J28jW}>wF2KFG3zs9lTPTnl;U#=7r>E_sr(1u2 z21<FK_R^jEx_w-`TFO&O;T_LLF4O@x8LMi!H}5Z^t6_Tah{H!Y?i2S%JoA7!BFgz1 zf~;?N{b8^}H2K=viyuzh`L7M``U{CiG=Ib#4X^gc{m10T<lDURCp`CW$T#HMd{o-? zH~aE`PznCu9;f*enm;9;GDrTme_0zSBR|7ODR;g(@qEM!N8Z_gL4HBL%^N<3mgJY@ R+q~0XMSexT%^U0Ee0~)`g#iEn literal 0 HcmV?d00001 diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index b3aaf76..dfb8523 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1,7 +1 @@ /* List of comma-separated changed AML files to ignore */ -"tests/data/acpi/pc/ERST", -"tests/data/acpi/q35/ERST", -"tests/data/acpi/microvm/ERST", -"tests/data/acpi/pc/DSDT", -"tests/data/acpi/q35/DSDT", -"tests/data/acpi/microvm/DSDT",
Following the guidelines in tests/qtest/bios-tables-test.c, this is step 6, the re-generated ACPI tables binary blobs. Signed-off-by: Eric DeVolder <eric.devolder@oracle.com> --- tests/data/acpi/microvm/ERST.pcie | Bin 0 -> 912 bytes tests/data/acpi/pc/DSDT | Bin 6002 -> 6009 bytes tests/data/acpi/pc/ERST | Bin 0 -> 912 bytes tests/data/acpi/q35/DSDT | Bin 8289 -> 8306 bytes tests/data/acpi/q35/ERST | Bin 0 -> 912 bytes tests/qtest/bios-tables-test-allowed-diff.h | 6 ------ 6 files changed, 6 deletions(-) create mode 100644 tests/data/acpi/microvm/ERST.pcie