[v4,3/7] vhost-vdpa: fix improper cleanup in net_init_vhost_vdpa

Commit Message

Si-Wei Liu May 7, 2022, 2:28 a.m. UTC

... such that no memory leaks on dangling net clients in case of
error.

Signed-off-by: Si-Wei Liu <[e-mail]>
Acked-by: Jason Wang <[e-mail]>
---
 net/vhost-vdpa.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Patch

diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 1e9fe47..df1e69e 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -306,7 +306,9 @@  int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
 
 err:
     if (i) {
-        qemu_del_net_client(ncs[0]);
+        for (i--; i >= 0; i--) {
+            qemu_del_net_client(ncs[i]);
+        }
     }
     qemu_close(vdpa_device_fd);